From patchwork Tue Mar 16 17:19:12 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Robert Foss X-Patchwork-Id: 401699 Delivered-To: patch@linaro.org Received: by 2002:a02:8562:0:0:0:0:0 with SMTP id g89csp4499736jai; Tue, 16 Mar 2021 10:21:11 -0700 (PDT) X-Google-Smtp-Source: ABdhPJySjetcsmhTR5J/4SIIGMVmEPRzzXvfBlTINUOA22nkP7aDyX1OHIb8nBe9ZzqYRF0/8yQG X-Received: by 2002:a17:906:b318:: with SMTP id n24mr19289645ejz.372.1615915271626; Tue, 16 Mar 2021 10:21:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1615915271; cv=none; d=google.com; s=arc-20160816; b=bqXEHaIRXV7unnofJoJd9FSlm4i9b+16JD+hCoEroIgj4JzYJv0bkaeI1XAhcCcS7k kK+BOvkNilD8KKNttQeb0DYExfL059N/BonfRFWH5tNdC2Nmx39Q5lsgnp9x7Ozgl7sn ZRxA+6eyv5AyLYAYPH13uQEk2Kw7vTNOsP8jZnCPiwxdkagGkAOD1highE6vjIWT6qWP KRL+Wk5xZjdASRY4aZFZ4T+astbRMxuR8BIbPphd/LZrS0yAHx/3LPITwFvPx7wiBPHk 63Z5u9q6tfOcftU4nuuX0x1wv+fR3KLVhfuBC9HPDBpeaVsrFx+6GxkK3Hyx/2h4CRkg JJpg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=cSV1QKNQjYqrK510Qq0VKMC5Xs02r+/lUWyK45ndNmg=; b=E4D2XsFLyh5oYhWKe8VlAgT0p3qPG5a/v9pKAk5kknDXefZ7pWT7rwCUVhxZRA3EKW Bx+PCnowOxInz/EjzyIPYqqm1x8Ykwf8C4dXg7a62B/DeaORjVvzMouxa0wywUIAqeRL 1RkLwIIFf9GzAfdQhg2HLTUtoMasO+EH519kkh7hau1p0Ve2NRAid2fJYAMKIAVHOLNc B0D5DPA2UyvKXfzAzQBf/p6bbiTxqV5X71nixK1mMkGWrezU1PkUY07jH0kawAIJ7Zqs WUa3nEvDmO1I9C7JublI7QJlcqTmFwRmV0ynkikQjmHkKEK4jqo3BzYTTqfBNtnpoXjj j/mg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=EIRbPjVn; spf=pass (google.com: domain of linux-arm-msm-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-arm-msm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v28si15629914edl.428.2021.03.16.10.21.11; Tue, 16 Mar 2021 10:21:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-arm-msm-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=EIRbPjVn; spf=pass (google.com: domain of linux-arm-msm-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-arm-msm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239151AbhCPRUg (ORCPT + 16 others); Tue, 16 Mar 2021 13:20:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60694 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238808AbhCPRUL (ORCPT ); Tue, 16 Mar 2021 13:20:11 -0400 Received: from mail-ej1-x630.google.com (mail-ej1-x630.google.com [IPv6:2a00:1450:4864:20::630]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 50FC5C061765 for ; Tue, 16 Mar 2021 10:20:11 -0700 (PDT) Received: by mail-ej1-x630.google.com with SMTP id mm21so73413424ejb.12 for ; Tue, 16 Mar 2021 10:20:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=cSV1QKNQjYqrK510Qq0VKMC5Xs02r+/lUWyK45ndNmg=; b=EIRbPjVn/nx4YbMFUVcvke42aBxS0e1DiuIxDOz22nIx7Zz1ncyMt4d9fgQLSnP3QQ pzgY5VI/Lnl+WZQrYF0yA6ZUr/YQ9nP2lszUtx5Ehgu7HDWHbnsLN9U6MkI/Id0PDA4Q 5oH4lwj61cW47V1PW229DeMV9mglZhmEDICaM7FbWpJoVlOynpmF5EAWTydxYTPckNgD 0NOe7n+dSHH/Yi1+RU9U7rVZllo5Yc7hUg/0vzLLziM8dpGo6ZST+fBuajiF7pwcQFqe j6GaG0beDE9TJriIFyyPWQNSP65W5lOWXP5yZ5ylNVeGfBXIqslQTH1HtN9gBdTzULop 1hlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=cSV1QKNQjYqrK510Qq0VKMC5Xs02r+/lUWyK45ndNmg=; b=BQtVpqorzWFEyGxXnelLsgcYIG3QcSjQOjJ7MdNs1ROAdGM+YL9ZG8EgBVNquGgaqD +S7WxKJbCiZDkn4bIYDRhgiI7jJIXdgKh0CS43JekADnWhlMpZhJilrJ8qyHT2kGBWXt QKgakLpnEmpVm3H6kKwjxU6mJUnJbS63H2HKwQSw77vld0XrLVhOW6PHfSGczOJsT0h5 j+pfFG2kJx73b+PHzDLshKlMjuthEAjbXnBy0W5ORwi216WL8rlA7MvJVTCpAABTXnGu IYgDrSGQJNNgrjaaa5asSyD+07LBZbHza3rxX1faLrvOwtaSHFAVjXI4SU9IWby3Sa5i +cdw== X-Gm-Message-State: AOAM532gL1LrsQ98GtIBspiB04c4cexyb3fqfFqIFBXD9CPZLdXEitxr sDkytbxglErG62txFYdMDgm+QA== X-Received: by 2002:a17:906:5e55:: with SMTP id b21mr14866759eju.289.1615915210080; Tue, 16 Mar 2021 10:20:10 -0700 (PDT) Received: from localhost.localdomain ([37.120.1.234]) by smtp.gmail.com with ESMTPSA id u1sm10571584edv.90.2021.03.16.10.20.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Mar 2021 10:20:09 -0700 (PDT) From: Robert Foss To: robert.foss@linaro.org, todor.too@gmail.com, agross@kernel.org, bjorn.andersson@linaro.org, mchehab@kernel.org, robh+dt@kernel.org, angelogioacchino.delregno@somainline.org, linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, AngeloGioacchino Del Regno , Sakari Ailus , Andrey Konovalov , Hans Verkuil Cc: Rob Herring , Tomasz Figa , Azam Sadiq Pasha Kapatrala Syed , Sarvesh Sridutt , Laurent Pinchart , Jonathan Marek , Nicolas Boichat Subject: [PATCH v9 03/22] media: camss: Replace trace_printk() with dev_dbg() Date: Tue, 16 Mar 2021 18:19:12 +0100 Message-Id: <20210316171931.812748-4-robert.foss@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210316171931.812748-1-robert.foss@linaro.org> References: <20210316171931.812748-1-robert.foss@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org trace_printk() should not be used in production code, since extra memory is used for special buffers whenever trace_puts() is used. Replace it with dev_dbg() which provides all of the desired debugging functionality. Signed-off-by: Robert Foss Suggested-by: Nicolas Boichat Reviewed-by: Nicolas Boichat --- Changes since v3: - Nicolas: Create this patch Changes since v4: - Nicolas: Add r-b drivers/media/platform/qcom/camss/camss-vfe-4-1.c | 5 +++-- drivers/media/platform/qcom/camss/camss-vfe-4-7.c | 5 +++-- 2 files changed, 6 insertions(+), 4 deletions(-) -- 2.27.0 diff --git a/drivers/media/platform/qcom/camss/camss-vfe-4-1.c b/drivers/media/platform/qcom/camss/camss-vfe-4-1.c index a1b56b89130d..85b9bcbc7321 100644 --- a/drivers/media/platform/qcom/camss/camss-vfe-4-1.c +++ b/drivers/media/platform/qcom/camss/camss-vfe-4-1.c @@ -12,6 +12,7 @@ #include #include +#include "camss.h" #include "camss-vfe.h" #define VFE_0_HW_VERSION 0x000 @@ -936,8 +937,8 @@ static irqreturn_t vfe_isr(int irq, void *dev) vfe->ops->isr_read(vfe, &value0, &value1); - trace_printk("VFE: status0 = 0x%08x, status1 = 0x%08x\n", - value0, value1); + dev_dbg(vfe->camss->dev, "VFE: status0 = 0x%08x, status1 = 0x%08x\n", + value0, value1); if (value0 & VFE_0_IRQ_STATUS_0_RESET_ACK) vfe->isr_ops.reset_ack(vfe); diff --git a/drivers/media/platform/qcom/camss/camss-vfe-4-7.c b/drivers/media/platform/qcom/camss/camss-vfe-4-7.c index 84c33b8f9fe3..f7e00a2de393 100644 --- a/drivers/media/platform/qcom/camss/camss-vfe-4-7.c +++ b/drivers/media/platform/qcom/camss/camss-vfe-4-7.c @@ -12,6 +12,7 @@ #include #include +#include "camss.h" #include "camss-vfe.h" #define VFE_0_HW_VERSION 0x000 @@ -1069,8 +1070,8 @@ static irqreturn_t vfe_isr(int irq, void *dev) vfe->ops->isr_read(vfe, &value0, &value1); - trace_printk("VFE: status0 = 0x%08x, status1 = 0x%08x\n", - value0, value1); + dev_dbg(vfe->camss->dev, "VFE: status0 = 0x%08x, status1 = 0x%08x\n", + value0, value1); if (value0 & VFE_0_IRQ_STATUS_0_RESET_ACK) vfe->isr_ops.reset_ack(vfe);