From patchwork Wed Dec 2 09:41:37 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Manivannan Sadhasivam X-Patchwork-Id: 335950 Delivered-To: patch@linaro.org Received: by 2002:a17:906:4755:0:0:0:0 with SMTP id j21csp777806ejs; Wed, 2 Dec 2020 01:44:44 -0800 (PST) X-Google-Smtp-Source: ABdhPJzlW1A6Nb4O5r/DBiEpDf8bwYxANjhlqgXCpD+Bv+1y74CPdhN65tO4JTZOcXGJdnnKDqXz X-Received: by 2002:aa7:d54a:: with SMTP id u10mr1755322edr.168.1606902284416; Wed, 02 Dec 2020 01:44:44 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1606902284; cv=none; d=google.com; s=arc-20160816; b=GBRZ0ZJ5KHME0sZEb1VVA56pwX7lu6LIUAoU6pi7fbRmNlVoqkundBj31oeY3sZNMB QBBGjF+2HJWD4VvzgxgWmFetpgrU3ZNiinrqxYehTfoVJEjuTAvYzCywHBn51BIoZeZq qys6gSFoU2cwmweguLp7pKO42mOUvOz0XuH7md87Pu74gtQvBcbtcHcm/OwTUHTQfo+n ky/iOmkePO7s9Qx4zlp8J1Zp4J1YISoZQqNF/EF3lLV14UZy67L8L9Rd4dYN3o2eNAvT PiMrStFi0Gh7KhzTUuMWBkarvSo0ZtpUPbITmOwebzO1+FSSosXJGdJ7jeDrl/xrh4Uz alRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=DLEpetMqROUc2OOQ0fVepK2+3FOFzdcD46Lm023xCZ4=; b=YEhEZpQUrsKyZX6xso3hN3L3AjdGxZaPgzw5iUvrZ0+AVR9Vw2u/LuAviXEGvHiX9N FDioLOYYyBuCjHDqFSHFPy49utHnsa+zXkWCCXb3hchJblkJnyhzcxS8fpyKLA+vOmhs V++IMIqNpbpF6L89xlA72zLiNUJrh+7skGsTQ5OkJuGt/naB/sWNdjaffC3Bwbtenupc gCmlD/H3UJ0xNBeMbPSpXx7ohaXWsOIydstW42frJ+8b6xL9NSy7t+b7jVJFW5Ubn1lO C6JDewRP5f59mk+so+oWxyl7pSQNVIEIaRT9ZlXWEyZHWiPwPPUR7EW8F8+4JBU/sq9L 3AEw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=sU60JdKX; spf=pass (google.com: domain of linux-arm-msm-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-arm-msm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id do13si531726ejc.286.2020.12.02.01.44.44; Wed, 02 Dec 2020 01:44:44 -0800 (PST) Received-SPF: pass (google.com: domain of linux-arm-msm-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=sU60JdKX; spf=pass (google.com: domain of linux-arm-msm-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-arm-msm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388300AbgLBJn4 (ORCPT + 15 others); Wed, 2 Dec 2020 04:43:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54938 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388274AbgLBJny (ORCPT ); Wed, 2 Dec 2020 04:43:54 -0500 Received: from mail-pf1-x443.google.com (mail-pf1-x443.google.com [IPv6:2607:f8b0:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D342FC061A4F for ; Wed, 2 Dec 2020 01:42:54 -0800 (PST) Received: by mail-pf1-x443.google.com with SMTP id b10so893959pfo.4 for ; Wed, 02 Dec 2020 01:42:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=DLEpetMqROUc2OOQ0fVepK2+3FOFzdcD46Lm023xCZ4=; b=sU60JdKX1bMF/Sz7d8IzSVSDvOXsbOvwUI2moEbOr32zMImmIXisPR4ivQlpmM7GBD 8vU1N9taSa/VTd1x+vqPqF5yJ6oGdyP3GjJR8VNb5fncOJw3lqXP0LEsSN3Q4oYTen08 dUbgpk7gZuqw9j6ZLhcVGRUT2vwJIkRgR01Qcx4yhPc6xiIT/+hPfNfTYPchU9r4Y2E+ UP/6nNpdVg8yEy5zSUEwbuxuLZ5gTrxBE9pWgOaSiP+fXxcGewfU0N+dPTAOw06E2kf/ YKLPbK1jgLsfu9DbvxhXgf+J73zF3NMf/BGAk8IDgjaSwn72crV72GvqnVYcYkOnBNT0 584Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=DLEpetMqROUc2OOQ0fVepK2+3FOFzdcD46Lm023xCZ4=; b=t8t3IyoMst77RD8suQgAAdMQKaV/ETyYc9W1drLaxMC/v5kCBbvUNj6Zn80DM7QAzx Yu5q6XKBEHSyezbZV3fg07XGIMoprjQ5stNh8drLeGMxDf/J9/ejSKtT/3Mmk4isCb57 DIupO7hcgl5nWOVR86PbabT1+KptqwR7rxhG36xxs0xoxIHMxO6HXnYoMG9WDib/wtQs ugthpl8hIWuWOqJYa3aE8AvKV48sqh/kcXFIbvSTwO+a6yCGc31uNzkO+fQKhwMwcnmg fmOfMH6IFyxxhaNVdJ+tPgg24XTxeXNr9P2grO5Ab7E/EB703mHALlgTEECMnkI2AxKw k2HA== X-Gm-Message-State: AOAM530ZTMmlYDjga3lIXU2ilXEFdNqlzCkx9Xh98wuMN0aq8BRv/OKf GV00KyILbPe8iCjoAo7mOnxq X-Received: by 2002:a63:c54e:: with SMTP id g14mr1900811pgd.398.1606902174395; Wed, 02 Dec 2020 01:42:54 -0800 (PST) Received: from localhost.localdomain ([103.59.133.81]) by smtp.gmail.com with ESMTPSA id bg8sm1393990pjb.52.2020.12.02.01.42.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Dec 2020 01:42:53 -0800 (PST) From: Manivannan Sadhasivam To: gregkh@linuxfoundation.org Cc: hemantk@codeaurora.org, bbhatt@codeaurora.org, linux-arm-msm@vger.kernel.org, jhugo@codeaurora.org, linux-kernel@vger.kernel.org, loic.poulain@linaro.org, kernel test robot , Manivannan Sadhasivam Subject: [PATCH 07/29] bus: mhi: core: Remove unnecessary counter from mhi_firmware_copy() Date: Wed, 2 Dec 2020 15:11:37 +0530 Message-Id: <20201202094159.107075-8-manivannan.sadhasivam@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201202094159.107075-1-manivannan.sadhasivam@linaro.org> References: <20201202094159.107075-1-manivannan.sadhasivam@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org From: Bhaumik Bhatt There is an extra 'i' counter in the mhi_firmware_copy() function which is unused. Remove it to clean-up code and reduce stack space as well as improve efficiency of the function. Fixes: cd457afb1667 ("bus: mhi: core: Add support for downloading firmware over BHIe") Reported-by: kernel test robot Signed-off-by: Bhaumik Bhatt Reviewed-by: Manivannan Sadhasivam Signed-off-by: Manivannan Sadhasivam --- drivers/bus/mhi/core/boot.c | 2 -- 1 file changed, 2 deletions(-) -- 2.25.1 diff --git a/drivers/bus/mhi/core/boot.c b/drivers/bus/mhi/core/boot.c index 24422f5c3d80..6b6fd9668c3b 100644 --- a/drivers/bus/mhi/core/boot.c +++ b/drivers/bus/mhi/core/boot.c @@ -365,7 +365,6 @@ static void mhi_firmware_copy(struct mhi_controller *mhi_cntrl, size_t remainder = firmware->size; size_t to_cpy; const u8 *buf = firmware->data; - int i = 0; struct mhi_buf *mhi_buf = img_info->mhi_buf; struct bhi_vec_entry *bhi_vec = img_info->bhi_vec; @@ -377,7 +376,6 @@ static void mhi_firmware_copy(struct mhi_controller *mhi_cntrl, buf += to_cpy; remainder -= to_cpy; - i++; bhi_vec++; mhi_buf++; }