diff mbox series

[v2,5/9] iio: adc: qcom-spmi-adc5: fix driver name

Message ID 20200903132109.1914011-6-dmitry.baryshkov@linaro.org
State New
Headers show
Series qcom: pm8150: add support for thermal monitoring | expand

Commit Message

Dmitry Baryshkov Sept. 3, 2020, 1:21 p.m. UTC
Remove superfluous '.c' from qcom-spmi-adc5 device driver name.

Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>

---
 drivers/iio/adc/qcom-spmi-adc5.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.28.0

Comments

Manivannan Sadhasivam Sept. 4, 2020, 11:14 a.m. UTC | #1
On 0903, Dmitry Baryshkov wrote:
> Remove superfluous '.c' from qcom-spmi-adc5 device driver name.
> 
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>

Please add Fixes tag, with that:

Acked-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>

Thanks,
Mani

> ---
>  drivers/iio/adc/qcom-spmi-adc5.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/adc/qcom-spmi-adc5.c b/drivers/iio/adc/qcom-spmi-adc5.c
> index 30b8867b31e4..c2da8f068b87 100644
> --- a/drivers/iio/adc/qcom-spmi-adc5.c
> +++ b/drivers/iio/adc/qcom-spmi-adc5.c
> @@ -919,7 +919,7 @@ static int adc5_probe(struct platform_device *pdev)
>  
>  static struct platform_driver adc5_driver = {
>  	.driver = {
> -		.name = "qcom-spmi-adc5.c",
> +		.name = "qcom-spmi-adc5",
>  		.of_match_table = adc5_match_table,
>  	},
>  	.probe = adc5_probe,
> -- 
> 2.28.0
>
Jonathan Cameron Sept. 6, 2020, 2:24 p.m. UTC | #2
On Fri, 4 Sep 2020 16:44:02 +0530
Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> wrote:

> On 0903, Dmitry Baryshkov wrote:
> > Remove superfluous '.c' from qcom-spmi-adc5 device driver name.
> > 
> > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>  
> 
> Please add Fixes tag, with that:
> 
> Acked-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Ouch.  Technically this is ABI change, but given I'd hope anyone using
the name would have noticed the .c was odd and shouting about it I guess
no one is using it.

Could you pull this to the front of v3 (with fixes tag) so I can pick it up
for stable without having to deal with fuzz etc.

Thanks,

Jonathan

> 
> Thanks,
> Mani
> 
> > ---
> >  drivers/iio/adc/qcom-spmi-adc5.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/iio/adc/qcom-spmi-adc5.c b/drivers/iio/adc/qcom-spmi-adc5.c
> > index 30b8867b31e4..c2da8f068b87 100644
> > --- a/drivers/iio/adc/qcom-spmi-adc5.c
> > +++ b/drivers/iio/adc/qcom-spmi-adc5.c
> > @@ -919,7 +919,7 @@ static int adc5_probe(struct platform_device *pdev)
> >  
> >  static struct platform_driver adc5_driver = {
> >  	.driver = {
> > -		.name = "qcom-spmi-adc5.c",
> > +		.name = "qcom-spmi-adc5",
> >  		.of_match_table = adc5_match_table,
> >  	},
> >  	.probe = adc5_probe,
> > -- 
> > 2.28.0
> >
diff mbox series

Patch

diff --git a/drivers/iio/adc/qcom-spmi-adc5.c b/drivers/iio/adc/qcom-spmi-adc5.c
index 30b8867b31e4..c2da8f068b87 100644
--- a/drivers/iio/adc/qcom-spmi-adc5.c
+++ b/drivers/iio/adc/qcom-spmi-adc5.c
@@ -919,7 +919,7 @@  static int adc5_probe(struct platform_device *pdev)
 
 static struct platform_driver adc5_driver = {
 	.driver = {
-		.name = "qcom-spmi-adc5.c",
+		.name = "qcom-spmi-adc5",
 		.of_match_table = adc5_match_table,
 	},
 	.probe = adc5_probe,