From patchwork Thu Dec 19 15:04:32 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vinod Koul X-Patchwork-Id: 182121 Delivered-To: patch@linaro.org Received: by 2002:a92:d0a:0:0:0:0:0 with SMTP id 10csp599292iln; Thu, 19 Dec 2019 07:05:29 -0800 (PST) X-Google-Smtp-Source: APXvYqy7G9oNUBfu3BvKHd7sfY/htcyXGg+zT826N6EbeQwPIb2ia75RaGgJw1Sj/F2ckVnMG1I+ X-Received: by 2002:a9d:369:: with SMTP id 96mr4805764otv.228.1576767929149; Thu, 19 Dec 2019 07:05:29 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1576767929; cv=none; d=google.com; s=arc-20160816; b=om3n30aupOKwEIe2x56a6m+BhEWL86a93r9Lrm27U7RI/YW07L246ECvRi46epGjDA xGvQkuP0DTOskCD7sOvkR6kj3ytmg5vBFOAEeVFYZzBMMhAN9CR9DOBhQZ+9EIYyXn+0 WK/e50z5YU4TsomNTgjbvItlqg7puKNefV4HOK7QW5HW+5y2oq5Q4Nz5aWLRTPbre0VU CFoyxYDklkO1BjAVVFu5lFUtxEr5UWRP6Qa6QSKM9W3EZgVIEXlLcd30km/VoXrVA0Vz 698QkjeFGLLkDGd3uX57ee5xtDjqUatJ6QS0KkDBa9l6OabUrrzZPsIZJtgG3Z2Xhb3W diHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=sY5LgWL6tR/sTobqa9Jw1QbScUZLKeZrYgIyOt0uIt0=; b=iZWbCaU7KBHmo4XREQ96EJdCiu8XigHDHTLFer2CsS8D6PMgSEoxUdWUgEzl0qtT5H oNiuSYb17/Ti6OXGkAEufUTyQ9ONwa8q3go4DST/d0HkevPV9fuAYYBUITF79SdqQ9+J emUv3hjJI35HWvjj8XULZDAMgbuLHPmzWjvFXtkjRMQBAO2+sgv16HMEBdLVmvfThVkC q+EO/9Gn/S0eAgo33lAaoc3z8sj3HbrdoM7/ftTAQzMs4eES9AUSCU8NCdqgrO65ogFV SE4le6YodajBRk3w1rz70WQ8uReQ4TcO8VO5sJZFKyuaQiMLIh+h5PTDUK9j32fgT0HN Ta+g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=NYgNPf78; spf=pass (google.com: best guess record for domain of linux-arm-msm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-arm-msm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m24si3463420otn.67.2019.12.19.07.05.26; Thu, 19 Dec 2019 07:05:29 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-arm-msm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=NYgNPf78; spf=pass (google.com: best guess record for domain of linux-arm-msm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-arm-msm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726930AbfLSPFG (ORCPT + 15 others); Thu, 19 Dec 2019 10:05:06 -0500 Received: from mail.kernel.org ([198.145.29.99]:34314 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726801AbfLSPFG (ORCPT ); Thu, 19 Dec 2019 10:05:06 -0500 Received: from localhost.localdomain (unknown [122.178.234.230]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B1D8221655; Thu, 19 Dec 2019 15:05:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576767905; bh=2vFU+S6HKqKhfz4jubJ0RuqI/YrwcWJmmCmTPInyZtw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=NYgNPf78Ks2olSLVdWXX45DQN+xgYZmkM4W7388mGgelnnhI4LdEBenVPTxkPpk/2 UEcAZTgAdfHMGHbTE9jdbwVmn9cE7bEXtNY1qqaM/QiN/2oEVkqjsGyXthHzzYLK2A f5vfJLWD/WFsYwnwiLKOE4NjGn04YwInN4WG7KiY= From: Vinod Koul To: Kishon Vijay Abraham I Cc: linux-arm-msm@vger.kernel.org, Bjorn Andersson , Vinod Koul , Andy Gross , Can Guo , Jeffrey Hugo , linux-kernel@vger.kernel.org Subject: [PATCH 3/4] phy: qcom-qmp: Add optional SW reset Date: Thu, 19 Dec 2019 20:34:32 +0530 Message-Id: <20191219150433.2785427-4-vkoul@kernel.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191219150433.2785427-1-vkoul@kernel.org> References: <20191219150433.2785427-1-vkoul@kernel.org> MIME-Version: 1.0 Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org For V4 QMP UFS Phy, we need to assert reset bits, configure the phy and then deassert it, so add optional has_sw_reset flag and use that to configure the QPHY_SW_RESET register. Signed-off-by: Vinod Koul --- drivers/phy/qualcomm/phy-qcom-qmp.c | 10 ++++++++++ 1 file changed, 10 insertions(+) -- 2.23.0 Reviewed-by: Jeffrey Hugo diff --git a/drivers/phy/qualcomm/phy-qcom-qmp.c b/drivers/phy/qualcomm/phy-qcom-qmp.c index 06f971ca518e..80304b7cd895 100644 --- a/drivers/phy/qualcomm/phy-qcom-qmp.c +++ b/drivers/phy/qualcomm/phy-qcom-qmp.c @@ -1023,6 +1023,9 @@ struct qmp_phy_cfg { /* true, if PCS block has no separate SW_RESET register */ bool no_pcs_sw_reset; + + /* true if sw reset needs to be invoked */ + bool has_sw_reset; }; /** @@ -1391,6 +1394,7 @@ static const struct qmp_phy_cfg sm8150_ufsphy_cfg = { .is_dual_lane_phy = true, .no_pcs_sw_reset = true, + .has_sw_reset = true, }; static void qcom_qmp_phy_configure(void __iomem *base, @@ -1475,6 +1479,9 @@ static int qcom_qmp_phy_com_init(struct qmp_phy *qphy) SW_USB3PHY_RESET_MUX | SW_USB3PHY_RESET); } + if (cfg->has_sw_reset) + qphy_setbits(serdes, cfg->regs[QPHY_SW_RESET], SW_RESET); + if (cfg->has_phy_com_ctrl) qphy_setbits(serdes, cfg->regs[QPHY_COM_POWER_DOWN_CONTROL], SW_PWRDN); @@ -1651,6 +1658,9 @@ static int qcom_qmp_phy_enable(struct phy *phy) if (cfg->has_phy_dp_com_ctrl) qphy_clrbits(dp_com, QPHY_V3_DP_COM_SW_RESET, SW_RESET); + if (cfg->has_sw_reset) + qphy_clrbits(pcs, cfg->regs[QPHY_SW_RESET], SW_RESET); + /* start SerDes and Phy-Coding-Sublayer */ qphy_setbits(pcs, cfg->regs[QPHY_START_CTRL], cfg->start_ctrl);