From patchwork Wed Nov 13 23:35:58 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bjorn Andersson X-Patchwork-Id: 179360 Delivered-To: patch@linaro.org Received: by 2002:a92:38d5:0:0:0:0:0 with SMTP id g82csp10286200ilf; Wed, 13 Nov 2019 15:36:04 -0800 (PST) X-Google-Smtp-Source: APXvYqwj7ZIBraXkhI3I8WVPJ51XRedgOWT/6FW4NpXWoVeiOJriMuQj0QDSsYc3/eeFrWrtl2B/ X-Received: by 2002:aa7:d6d1:: with SMTP id x17mr6785648edr.158.1573688164569; Wed, 13 Nov 2019 15:36:04 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1573688164; cv=none; d=google.com; s=arc-20160816; b=eUPxGCRAZcciTtdFGISywRY40Hoy0gmjzLPEpZ3qR69HGm3/nMvzrPwQpL0vCob2va fDuPd5ZQh2jVs5mM3gD4jCGzzW0Q6mBFxQ6IE5no4ryQZPIVo7uk/yTZjfw0aeX9B1Hw oDpfrw4bsiDHSrvX8UB1AkihTYTfBZTG2SuKD0Zv0v+scAFY9Tih9rK5nOjOUYQezck4 YbinCSeTTgPVankF3UGhzdCOw1BGAfQ+nHT/iNpXAeatRmvc9FBG79tzguI6+EiJX/Lu le4zg7vyZv0caUvYf96BNv4fwI4fazjv79224mHqWANM2JiAZIFkvFKsgWVNwyxGUDgv Fhdg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=SjmhxW54SXkSEjAKtCETMQbt3jTR5yZxCqORBZRYl58=; b=IWnWG/3btbQL2tQOus3f3ZntP9gPZukTkgXa5Wh3s6EA+02Cz1riPP5zFL/XSCNOt0 j5E+z0+0xWkwxGSGoLrM2YMlJfgd5UGQ4nPMz9JPd0AG+Kis/d83ueX6GTRyljPySJHE HGh+grAnoJFMs9POpXYbWtHwOQqqbWabx/aD9whUP4Om3Lc/mM7/Fewjf9UPFVR2Q8ei s3Gj70a50h0iggNZEwKr70wmz9UyZ+Se1e5Dcu5GPLqpl7CKO4R5Rccp+vaeXBmI7ya0 cTbK9Rw4sJkENTbZNm21M1b1xsIj2tpGSngT7P43/IZM1/DoDs5FHBwh8L4f3N4/EQiO Hs0A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=UYHYWaYY; spf=pass (google.com: best guess record for domain of linux-arm-msm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-arm-msm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u5si2179134ejx.286.2019.11.13.15.36.04; Wed, 13 Nov 2019 15:36:04 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-arm-msm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=UYHYWaYY; spf=pass (google.com: best guess record for domain of linux-arm-msm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-arm-msm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726422AbfKMXgD (ORCPT + 15 others); Wed, 13 Nov 2019 18:36:03 -0500 Received: from mail-pf1-f193.google.com ([209.85.210.193]:35581 "EHLO mail-pf1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726303AbfKMXgD (ORCPT ); Wed, 13 Nov 2019 18:36:03 -0500 Received: by mail-pf1-f193.google.com with SMTP id q13so2753906pff.2 for ; Wed, 13 Nov 2019 15:36:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=SjmhxW54SXkSEjAKtCETMQbt3jTR5yZxCqORBZRYl58=; b=UYHYWaYYM781SsQdehbJpzWjlTZmQAIGfEsd5+W03I1MfDcbb+sfyDvqsXdbEIJnD/ VeX0GVTgrjC/zFLMI9MKbhZmJFhBTj5owbuGxRzMRJGL+EDTPcud/hGhzCG0fQXR9z0y ZVZBuaYIAnn4lTJYx4KcQ0mPRfIOjmYRvElsfqVJQol+GC5yiyGfGn9j9dGdVRISKxmD dLOuZuTrtwISDD3egQH3LrKeKD3mJndVfjhSunIcGroSQDvVOVL1pxfV+3CboksyLw6v MOxNXnaoEsbIdnFE3y8/gqEZRfS+pr6IL2n9uxDjuGsY0e0cPXyA79uQk0BEXoIsDlaK fxKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=SjmhxW54SXkSEjAKtCETMQbt3jTR5yZxCqORBZRYl58=; b=Vl5FHPGMYrfmi1NvsfFKz0+efA779hnPLmxphO5THeBz2pI1ukiSLvA34nNm+ttTCl HqRDXeIsSpyqU5tT4t8fmxKqdH3msivDPtj9c9X7HRsk5PGI9692hMgx3IV7h3Drq4OJ DK0yaXzOfKqi3YL16hbPZJhda/VM4VvXOOxqYwss3IGgfL339T8zgFnEOb0tccA/Fgwg ZN4tMqT62CLGYdo3uH+oLV6kZOwTORrnTU+6QxN957vBhzgabtNAxDvDgOPO+NQFmu/o QCanG6STuA15MYG83ES4EBjn3ozAxwXtXQTlkyuFl3Z/nAbcJGJi5tU9H0isbd6c6F2g BRTA== X-Gm-Message-State: APjAAAW6hNyHZjv3+EN6ucm34bMG9etWiQ8eqS/a6Xo6JMdZcJKZOmfc evBQO3khxC/H0Cw78+ttGESxbg== X-Received: by 2002:a63:731a:: with SMTP id o26mr6696115pgc.108.1573688162549; Wed, 13 Nov 2019 15:36:02 -0800 (PST) Received: from localhost.localdomain (104-188-17-28.lightspeed.sndgca.sbcglobal.net. [104.188.17.28]) by smtp.gmail.com with ESMTPSA id v10sm3526345pgr.37.2019.11.13.15.36.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Nov 2019 15:36:01 -0800 (PST) From: Bjorn Andersson To: Kalle Valo , "David S. Miller" Cc: ath10k@lists.infradead.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, govinds@codeaurora.org Subject: [PATCH] ath10k: qmi: Sleep for a while before assigning MSA memory Date: Wed, 13 Nov 2019 15:35:58 -0800 Message-Id: <20191113233558.4040259-1-bjorn.andersson@linaro.org> X-Mailer: git-send-email 2.23.0 MIME-Version: 1.0 Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Unless we sleep for a while before transitioning the MSA memory to WLAN the MPSS.AT.4.0.c2-01184-SDM845_GEN_PACK-1 firmware triggers a security violation fairly reliably. Unforutnately recovering from this failure always results in the entire system freezing. Signed-off-by: Bjorn Andersson --- drivers/net/wireless/ath/ath10k/qmi.c | 7 +++++++ 1 file changed, 7 insertions(+) -- 2.23.0 diff --git a/drivers/net/wireless/ath/ath10k/qmi.c b/drivers/net/wireless/ath/ath10k/qmi.c index 637f83ef65f8..a0ba07b85362 100644 --- a/drivers/net/wireless/ath/ath10k/qmi.c +++ b/drivers/net/wireless/ath/ath10k/qmi.c @@ -773,6 +773,13 @@ static void ath10k_qmi_event_server_arrive(struct ath10k_qmi *qmi) if (ret) return; + /* + * HACK: sleep for a while inbetween receiving the msa info response + * and the XPU update to prevent SDM845 from crashing due to a security + * violation, when running MPSS.AT.4.0.c2-01184-SDM845_GEN_PACK-1. + */ + msleep(20); + ret = ath10k_qmi_setup_msa_permissions(qmi); if (ret) return;