From patchwork Fri Jul 26 11:27:46 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Anders Roxell X-Patchwork-Id: 169816 Delivered-To: patch@linaro.org Received: by 2002:a92:4782:0:0:0:0:0 with SMTP id e2csp12909039ilk; Fri, 26 Jul 2019 04:27:54 -0700 (PDT) X-Google-Smtp-Source: APXvYqym18PQjkRb/0WwMF1wuVC10caXUYDzlZnbeU2X9mGM6GAgxfFo/qCpRjTlQiO9g4oc9JXP X-Received: by 2002:a63:7a01:: with SMTP id v1mr92979289pgc.310.1564140473972; Fri, 26 Jul 2019 04:27:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1564140473; cv=none; d=google.com; s=arc-20160816; b=efaBD8YwuDClub5WoDtGgtbCPFeWfjYnpbWpPwCWBcvhXhfEStzGnaCfPi0N/ejp0k V0us+7hb2tZoU9D0Dnrh0dk21wINjcIeOPfIzv2Ik6SS45Qre7O37vH/FcMGMf12z+xa tIXnSY3honIJGSE8FbnE9Ka+grbE6PZIabWJh9u92EKuQDJCkXf/95b6h/n8pmzAkmaI n2PMt3LQFRF2+z6dL7Kqu9prei9AebH7nRvrCNhI/iOygsKae6wkPHjixVP+Y2x5Zr2K Fs5VQuGoQmlDrqXmA2jy9oFoS9Lx1wsgpAycbsynXv1mg8y7LzyYKxQdNwRyK8rgh3Ri vZ+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=dQH4GnL/y7NNHvqjapmVG2NpS/ejAHj8nLLRQ4EYloU=; b=MTwEMnS+iF43C49DvqpEJDFm+NyGgCbbnoLcmAgNx4PZGo2KTCGB83Dc6xHJ7zbqvm NUPr87tZZ8nJ7c+XE8Hhn16LWzfnQf+zLWPMxTy0AJhbzpAvTdkx6M49T1XzDkeFgteK K8azx3fJEzqElMXcnwthZtFEaEgVitvmSAvDynI5xr+zojMBb1V1p/YcOjZoOXyR7xwc 6EC1q8IcpU/m7F65l3qMXp1970S1LhP5cOdK9gOyhCv9rZM8Olgz3GyQlmZniMaeqiPi FuQsxZ8XoI5SiIzOZOaJ3R8QPW2vvDY3MN1Wq0ySbjx2vBsuaKRsCvFKTooPF6dh+xAq WsjQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="MeM/PtQC"; spf=pass (google.com: best guess record for domain of linux-arm-msm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-arm-msm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c35si10444818pgm.51.2019.07.26.04.27.53; Fri, 26 Jul 2019 04:27:53 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-arm-msm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="MeM/PtQC"; spf=pass (google.com: best guess record for domain of linux-arm-msm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-arm-msm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726329AbfGZL1x (ORCPT + 15 others); Fri, 26 Jul 2019 07:27:53 -0400 Received: from mail-lf1-f67.google.com ([209.85.167.67]:43570 "EHLO mail-lf1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726302AbfGZL1x (ORCPT ); Fri, 26 Jul 2019 07:27:53 -0400 Received: by mail-lf1-f67.google.com with SMTP id c19so36843688lfm.10 for ; Fri, 26 Jul 2019 04:27:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=dQH4GnL/y7NNHvqjapmVG2NpS/ejAHj8nLLRQ4EYloU=; b=MeM/PtQCEY3Pof5+eaMTAWxOiKj2b/a9tQSd91Y3IuzC6dgUIHxOagN/qoHqAHA2rs Jkr2mriESm2QVd3Bx/UMF4Qut41yjn7Vn3M4jDMaSnxQlZOfx+P0EOR0E5piucx7sbw+ AGAtaFLkRXdpa4uKjDiXEQZZtdqBMD1XnDbZfF4aflyRQsHFJ/lNAq0WE5+jKUY7Iuyi xKzL5883lT5fmNnJkIpB+OrR1rJg/xzD+lJGlw62fRf5G2FpiEQxZyzt7sj7IQg87xDp X8YA9i+Gmtmy87qydkMAz5VMETa5mpEiMWaKMBmoHYggHLm8A92JgRnRNdCTkyGqAsH0 9DRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=dQH4GnL/y7NNHvqjapmVG2NpS/ejAHj8nLLRQ4EYloU=; b=MTmYcF6cLeDe+6K6rohthuKqq1qyF+ungNqOJ8E+7ro1U7/I0DreLw99oL/3tmb5iL 7X8n9weHAy0CKv8DU4ftn6MedpCfbpXndM8MDVprYNSBi4Pr1x8UgFStFTP3OHFJokwU sF4p//UZ0CRfp8/m1gc2hbpav868XXOPjzQteQkr3K4N5vRth0vV109bn+yTzmh1wTwb eHkvccJODMlAO8DiBcOvdtWIMv9XREfS1Y3MWGxBEarLMVDNwGm8163CKazuXxri3blI VlgmFK5LEdxZuUvg9c4cCDDKtc2fC+dbErcMNlj0+Ru4IbqiQl5YSAKJoKT3zj4CK0wM 030A== X-Gm-Message-State: APjAAAX0bZA1/ASfK0Mn7lGxzoQqYtD/5iNj0DR3XLztXf4TIf9mzkgS cdM/ecXt6pwJ2F4jlWvEvJyPmw== X-Received: by 2002:ac2:59c9:: with SMTP id x9mr41706584lfn.52.1564140470939; Fri, 26 Jul 2019 04:27:50 -0700 (PDT) Received: from localhost (c-243c70d5.07-21-73746f28.bbcust.telenor.se. [213.112.60.36]) by smtp.gmail.com with ESMTPSA id m17sm8218208lfj.22.2019.07.26.04.27.49 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Fri, 26 Jul 2019 04:27:50 -0700 (PDT) From: Anders Roxell To: robdclark@gmail.com, sean@poorly.run, airlied@linux.ie, daniel@ffwll.ch Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Anders Roxell Subject: [PATCH 1/3] drm: msm: a6xx: Mark expected switch fall-through Date: Fri, 26 Jul 2019 13:27:46 +0200 Message-Id: <20190726112746.19410-1-anders.roxell@linaro.org> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org When fall-through warnings was enabled by default the following warning was starting to show up: ../drivers/gpu/drm/msm/adreno/a6xx_gpu.c: In function ‘a6xx_submit’: ../drivers/gpu/drm/msm/adreno/a6xx_gpu.c:116:7: warning: this statement may fall through [-Wimplicit-fallthrough=] if (priv->lastctx == ctx) ^ ../drivers/gpu/drm/msm/adreno/a6xx_gpu.c:118:3: note: here case MSM_SUBMIT_CMD_BUF: ^~~~ Rework so that the compiler doesn't warn about fall-through. Fixes: d93512ef0f0e ("Makefile: Globally enable fall-through warning") Signed-off-by: Anders Roxell --- drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 1 + 1 file changed, 1 insertion(+) -- 2.20.1 diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c index be39cf01e51e..644a6ee53f05 100644 --- a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c +++ b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c @@ -115,6 +115,7 @@ static void a6xx_submit(struct msm_gpu *gpu, struct msm_gem_submit *submit, case MSM_SUBMIT_CMD_CTX_RESTORE_BUF: if (priv->lastctx == ctx) break; + /* Fall through */ case MSM_SUBMIT_CMD_BUF: OUT_PKT7(ring, CP_INDIRECT_BUFFER_PFE, 3); OUT_RING(ring, lower_32_bits(submit->cmd[i].iova));