From patchwork Sun Sep 16 23:45:44 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Srinivas Kandagatla X-Patchwork-Id: 146801 Delivered-To: patch@linaro.org Received: by 2002:a2e:1648:0:0:0:0:0 with SMTP id 8-v6csp3154604ljw; Sun, 16 Sep 2018 16:46:10 -0700 (PDT) X-Google-Smtp-Source: ANB0VdbTQGEkBLsT9h31ysXnYqN39j7NnrZzI1Xj4deF4ZThDLsAmz59k4+pPLrSx/k3d3wB/SOT X-Received: by 2002:a65:5286:: with SMTP id y6-v6mr20216572pgp.65.1537141570031; Sun, 16 Sep 2018 16:46:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1537141570; cv=none; d=google.com; s=arc-20160816; b=M5tta3J5tcBMY7jho5uL3eLj3Uiemp5Q0hrWh13wv8mTNA/mdFs+eCD8Uap1wzEg8p hyhc0NHkcl8gBVZxhty+MwC5h1Pxe5hsyJsgW9jgXp3L3QJ8JTrEUc7ZYRnOYlqtrMOv nxzYCDWthHu6o1ZFpIm5TC7/doDzPIOhEuswrL6OAkd4wU0cK2jljPlJBJ+zum3SjMWG /iYzVUrrV7aH7xZ++RTkHqve/Ze7uDiyTOtx7l4Zh2hmMVorRlgNKyoDvtPUO+ucY/A2 kxFhXZf/Yl46s4qwWZv/Y47OIoHU6C8i0QlBsRJjDZW7d0gi5yOg2s0xcuxy4ti7WmUk ihkg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature; bh=4mLIm+CPnzkl6UQkh/tstY1IOawXp7bQelRcUAvyv2I=; b=Jbum1b1ometTwv9OHSoLpuYzTG/5QHJIWgwmVdthiLhUlKAABX1fN9ri+JK0Tj1KlY UoSwL+oPROoYTQXrgO4cFADZvHIkQgo3tOpQbvkZ5Cs1EbbFqM3EFADNu4GTm30kSI8u PbJLiTL9IpE1RuDZCIOocv2YGV4sIDGY5io0+TIHYYD7BGhC+cRKwJw871jfCVlB7dJk 1iKEe6a/QVh47YEvKfjoA9MaZZA4pIwmFXW+CH9vVNQobVq1yJF+HuQVwJ3Imato/x0b GYZGNnRalHRGPEp0VF6XPyr+apjiOuog3r+dqpewSrKLecI03uGmYsmyfh+Kpk4MR1FU CwRw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ViIImC8M; spf=pass (google.com: best guess record for domain of linux-arm-msm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-arm-msm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f4-v6si13808546plt.346.2018.09.16.16.46.09; Sun, 16 Sep 2018 16:46:10 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-arm-msm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ViIImC8M; spf=pass (google.com: best guess record for domain of linux-arm-msm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-arm-msm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726889AbeIQFKo (ORCPT + 13 others); Mon, 17 Sep 2018 01:10:44 -0400 Received: from mail-io1-f67.google.com ([209.85.166.67]:36058 "EHLO mail-io1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728311AbeIQFKn (ORCPT ); Mon, 17 Sep 2018 01:10:43 -0400 Received: by mail-io1-f67.google.com with SMTP id q5-v6so10058869iop.3 for ; Sun, 16 Sep 2018 16:46:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=4mLIm+CPnzkl6UQkh/tstY1IOawXp7bQelRcUAvyv2I=; b=ViIImC8M62l8kYkhVQwEsX4r/wgwu8DdANBxBs04jgwnNbnAkbTwz5mpfspMX9wsJ8 Hv6XZri5hqvK8P7Sdo41iFU3IGqrJpukxmRxMXX4uvpexOLSUw5udG1JmfRNMKpJpw4y E8MKKrrmfGScUPrB99QUPsbefI8C/1Kbs8GWQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=4mLIm+CPnzkl6UQkh/tstY1IOawXp7bQelRcUAvyv2I=; b=kaZDNFyycqvkba+NgzMW5NwHD4zFAKWwRbnJhCd6U1nMkSKYeW/7yNey9IORfCcQB5 6mL/LsZUXywXiUtfekSVFR02uBnHrlLa1MJ5DbAwkVAA4IfkRIqIin+0gNrXtseItgMy AMXjjldeZ8CsmtYsu1ELNkPYv/zPLfJ2q9M1YUTcgWHelCh5eLqtDmKLxxvQ2CzDde4r 39dNn9JAfy/DDFjQ0SSlUlZpOMsMIm1hTbetNw278P9Yt+2JapZqsNk070s/nYrBfyKT 08QQ0G+uQM+JJ2d+laIS7dqKGkqBSosUDhd07HQz79l8u/xuwwfNiJN6oMymCDmIQYXo 3Udg== X-Gm-Message-State: APzg51BJrKyZodehc9xrjIxzG5PEymZLG9PO5V6be2LBYPDlZXXsnUmT qfHz97LCmikKhMMNuLaFmqJqzw== X-Received: by 2002:a6b:be83:: with SMTP id o125-v6mr18643055iof.173.1537141562485; Sun, 16 Sep 2018 16:46:02 -0700 (PDT) Received: from localhost.localdomain ([209.82.80.116]) by smtp.gmail.com with ESMTPSA id a11-v6sm4495177ioc.63.2018.09.16.16.46.01 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 16 Sep 2018 16:46:02 -0700 (PDT) From: srinivas.kandagatla@linaro.org To: gregkh@linuxfoundation.org Cc: broonie@kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, alsa-devel@alsa-project.org, vkoul@kernel.org, Srinivas Kandagatla Subject: [PATCH 5/7] silmbus: ngd: register controller after power up. Date: Sun, 16 Sep 2018 16:45:44 -0700 Message-Id: <20180916234546.29661-6-srinivas.kandagatla@linaro.org> X-Mailer: git-send-email 2.9.3 In-Reply-To: <20180916234546.29661-1-srinivas.kandagatla@linaro.org> References: <20180916234546.29661-1-srinivas.kandagatla@linaro.org> Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org From: Srinivas Kandagatla Register slimbus controller only after finishing powerup sequnce so that we do not endup in situation where core starts sending transactions before the controller is ready. Signed-off-by: Srinivas Kandagatla --- drivers/slimbus/qcom-ngd-ctrl.c | 20 +++++++++++--------- 1 file changed, 11 insertions(+), 9 deletions(-) -- 2.9.3 diff --git a/drivers/slimbus/qcom-ngd-ctrl.c b/drivers/slimbus/qcom-ngd-ctrl.c index b9f2e3f..0241373 100644 --- a/drivers/slimbus/qcom-ngd-ctrl.c +++ b/drivers/slimbus/qcom-ngd-ctrl.c @@ -1238,8 +1238,17 @@ static int qcom_slim_ngd_enable(struct qcom_slim_ngd_ctrl *ctrl, bool enable) pm_runtime_resume(ctrl->dev); pm_runtime_mark_last_busy(ctrl->dev); pm_runtime_put(ctrl->dev); + + ret = slim_register_controller(&ctrl->ctrl); + if (ret) { + dev_err(ctrl->dev, "error adding slim controller\n"); + return ret; + } + + dev_info(ctrl->dev, "SLIM controller Registered\n"); } else { qcom_slim_qmi_exit(ctrl); + slim_unregister_controller(&ctrl->ctrl); } return 0; @@ -1361,11 +1370,6 @@ static int qcom_slim_ngd_probe(struct platform_device *pdev) int ret; ctrl->ctrl.dev = dev; - ret = slim_register_controller(&ctrl->ctrl); - if (ret) { - dev_err(dev, "error adding slim controller\n"); - return ret; - } pm_runtime_use_autosuspend(dev); pm_runtime_set_autosuspend_delay(dev, QCOM_SLIM_NGD_AUTOSUSPEND); @@ -1375,7 +1379,7 @@ static int qcom_slim_ngd_probe(struct platform_device *pdev) ret = qcom_slim_ngd_qmi_svc_event_init(ctrl); if (ret) { dev_err(&pdev->dev, "QMI service registration failed:%d", ret); - goto err; + return ret; } INIT_WORK(&ctrl->m_work, qcom_slim_ngd_master_worker); @@ -1387,8 +1391,6 @@ static int qcom_slim_ngd_probe(struct platform_device *pdev) } return 0; -err: - slim_unregister_controller(&ctrl->ctrl); wq_err: qcom_slim_ngd_qmi_svc_event_deinit(&ctrl->qmi); if (ctrl->mwq) @@ -1460,7 +1462,7 @@ static int qcom_slim_ngd_remove(struct platform_device *pdev) struct qcom_slim_ngd_ctrl *ctrl = platform_get_drvdata(pdev); pm_runtime_disable(&pdev->dev); - slim_unregister_controller(&ctrl->ctrl); + qcom_slim_ngd_enable(ctrl, false); qcom_slim_ngd_exit_dma(ctrl); qcom_slim_ngd_qmi_svc_event_deinit(&ctrl->qmi); if (ctrl->mwq)