diff mbox series

[v7,10/13] dt-bindings: Add qcom slimbus controller bindings

Message ID 20171115141043.29202-11-srinivas.kandagatla@linaro.org
State Superseded
Headers show
Series Introduce framework for SLIMbus device driver | expand

Commit Message

Srinivas Kandagatla Nov. 15, 2017, 2:10 p.m. UTC
From: Sagar Dharia <sdharia@codeaurora.org>


This patch add device tree bindings for Qualcomm slimbus controller.

Signed-off-by: Sagar Dharia <sdharia@codeaurora.org>

Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>

---
 .../devicetree/bindings/slimbus/slim-qcom-ctrl.txt | 43 ++++++++++++++++++++++
 1 file changed, 43 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/slimbus/slim-qcom-ctrl.txt

-- 
2.15.0

--
To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Rob Herring (Arm) Nov. 16, 2017, 5:19 a.m. UTC | #1
On Wed, Nov 15, 2017 at 02:10:40PM +0000, srinivas.kandagatla@linaro.org wrote:
> From: Sagar Dharia <sdharia@codeaurora.org>

> 

> This patch add device tree bindings for Qualcomm slimbus controller.

> 

> Signed-off-by: Sagar Dharia <sdharia@codeaurora.org>

> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>

> ---

>  .../devicetree/bindings/slimbus/slim-qcom-ctrl.txt | 43 ++++++++++++++++++++++

>  1 file changed, 43 insertions(+)

>  create mode 100644 Documentation/devicetree/bindings/slimbus/slim-qcom-ctrl.txt

> 

> diff --git a/Documentation/devicetree/bindings/slimbus/slim-qcom-ctrl.txt b/Documentation/devicetree/bindings/slimbus/slim-qcom-ctrl.txt

> new file mode 100644

> index 000000000000..e4d28910b2e0

> --- /dev/null

> +++ b/Documentation/devicetree/bindings/slimbus/slim-qcom-ctrl.txt

> @@ -0,0 +1,43 @@

> +Qualcomm SLIMBUS controller

> +This controller is used if applications processor driver controls slimbus

> +master component.

> +

> +Required properties:

> +

> + - #address-cells - refer to Documentation/devicetree/bindings/slimbus/bus.txt

> + - #size-cells	- refer to Documentation/devicetree/bindings/slimbus/bus.txt

> +

> + - reg : Offset and length of the register region(s) for the device

> + - reg-names : Register region name(s) referenced in reg above

> +	 Required register resource entries are:

> +	 "ctrl": Physical address of controller register blocks

> + - compatible : should be "qcom,<SOC-NAME>-slim" for SOC specific compatible

> + 		followed by "qcom,slim" for fallback.

> + - interrupts : Interrupt number used by this controller

> + - clocks : Interface and core clocks used by this slimbus controller

> + - clock-names : Required clock-name entries are:

> +	"iface_clk" : Interface clock for this controller

> +	"core_clk" : Interrupt for controller core's BAM

> +

> +

> +Optional property:

> + - reg entry for slew rate : If slew rate control register is provided, this

> +	entry should be used.

> + - reg-name for slew rate: "slew"


reg-names

I'd prefer it be explicit as to which compatibles do or don't have this 
register.

> +

> +Example:

> +

> +	slim@28080000 {

> +		compatible = "qcom,apq8064-slim", "qcom,slim";

> +		reg = <0x28080000 0x2000>,


error                                    ^

> +		interrupts = <0 33 0>;

> +		clocks = <&lcc SLIMBUS_SRC>, <&lcc AUDIO_SLIMBUS_CLK>;

> +		clock-names = "iface", "core";

> +		#address-cells = <2>;

> +		#size-cell = <0>;

> +

> +		codec: wcd9310@1,0{


Use generic node names:

wcd9310: audio-codec@1,0

> +			compatible = "slim217,60";

> +			reg = <1 0>;

> +		};

> +	};

> -- 

> 2.15.0

> 

--
To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/slimbus/slim-qcom-ctrl.txt b/Documentation/devicetree/bindings/slimbus/slim-qcom-ctrl.txt
new file mode 100644
index 000000000000..e4d28910b2e0
--- /dev/null
+++ b/Documentation/devicetree/bindings/slimbus/slim-qcom-ctrl.txt
@@ -0,0 +1,43 @@ 
+Qualcomm SLIMBUS controller
+This controller is used if applications processor driver controls slimbus
+master component.
+
+Required properties:
+
+ - #address-cells - refer to Documentation/devicetree/bindings/slimbus/bus.txt
+ - #size-cells	- refer to Documentation/devicetree/bindings/slimbus/bus.txt
+
+ - reg : Offset and length of the register region(s) for the device
+ - reg-names : Register region name(s) referenced in reg above
+	 Required register resource entries are:
+	 "ctrl": Physical address of controller register blocks
+ - compatible : should be "qcom,<SOC-NAME>-slim" for SOC specific compatible
+ 		followed by "qcom,slim" for fallback.
+ - interrupts : Interrupt number used by this controller
+ - clocks : Interface and core clocks used by this slimbus controller
+ - clock-names : Required clock-name entries are:
+	"iface_clk" : Interface clock for this controller
+	"core_clk" : Interrupt for controller core's BAM
+
+
+Optional property:
+ - reg entry for slew rate : If slew rate control register is provided, this
+	entry should be used.
+ - reg-name for slew rate: "slew"
+
+Example:
+
+	slim@28080000 {
+		compatible = "qcom,apq8064-slim", "qcom,slim";
+		reg = <0x28080000 0x2000>,
+		interrupts = <0 33 0>;
+		clocks = <&lcc SLIMBUS_SRC>, <&lcc AUDIO_SLIMBUS_CLK>;
+		clock-names = "iface", "core";
+		#address-cells = <2>;
+		#size-cell = <0>;
+
+		codec: wcd9310@1,0{
+			compatible = "slim217,60";
+			reg = <1 0>;
+		};
+	};