From patchwork Sun Jan 22 21:17:49 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bjorn Andersson X-Patchwork-Id: 92196 Delivered-To: patch@linaro.org Received: by 10.140.20.99 with SMTP id 90csp1071739qgi; Sun, 22 Jan 2017 21:17:19 -0800 (PST) X-Received: by 10.84.218.71 with SMTP id f7mr40317609plm.59.1485148639174; Sun, 22 Jan 2017 21:17:19 -0800 (PST) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d2si14502813pli.315.2017.01.22.21.17.18; Sun, 22 Jan 2017 21:17:19 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-arm-msm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org; spf=pass (google.com: best guess record for domain of linux-arm-msm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-arm-msm-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750756AbdAWFRB (ORCPT + 9 others); Mon, 23 Jan 2017 00:17:01 -0500 Received: from mail-pg0-f47.google.com ([74.125.83.47]:34131 "EHLO mail-pg0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750755AbdAWFQ7 (ORCPT ); Mon, 23 Jan 2017 00:16:59 -0500 Received: by mail-pg0-f47.google.com with SMTP id 14so41618074pgg.1 for ; Sun, 22 Jan 2017 21:16:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=nK84NeAsMaCGhXTer2kQwSxy6+duf7rctt/qNBXJJec=; b=CwenbdQsTFBlaF2glMt/R9AQhI+9ZVhfejW8yxUe5Jn0F/zeKPWQZL8bZnzDq2CC8Q LPppvajTlSnvcTYOEAjEWotM6RU5W3mKbmFXn8pNGLFvrvkVIZFOEaDI3reLUVuE1L7l 3WR3bHhZW1rgvuR372H2zbGGRO9MC8rTPjmYE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=nK84NeAsMaCGhXTer2kQwSxy6+duf7rctt/qNBXJJec=; b=ZH6xNZiF7igetdbWihW9Lix2iE5TvPlypvp3rIfrG79noym6Avdmn7HaFh28hn6xHe yC8AqkyacsMHk687D/KN/v3ISA/G1qW9SiPFr7Zsqftt0CG7J71mqx8Ak8kkc/4tPNh2 HGJxMzf/GpkxAo60CMtd9ooQAos9znRq02lF0PcMisYOPotW6aTKf7gV3n5C7DtGfVyt tR7NlNifuFCK3k0uIXOx6zcSYyYC9EVmzGlc1gS3aPwpbgDw8FlMTJjFxWcnScCXfooI mCQvtUOqlN3LnoYEyvdAv9VbCUWvHXagAb+ez4lm3Ez4seHMOkXJYi2TLv3JaJL9ir5h rE3Q== X-Gm-Message-State: AIkVDXKOsOaXiXPte/ahbOeBZyA+dhb9YyixILkLsS0c1L4r2G625elIhusA5kEMr21zFhiE X-Received: by 10.98.160.140 with SMTP id p12mr29712550pfl.97.1485148619162; Sun, 22 Jan 2017 21:16:59 -0800 (PST) Received: from localhost.localdomain (ip68-111-223-48.sd.sd.cox.net. [68.111.223.48]) by smtp.gmail.com with ESMTPSA id 18sm33169100pgf.28.2017.01.22.21.16.57 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 22 Jan 2017 21:16:58 -0800 (PST) From: Bjorn Andersson To: Kishon Vijay Abraham I Cc: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org Subject: [PATCH v2 4/4] phy: qcom-ufs: Suppress extraneous logging Date: Sun, 22 Jan 2017 13:17:49 -0800 Message-Id: <20170122211749.22803-4-bjorn.andersson@linaro.org> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20170122211749.22803-1-bjorn.andersson@linaro.org> References: <20170122211749.22803-1-bjorn.andersson@linaro.org> Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org The error paths of the common qcom-ufs functions for registering the phy, acquiring clocks and acquiring regulators all print specific error messages before returning an error, so there is no value in printing yet another - more generic - message when this occur. Reviewed-by: Vivek Gautam Reviewed-by: Subhash Jadavani Signed-off-by: Bjorn Andersson --- Changes since v1: - Picked up reviewed-bys from Vivek and Subhash drivers/phy/phy-qcom-ufs-qmp-14nm.c | 15 +++------------ drivers/phy/phy-qcom-ufs-qmp-20nm.c | 12 ++---------- 2 files changed, 5 insertions(+), 22 deletions(-) -- 2.11.0 -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/phy/phy-qcom-ufs-qmp-14nm.c b/drivers/phy/phy-qcom-ufs-qmp-14nm.c index c71c84734916..12a1b498dc4b 100644 --- a/drivers/phy/phy-qcom-ufs-qmp-14nm.c +++ b/drivers/phy/phy-qcom-ufs-qmp-14nm.c @@ -132,27 +132,18 @@ static int ufs_qcom_phy_qmp_14nm_probe(struct platform_device *pdev) &ufs_qcom_phy_qmp_14nm_phy_ops, &phy_14nm_ops); if (!generic_phy) { - dev_err(dev, "%s: ufs_qcom_phy_generic_probe() failed\n", - __func__); err = -EIO; goto out; } err = ufs_qcom_phy_init_clks(phy_common); - if (err) { - dev_err(phy_common->dev, - "%s: ufs_qcom_phy_init_clks() failed %d\n", - __func__, err); + if (err) goto out; - } err = ufs_qcom_phy_init_vregulators(phy_common); - if (err) { - dev_err(phy_common->dev, - "%s: ufs_qcom_phy_init_vregulators() failed %d\n", - __func__, err); + if (err) goto out; - } + phy_common->vdda_phy.max_uV = UFS_PHY_VDDA_PHY_UV; phy_common->vdda_phy.min_uV = UFS_PHY_VDDA_PHY_UV; diff --git a/drivers/phy/phy-qcom-ufs-qmp-20nm.c b/drivers/phy/phy-qcom-ufs-qmp-20nm.c index 1a26a64e06d3..4f68acb58b73 100644 --- a/drivers/phy/phy-qcom-ufs-qmp-20nm.c +++ b/drivers/phy/phy-qcom-ufs-qmp-20nm.c @@ -190,25 +190,17 @@ static int ufs_qcom_phy_qmp_20nm_probe(struct platform_device *pdev) &ufs_qcom_phy_qmp_20nm_phy_ops, &phy_20nm_ops); if (!generic_phy) { - dev_err(dev, "%s: ufs_qcom_phy_generic_probe() failed\n", - __func__); err = -EIO; goto out; } err = ufs_qcom_phy_init_clks(phy_common); - if (err) { - dev_err(phy_common->dev, "%s: ufs_qcom_phy_init_clks() failed %d\n", - __func__, err); + if (err) goto out; - } err = ufs_qcom_phy_init_vregulators(phy_common); - if (err) { - dev_err(phy_common->dev, "%s: ufs_qcom_phy_init_vregulators() failed %d\n", - __func__, err); + if (err) goto out; - } ufs_qcom_phy_qmp_20nm_advertise_quirks(phy_common);