From patchwork Thu Jan 19 10:47:39 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bjorn Andersson X-Patchwork-Id: 92020 Delivered-To: patch@linaro.org Received: by 10.140.20.99 with SMTP id 90csp422288qgi; Thu, 19 Jan 2017 10:47:52 -0800 (PST) X-Received: by 10.98.13.203 with SMTP id 72mr11686905pfn.64.1484851672342; Thu, 19 Jan 2017 10:47:52 -0800 (PST) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h1si4327585plh.3.2017.01.19.10.47.52; Thu, 19 Jan 2017 10:47:52 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-arm-msm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org; spf=pass (google.com: best guess record for domain of linux-arm-msm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-arm-msm-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932101AbdASSrv (ORCPT + 9 others); Thu, 19 Jan 2017 13:47:51 -0500 Received: from mail-pf0-f171.google.com ([209.85.192.171]:33715 "EHLO mail-pf0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754374AbdASSrI (ORCPT ); Thu, 19 Jan 2017 13:47:08 -0500 Received: by mail-pf0-f171.google.com with SMTP id y143so15510379pfb.0 for ; Thu, 19 Jan 2017 10:46:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=81HZ8oefrIcAyzu3IOjjjFMjGbsECJIP+xl0StNrWoE=; b=VcbP6xAdVJaiWJy7RmapTlbl7AlwjcV8lHvxVUTCR8LTJ29bj39oOL4IM1VvvtcJQZ vAwDx7PZpFyoEj0PdspWZm4u3fBEZ6pbqlZuMGlW8npyRMOAdFLigLdJUCpJrUxUTp6A onk5B4kV93ONtnnle0ETlCjib5M4pX8nKWHAM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=81HZ8oefrIcAyzu3IOjjjFMjGbsECJIP+xl0StNrWoE=; b=ZbRqU0ORawD0ApZfuq0vBshkZ7B6k30tP9W487kNAuKWpIiyq8WPHuBbiN9hhUDlpK j76uCdE5T0u2AYU41c6gORhwVOs6YN6JRqzFO2dGrli8hHJhXGknPXvJXVFK39dOT9Us IpFax+2qX3QTNhmNdhLvsVCsf8EECZu7wghBhfAuaGXy2YawB5sfHJFj64fEf1S16trY wMhiOKSb3r/KXlkN1EiVvfOgpPpGEoxcAXSQWYg0naaQOIgvv2ABAVFJcRSWpHnhwExM UzO5Xv0tJKowPlAtVdwByOv0eBY+uMXt8zhd2Fgp6z5HGx3RDBQPDHeZBJ+jUvQlyOqu bkZA== X-Gm-Message-State: AIkVDXICgwevLbz5dOXT61Y32pUJy7oBtlCHv5vSjkyLDSXZup6KnixZb+g712qZB7cyqb+F X-Received: by 10.99.153.26 with SMTP id d26mr12213803pge.44.1484851614312; Thu, 19 Jan 2017 10:46:54 -0800 (PST) Received: from localhost.localdomain (ip68-111-223-48.sd.sd.cox.net. [68.111.223.48]) by smtp.gmail.com with ESMTPSA id w76sm10552990pfd.74.2017.01.19.10.46.52 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 19 Jan 2017 10:46:53 -0800 (PST) From: Bjorn Andersson To: Kishon Vijay Abraham I Cc: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Subhash Jadavani , Vivek Gautam Subject: [PATCH 4/4] phy: qcom-ufs: Suppress extraneous logging Date: Thu, 19 Jan 2017 02:47:39 -0800 Message-Id: <20170119104739.4376-4-bjorn.andersson@linaro.org> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20170119104739.4376-1-bjorn.andersson@linaro.org> References: <20170119104739.4376-1-bjorn.andersson@linaro.org> Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org The error paths of the common qcom-ufs functions for registering the phy, acquiring clocks and acquiring regulators all print specific error messages before returning an error, so there is no value in printing yet another - more generic - message when this occur. Cc: Subhash Jadavani Cc: Vivek Gautam Signed-off-by: Bjorn Andersson --- drivers/phy/phy-qcom-ufs-qmp-14nm.c | 15 +++------------ drivers/phy/phy-qcom-ufs-qmp-20nm.c | 12 ++---------- 2 files changed, 5 insertions(+), 22 deletions(-) -- 2.11.0 -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Reviewed-by: Vivek Gautam diff --git a/drivers/phy/phy-qcom-ufs-qmp-14nm.c b/drivers/phy/phy-qcom-ufs-qmp-14nm.c index c71c84734916..12a1b498dc4b 100644 --- a/drivers/phy/phy-qcom-ufs-qmp-14nm.c +++ b/drivers/phy/phy-qcom-ufs-qmp-14nm.c @@ -132,27 +132,18 @@ static int ufs_qcom_phy_qmp_14nm_probe(struct platform_device *pdev) &ufs_qcom_phy_qmp_14nm_phy_ops, &phy_14nm_ops); if (!generic_phy) { - dev_err(dev, "%s: ufs_qcom_phy_generic_probe() failed\n", - __func__); err = -EIO; goto out; } err = ufs_qcom_phy_init_clks(phy_common); - if (err) { - dev_err(phy_common->dev, - "%s: ufs_qcom_phy_init_clks() failed %d\n", - __func__, err); + if (err) goto out; - } err = ufs_qcom_phy_init_vregulators(phy_common); - if (err) { - dev_err(phy_common->dev, - "%s: ufs_qcom_phy_init_vregulators() failed %d\n", - __func__, err); + if (err) goto out; - } + phy_common->vdda_phy.max_uV = UFS_PHY_VDDA_PHY_UV; phy_common->vdda_phy.min_uV = UFS_PHY_VDDA_PHY_UV; diff --git a/drivers/phy/phy-qcom-ufs-qmp-20nm.c b/drivers/phy/phy-qcom-ufs-qmp-20nm.c index 1a26a64e06d3..4f68acb58b73 100644 --- a/drivers/phy/phy-qcom-ufs-qmp-20nm.c +++ b/drivers/phy/phy-qcom-ufs-qmp-20nm.c @@ -190,25 +190,17 @@ static int ufs_qcom_phy_qmp_20nm_probe(struct platform_device *pdev) &ufs_qcom_phy_qmp_20nm_phy_ops, &phy_20nm_ops); if (!generic_phy) { - dev_err(dev, "%s: ufs_qcom_phy_generic_probe() failed\n", - __func__); err = -EIO; goto out; } err = ufs_qcom_phy_init_clks(phy_common); - if (err) { - dev_err(phy_common->dev, "%s: ufs_qcom_phy_init_clks() failed %d\n", - __func__, err); + if (err) goto out; - } err = ufs_qcom_phy_init_vregulators(phy_common); - if (err) { - dev_err(phy_common->dev, "%s: ufs_qcom_phy_init_vregulators() failed %d\n", - __func__, err); + if (err) goto out; - } ufs_qcom_phy_qmp_20nm_advertise_quirks(phy_common);