From patchwork Tue Oct 18 01:56:25 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Boyd X-Patchwork-Id: 77906 Delivered-To: patch@linaro.org Received: by 10.140.97.247 with SMTP id m110csp657431qge; Mon, 17 Oct 2016 19:00:17 -0700 (PDT) X-Received: by 10.66.101.35 with SMTP id fd3mr604644pab.170.1476756017064; Mon, 17 Oct 2016 19:00:17 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 62si33063438pfl.147.2016.10.17.19.00.16; Mon, 17 Oct 2016 19:00:17 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-arm-msm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org; spf=pass (google.com: best guess record for domain of linux-arm-msm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-arm-msm-owner@vger.kernel.org; dmarc=fail (p=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964913AbcJRCAO (ORCPT + 10 others); Mon, 17 Oct 2016 22:00:14 -0400 Received: from mail-pf0-f173.google.com ([209.85.192.173]:35821 "EHLO mail-pf0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S936313AbcJRB4y (ORCPT ); Mon, 17 Oct 2016 21:56:54 -0400 Received: by mail-pf0-f173.google.com with SMTP id s8so85941894pfj.2 for ; Mon, 17 Oct 2016 18:56:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=vUj5l5p8TH4hBlSsewEa3N/TCFaiOrmX9AUM13NDuRA=; b=LU4wNzxAXc9ZhAT9jFFo4X/gWj8u5dNYEql2T7VEZ6nS4B9OedvNwfvoSaC3ZWcVnJ G+AgayKHD0LrONwGFM2UJi2Xfg4NbB7/JCKvjjhSsDTom7NCcGeHXgOvebXB46WbCL7h keKqFtjYqPLsQ8xj5F/EWL1HqTXmMigVmE5H0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=vUj5l5p8TH4hBlSsewEa3N/TCFaiOrmX9AUM13NDuRA=; b=c1wtB9hLvMrxRbEqQT+VXXBmxnBAP2E4z5TdEP4GOUctSM40yDaTuErrrJyBwt9xs9 OGwFyKXyQ+3Hq9kFUgolOfduumo6xWDZk92SNBg7dHXXB9+rs1t2qL5QbuVrSOOj8bJu hvRnQlAFO2D4rmJysSRxButJbPDEalJRySbJ/4dSXk9rUp+dB5P5z64OL9tXUpYrsc/a bIUc8l7uPuHDqnJ22FKlEBqBMBvGGvBA8i7SNpTvts1gb4w0HTWJidtyKGkeD4SF52zq +U57SxGT5M7eoNstyhdC2Ot/KGFw41yZ1HqG4CDDLDTCrexCBp9vEYM9VfJm71k2b5nv 2JGg== X-Gm-Message-State: AA6/9RmcewuWSLupNeWZNRokJC8Jg7m4SS+F0AcVrowkEhMhoEVrRfJfFhiQcuZCdTWNaR4g X-Received: by 10.98.37.198 with SMTP id l189mr676088pfl.39.1476755812488; Mon, 17 Oct 2016 18:56:52 -0700 (PDT) Received: from localhost.localdomain (i-global254.qualcomm.com. [199.106.103.254]) by smtp.gmail.com with ESMTPSA id j6sm51020430paa.44.2016.10.17.18.56.51 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 17 Oct 2016 18:56:52 -0700 (PDT) From: Stephen Boyd To: linux-usb@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Andy Gross , Bjorn Andersson , Neil Armstrong , Arnd Bergmann , Felipe Balbi , Peter Chen , Greg Kroah-Hartman Subject: [PATCH v5 12/23] usb: chipidea: msm: Mark device as runtime pm active Date: Mon, 17 Oct 2016 18:56:25 -0700 Message-Id: <20161018015636.11701-13-stephen.boyd@linaro.org> X-Mailer: git-send-email 2.10.0.297.gf6727b0 In-Reply-To: <20161018015636.11701-1-stephen.boyd@linaro.org> References: <20161018015636.11701-1-stephen.boyd@linaro.org> Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org We're not properly marking the glue layer/wrapper device as runtime active, so runtime PM believes that the hardware state is inactive when we call pm_runtime_enable() in this driver. This causes a problem when the glue layer has a power domain associated with it, because runtime PM will go and disable the power domain to match the 'inactive' state of the device. Let's mark the device as active so that runtime PM doesn't improperly power down this device when it's actually active. Acked-by: Peter Chen Cc: Greg Kroah-Hartman Signed-off-by: Stephen Boyd --- drivers/usb/chipidea/ci_hdrc_msm.c | 1 + 1 file changed, 1 insertion(+) -- 2.10.0.297.gf6727b0 -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/usb/chipidea/ci_hdrc_msm.c b/drivers/usb/chipidea/ci_hdrc_msm.c index 3889809fd0c4..89c1a02d69b5 100644 --- a/drivers/usb/chipidea/ci_hdrc_msm.c +++ b/drivers/usb/chipidea/ci_hdrc_msm.c @@ -80,6 +80,7 @@ static int ci_hdrc_msm_probe(struct platform_device *pdev) platform_set_drvdata(pdev, plat_ci); + pm_runtime_set_active(&pdev->dev); pm_runtime_no_callbacks(&pdev->dev); pm_runtime_enable(&pdev->dev);