From patchwork Fri Jan 25 07:02:27 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Amit Kucheria X-Patchwork-Id: 156548 Delivered-To: patch@linaro.org Received: by 2002:a02:48:0:0:0:0:0 with SMTP id 69csp18458jaa; Thu, 24 Jan 2019 23:03:32 -0800 (PST) X-Google-Smtp-Source: ALg8bN7j/pJG+eGo8B8yRWSotmf9xn2hzRUpTsuVlLnQakDetyVEZd94d/RcjYnDC/XnyJq5kYSi X-Received: by 2002:a65:47ca:: with SMTP id f10mr2402817pgs.166.1548399812539; Thu, 24 Jan 2019 23:03:32 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1548399812; cv=none; d=google.com; s=arc-20160816; b=SzifmKEE+CV4f5HbzSKFuChJGOcS4dD6beVODXZSO5Js8LDMnbe0gw7RP5owXgYDvF +BFUpXZJ4peWCe84O1qi2ZMAqKdLMKum4ecXcjY7jp9YZg0VvrZpiHUjmhdTyht+lQsv Y9ZSmIJgdOf4hVApw7W96cZEcTq/JANaoHSaiperkS2SYGY/M+K8HZsm4+eVHYbK/93p iYEiOtiAqowagtQbOU2RLT3FmMkrKy6SAvMDu1WSmXrtKI/k1job6eBTSXDiZJecIxdd xlhfrasaqyW8EgWuCcr8nIQ6zjd3Kzw3X3xsC/j6Ysvk4fAyxldkxyRwL+Iq1fNVbCD9 8Q5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:references :in-reply-to:message-id:date:subject:cc:to:from:dkim-signature; bh=T0qbmuuRPxDVtPya/S7z9HnIzaHUQLSLFndkXz9dAlg=; b=uNg8u+PNEUeQRX4cygjXzjwXE1TJnohQR0G2mn6eilSxoftFK7mToYkNcH5mqcGbDJ GSlDHaScWDaljnw91OctDO7dzM1ve861nzFDerxmqnHiFU4o8u4D7NwRqKAe9Vd0GwPb UnOQfK72xOxsJ0DbMSytSu2vYBy81Y0XHZXxIyITDUcRd2evIOhlC3y0aM5eDRiqQkdr yTwkbr2w8bPivlSNPVOEI387bYErNRii4pki7gOYoNBK1PYq3MRAFxBeYGOU8O1V9aqU Z1bwY6IL0y6GASavsf0wvirIfvyoyyWC7tlMUVTVycjQi00kRKgJPhLqH9C0Cckf5ewR OuEw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Mfl4kUgk; spf=pass (google.com: best guess record for domain of linux-arm-msm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-arm-msm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z63si18237139pfz.132.2019.01.24.23.03.32; Thu, 24 Jan 2019 23:03:32 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-arm-msm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Mfl4kUgk; spf=pass (google.com: best guess record for domain of linux-arm-msm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-arm-msm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728524AbfAYHDb (ORCPT + 15 others); Fri, 25 Jan 2019 02:03:31 -0500 Received: from mail-yb1-f193.google.com ([209.85.219.193]:40625 "EHLO mail-yb1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728505AbfAYHDb (ORCPT ); Fri, 25 Jan 2019 02:03:31 -0500 Received: by mail-yb1-f193.google.com with SMTP id i6so3446250ybo.7 for ; Thu, 24 Jan 2019 23:03:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=T0qbmuuRPxDVtPya/S7z9HnIzaHUQLSLFndkXz9dAlg=; b=Mfl4kUgk5Aal9odAJZaf5fVDL4LZALQC7ZfU1MBmIZrUrGFbkU/ZoVR/6wogyLJqT3 nBXoxBHOUyRGxHsVUurXbrSQ8ExPyV3uzHl/p9AqV/3GBDONOntxw0HZOtNYbgx/s40b N4Em4TZXghHpuLI7Wvt/9ucEhVUfN7XsiTGl4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=T0qbmuuRPxDVtPya/S7z9HnIzaHUQLSLFndkXz9dAlg=; b=sfB6I+zxlIfV+5d00ACXVvUgai7RzWdVUIIChDU6LEE62cOH5WxqYixsbJzmWpWxP3 u7pi6Nq3+OGGulfCNGrBBbcHdAWWHuUFQbA+AggkmwxgtmObWnBzbog/qd3KfyTf0gAV wIMSIE8nEr4dCHVvvtRtwcc/uPjYHUWvJE2lvnV6zDfE1pYLfL35qLVlPVrrUhUN/isT ZUfZav20g+U5tMFwrkfyx3aMDolq81QAEk/Tg0x8NKTevRenQX/fWNcCp9Ck9oMQvhof xvLWu+cGrt2HKQ5Eh6481MaDipxNW1h1GeDBjoZpflOUxhzNR1a8EwhcNc3dk70YuiPt hwmw== X-Gm-Message-State: AJcUukcx2uP2kw7HHjS2T5kXW0x1c5H0rr/2ZDuacrVR9ZwnEUMjAfZE hez5jrWQGJHNFH5d4g5CiixAFA== X-Received: by 2002:a25:d688:: with SMTP id n130mr8188972ybg.29.1548399810240; Thu, 24 Jan 2019 23:03:30 -0800 (PST) Received: from localhost ([49.248.181.51]) by smtp.gmail.com with ESMTPSA id w63sm8943697ywc.46.2019.01.24.23.03.28 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 24 Jan 2019 23:03:29 -0800 (PST) From: Amit Kucheria To: linux-kernel@vger.kernel.org Cc: linux-arm-msm@vger.kernel.org, viresh.kumar@linaro.org, edubezval@gmail.com, swboyd@chromium.org, dianders@chromium.org, mka@chromium.org, "Rafael J. Wysocki" , linux-pm@vger.kernel.org (open list:CPU FREQUENCY SCALING FRAMEWORK) Subject: [PATCHv3 7/9] cpufreq: qoriq: Use auto-registration of thermal cooling device Date: Fri, 25 Jan 2019 12:32:27 +0530 Message-Id: <1d18d89fe2fc3655d372a0ab25e1241df4f8dd99.1548398851.git.amit.kucheria@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: References: In-Reply-To: References: Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Use the CPUFREQ_AUTO_REGISTER_COOLING_DEV flag to allow cpufreq core to automatically register as a thermal cooling device. This allows removal of boiler plate code from the driver. Signed-off-by: Amit Kucheria --- drivers/cpufreq/qoriq-cpufreq.c | 15 ++------------- 1 file changed, 2 insertions(+), 13 deletions(-) -- 2.17.1 diff --git a/drivers/cpufreq/qoriq-cpufreq.c b/drivers/cpufreq/qoriq-cpufreq.c index 3d773f64b4df..b206e6cb55f0 100644 --- a/drivers/cpufreq/qoriq-cpufreq.c +++ b/drivers/cpufreq/qoriq-cpufreq.c @@ -13,7 +13,6 @@ #include #include #include -#include #include #include #include @@ -31,7 +30,6 @@ struct cpu_data { struct clk **pclk; struct cpufreq_frequency_table *table; - struct thermal_cooling_device *cdev; }; /* @@ -239,7 +237,6 @@ static int qoriq_cpufreq_cpu_exit(struct cpufreq_policy *policy) { struct cpu_data *data = policy->driver_data; - cpufreq_cooling_unregister(data->cdev); kfree(data->pclk); kfree(data->table); kfree(data); @@ -258,23 +255,15 @@ static int qoriq_cpufreq_target(struct cpufreq_policy *policy, return clk_set_parent(policy->clk, parent); } - -static void qoriq_cpufreq_ready(struct cpufreq_policy *policy) -{ - struct cpu_data *cpud = policy->driver_data; - - cpud->cdev = of_cpufreq_cooling_register(policy); -} - static struct cpufreq_driver qoriq_cpufreq_driver = { .name = "qoriq_cpufreq", - .flags = CPUFREQ_CONST_LOOPS, + .flags = CPUFREQ_CONST_LOOPS | + CPUFREQ_AUTO_REGISTER_COOLING_DEV, .init = qoriq_cpufreq_cpu_init, .exit = qoriq_cpufreq_cpu_exit, .verify = cpufreq_generic_frequency_table_verify, .target_index = qoriq_cpufreq_target, .get = cpufreq_generic_get, - .ready = qoriq_cpufreq_ready, .attr = cpufreq_generic_attr, };