From patchwork Wed Oct 5 20:31:54 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lina Iyer X-Patchwork-Id: 77285 Delivered-To: patch@linaro.org Received: by 10.140.106.72 with SMTP id d66csp2987557qgf; Wed, 5 Oct 2016 13:32:20 -0700 (PDT) X-Received: by 10.98.73.146 with SMTP id r18mr10446255pfi.106.1475699540712; Wed, 05 Oct 2016 13:32:20 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a8si49661889pfe.175.2016.10.05.13.32.20; Wed, 05 Oct 2016 13:32:20 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-arm-msm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org; spf=pass (google.com: best guess record for domain of linux-arm-msm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-arm-msm-owner@vger.kernel.org; dmarc=fail (p=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755051AbcJEUcM (ORCPT + 9 others); Wed, 5 Oct 2016 16:32:12 -0400 Received: from mail-pa0-f54.google.com ([209.85.220.54]:33549 "EHLO mail-pa0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755042AbcJEUcM (ORCPT ); Wed, 5 Oct 2016 16:32:12 -0400 Received: by mail-pa0-f54.google.com with SMTP id cd13so85841004pac.0 for ; Wed, 05 Oct 2016 13:32:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=DgUBRf30PqLDMkLAPCIj1TkwxBAiC+sdb7QkpGTjjMM=; b=bj4dPJN5LFEqVVONsUTuA84VbAXB349yMLXFVyW00O9YA6v/S1U65R7GSNMCog45um 98N+dLUrOhD/qUQ5wd7OVbyqJsn9cJPvQLUm80Pk+wIZKa+YJ0P8CeWZ13OF8fy4dEu4 WhVJ0iGzKAIR9umJNVrA8lvWj9293S+KgXGRU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=DgUBRf30PqLDMkLAPCIj1TkwxBAiC+sdb7QkpGTjjMM=; b=NqxhnmN4RnsgMFV09w4ukvwbepTjowvmzATQUceKhWQ7HPiDVsrPPneBdgwPyPRFUN OsvZ5zjfrUKNfsBew2rLk/xrMjHP9QVFSSYcLK0hbyr+7W20iikRInywKMjGl1fPyt96 aFpJKVQz6WEqIN0yoO6qYiAr1KeNvqGvtarO1veAcVriMvx1rxNF7ErKH2n9lXSzwQ2i BbHOgx5RNFsX49MkJZ604R8Gvd1H+VbdS/lzwfcgoUQPOQvVqHylgWK8Z8+26A3o+uFl Nhf2nAQLTJqiUG6XYdFu4H//5Wkd+Dh2SrhjXYGdny7zh3utlkDm0902nhKMIi/2a+jZ Zrug== X-Gm-Message-State: AA6/9Rmak7pEy/fMkCoq3tnMmBtrXAyIB2GhGCpsKHPp13ypO13HXxtU7g2DGTNhLXmx9l8t X-Received: by 10.66.163.227 with SMTP id yl3mr16452346pab.0.1475699531320; Wed, 05 Oct 2016 13:32:11 -0700 (PDT) Received: from ubuntu.localdomain (i-global254.qualcomm.com. [199.106.103.254]) by smtp.gmail.com with ESMTPSA id s80sm42999467pfd.10.2016.10.05.13.32.09 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 05 Oct 2016 13:32:10 -0700 (PDT) From: Lina Iyer To: ulf.hansson@linaro.org, khilman@kernel.org, rjw@rjwysocki.net, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: andy.gross@linaro.org, sboyd@codeaurora.org, linux-arm-msm@vger.kernel.org, brendan.jackman@arm.com, lorenzo.pieralisi@arm.com, sudeep.holla@arm.com, Juri.Lelli@arm.com, Lina Iyer , Marc Titinger Subject: [PATCH 3/8] PM / Domains: Allow domain power states to be read from DT Date: Wed, 5 Oct 2016 14:31:54 -0600 Message-Id: <1475699519-109623-4-git-send-email-lina.iyer@linaro.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1475699519-109623-1-git-send-email-lina.iyer@linaro.org> References: <1475699519-109623-1-git-send-email-lina.iyer@linaro.org> Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org This patch allows domains to define idle states in the DT. SoC's can define domain idle states in DT using the "domain-idle-states" property of the domain provider. Calling of_pm_genpd_init() will read the idle states and initialize the genpd for the domain. In addition to the entry and exit latency for idle state, also add residency_ns, param and of_node property to each state. A domain idling in a state is only power effecient if it stays idle for a certain period in that state. The residency provides this minimum time for the idle state to provide power benefits. The param is a state specific u32 value that the platform may use for that idle state. This patch is based on the original patch by Marc Titinger. Signed-off-by: Marc Titinger Signed-off-by: Ulf Hansson Signed-off-by: Lina Iyer --- drivers/base/power/domain.c | 103 ++++++++++++++++++++++++++++++++++++++++++++ include/linux/pm_domain.h | 8 ++++ 2 files changed, 111 insertions(+) -- 2.7.4 -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c index 740afa9..368a5b8 100644 --- a/drivers/base/power/domain.c +++ b/drivers/base/power/domain.c @@ -1895,6 +1895,109 @@ out: return ret ? -EPROBE_DEFER : 0; } EXPORT_SYMBOL_GPL(genpd_dev_pm_attach); + +static const struct of_device_id idle_state_match[] = { + { .compatible = "arm,idle-state", }, + { } +}; + +static int read_genpd_state(struct genpd_power_state *genpd_state, + struct device_node *state_node) +{ + int err = 0; + u32 latency; + u32 residency; + u32 entry_latency, exit_latency; + const struct of_device_id *match_id; + + match_id = of_match_node(idle_state_match, state_node); + if (!match_id) + return -EINVAL; + + err = of_property_read_u32(state_node, "entry-latency-us", + &entry_latency); + if (err) { + pr_debug(" * %s missing entry-latency-us property\n", + state_node->full_name); + return -EINVAL; + } + + err = of_property_read_u32(state_node, "exit-latency-us", + &exit_latency); + if (err) { + pr_debug(" * %s missing exit-latency-us property\n", + state_node->full_name); + return -EINVAL; + } + + err = of_property_read_u32(state_node, "min-residency-us", &residency); + if (!err) + genpd_state->residency_ns = 1000 * residency; + + latency = entry_latency + exit_latency; + genpd_state->power_on_latency_ns = 1000 * latency; + genpd_state->power_off_latency_ns = 1000 * entry_latency; + + return 0; +} + +/** + * of_genpd_parse_idle_states: Return array of idle states for the genpd. + * + * @dn: The genpd device node + * @states: The pointer to which the state array will be saved. + * @n: The count of elements in the array returned from this function. + * + * Returns the device states parsed from the OF node. The memory for the states + * is allocated by this function and is the responsibility of the caller to + * free the memory after use. + */ +int of_genpd_parse_idle_states(struct device_node *dn, + struct genpd_power_state **states, int *n) +{ + struct genpd_power_state *st; + struct device_node *np; + int i, ret = 0; + int count; + + for (count = 0; ; count++) + if (!of_parse_phandle(dn, "domain-idle-states", count)) + break; + + st = kcalloc(count, sizeof(*st), GFP_KERNEL); + if (!st) + return -ENOMEM; + + for (i = 0; i < count; i++) { + np = of_parse_phandle(dn, "domain-idle-states", i); + if (!np) { + ret = -EFAULT; + break; + } + + ret = read_genpd_state(&st[i], np); + if (ret) { + pr_err + ("Parsing idle state node %s failed with err %d\n", + np->full_name, ret); + of_node_put(np); + break; + } + of_node_put(np); + } + + if (ret) { + kfree(st); + return ret; + } + + *n = count; + *states = st; + + return 0; +} +EXPORT_SYMBOL(of_genpd_parse_idle_states); + #endif /* CONFIG_PM_GENERIC_DOMAINS_OF */ diff --git a/include/linux/pm_domain.h b/include/linux/pm_domain.h index c113713..4c9152d 100644 --- a/include/linux/pm_domain.h +++ b/include/linux/pm_domain.h @@ -204,6 +204,8 @@ extern int of_genpd_add_device(struct of_phandle_args *args, extern int of_genpd_add_subdomain(struct of_phandle_args *parent, struct of_phandle_args *new_subdomain); extern struct generic_pm_domain *of_genpd_remove_last(struct device_node *np); +extern int of_genpd_parse_idle_states(struct device_node *dn, + struct genpd_power_state **states, int *n); int genpd_dev_pm_attach(struct device *dev); #else /* !CONFIG_PM_GENERIC_DOMAINS_OF */ @@ -233,6 +235,12 @@ static inline int of_genpd_add_subdomain(struct of_phandle_args *parent, return -ENODEV; } +static inline int of_genpd_parse_idle_states(struct device_node *dn, + struct genpd_power_state **states, int *n) +{ + return -ENODEV; +} + static inline int genpd_dev_pm_attach(struct device *dev) { return -ENODEV;