From patchwork Sun Sep 18 14:20:55 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Baoyou Xie X-Patchwork-Id: 76477 Delivered-To: patch@linaro.org Received: by 10.140.106.72 with SMTP id d66csp545206qgf; Sun, 18 Sep 2016 07:21:19 -0700 (PDT) X-Received: by 10.67.23.4 with SMTP id hw4mr39274755pad.7.1474208478999; Sun, 18 Sep 2016 07:21:18 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m10si209802paa.66.2016.09.18.07.21.18; Sun, 18 Sep 2016 07:21:18 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-arm-msm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org; spf=pass (google.com: best guess record for domain of linux-arm-msm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-arm-msm-owner@vger.kernel.org; dmarc=fail (p=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933721AbcIROVR (ORCPT + 8 others); Sun, 18 Sep 2016 10:21:17 -0400 Received: from mail-pf0-f174.google.com ([209.85.192.174]:36730 "EHLO mail-pf0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932670AbcIROVQ (ORCPT ); Sun, 18 Sep 2016 10:21:16 -0400 Received: by mail-pf0-f174.google.com with SMTP id q2so21966937pfj.3 for ; Sun, 18 Sep 2016 07:21:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=YPo4J+YAarVyAqnjahTwscGv3spK7T/HTJOSfLdPuMU=; b=daKEfDGQAb0H9Gs8AzWHw9LBQQnXkKxc2Qg29OfECwibeI83BunlB02V7tD2hCYroG bF6a05QIlftpwhcLzXX2rjUnJ6XYY7yL9I/Pxsx46zie21y9EVTxc7C+o915siTBeTpa STx3aEzkfo08dEd1sDiLRd88tutN9g3ekKocM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=YPo4J+YAarVyAqnjahTwscGv3spK7T/HTJOSfLdPuMU=; b=R12dk/ddbWCsMJYtlFp9Zdy4vVp0PnuUGSBgEp9FINa4ZLBWuNwBDkFafmHgT4Gnim aKBYZ5UUCiCwYWfEXGN2tpKpVEq4fVOVkkrrepdAnmK3CNA1x0Q+8R+F9+d+ID7y1429 nUyUyFBMnSkywcFv7SrtxuErTsrvtyK7ZmpW6Dvp9wg1fbDeaXjZ4cE03/WPMKlLvfJu MzyfGbLeb5k2u2qloSI8HHxTaCVly+qUm/Z+Y0SEwmgNR4T+8vxldeObcskzKA1IJb/i nnzrPzrf4bbSJGqfdQGoR2MNEs0G1hSNcV4MDCd8Zm8QJvQ5/Sv9hPRm/+JeLWNfYOgF fFmQ== X-Gm-Message-State: AE9vXwNdVcX4yQDaLh4fvDPaQ7UmBCOvweEUcQ7DL7+eEcc+Ix2mrJiC0y7oNvlTx8Cnh5wY X-Received: by 10.98.211.193 with SMTP id z62mr38744282pfk.124.1474208475782; Sun, 18 Sep 2016 07:21:15 -0700 (PDT) Received: from localhost.localdomain ([104.237.91.172]) by smtp.gmail.com with ESMTPSA id h123sm64853901pfe.69.2016.09.18.07.21.10 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sun, 18 Sep 2016 07:21:15 -0700 (PDT) From: Baoyou Xie To: robdclark@gmail.com, airlied@linux.ie, cstout@chromium.org, architt@codeaurora.org Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, arnd@arndb.de, baoyou.xie@linaro.org, xie.baoyou@zte.com.cn Subject: [PATCH] drm/msm/adreno: move function declarations to header file Date: Sun, 18 Sep 2016 22:20:55 +0800 Message-Id: <1474208455-11663-1-git-send-email-baoyou.xie@linaro.org> X-Mailer: git-send-email 2.7.4 Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org We get 2 warnings when building kernel with W=1: drivers/gpu/drm/msm/adreno/a3xx_gpu.c:535:17: warning: no previous prototype for 'a3xx_gpu_init' [-Wmissing-prototypes] drivers/gpu/drm/msm/adreno/a4xx_gpu.c:624:17: warning: no previous prototype for 'a4xx_gpu_init' [-Wmissing-prototypes] In fact, both functions are declared in drivers/gpu/drm/msm/adreno/adreno_device.c, but should be declared in a header file. So this patch moves both function declarations to drivers/gpu/drm/msm/adreno/adreno_gpu.h. Signed-off-by: Baoyou Xie --- drivers/gpu/drm/msm/adreno/adreno_device.c | 3 --- drivers/gpu/drm/msm/adreno/adreno_gpu.h | 3 +++ 2 files changed, 3 insertions(+), 3 deletions(-) -- 2.7.4 -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/gpu/drm/msm/adreno/adreno_device.c b/drivers/gpu/drm/msm/adreno/adreno_device.c index 5127b75..7250ffc 100644 --- a/drivers/gpu/drm/msm/adreno/adreno_device.c +++ b/drivers/gpu/drm/msm/adreno/adreno_device.c @@ -25,9 +25,6 @@ bool hang_debug = false; MODULE_PARM_DESC(hang_debug, "Dump registers when hang is detected (can be slow!)"); module_param_named(hang_debug, hang_debug, bool, 0600); -struct msm_gpu *a3xx_gpu_init(struct drm_device *dev); -struct msm_gpu *a4xx_gpu_init(struct drm_device *dev); - static const struct adreno_info gpulist[] = { { .rev = ADRENO_REV(3, 0, 5, ANY_ID), diff --git a/drivers/gpu/drm/msm/adreno/adreno_gpu.h b/drivers/gpu/drm/msm/adreno/adreno_gpu.h index a54f6e0..07d99bd 100644 --- a/drivers/gpu/drm/msm/adreno/adreno_gpu.h +++ b/drivers/gpu/drm/msm/adreno/adreno_gpu.h @@ -311,4 +311,7 @@ static inline void adreno_gpu_write(struct adreno_gpu *gpu, gpu_write(&gpu->base, reg - 1, data); } +struct msm_gpu *a3xx_gpu_init(struct drm_device *dev); +struct msm_gpu *a4xx_gpu_init(struct drm_device *dev); + #endif /* __ADRENO_GPU_H__ */