From patchwork Wed Sep 7 10:58:44 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Baoyou Xie X-Patchwork-Id: 75630 Delivered-To: patch@linaro.org Received: by 10.140.106.11 with SMTP id d11csp261990qgf; Wed, 7 Sep 2016 03:59:09 -0700 (PDT) X-Received: by 10.66.228.133 with SMTP id si5mr21349808pac.37.1473245949598; Wed, 07 Sep 2016 03:59:09 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id bi6si34544518pad.256.2016.09.07.03.59.09; Wed, 07 Sep 2016 03:59:09 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-arm-msm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org; spf=pass (google.com: best guess record for domain of linux-arm-msm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-arm-msm-owner@vger.kernel.org; dmarc=fail (p=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755511AbcIGK7I (ORCPT + 8 others); Wed, 7 Sep 2016 06:59:08 -0400 Received: from mail-pa0-f52.google.com ([209.85.220.52]:33209 "EHLO mail-pa0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751611AbcIGK7H (ORCPT ); Wed, 7 Sep 2016 06:59:07 -0400 Received: by mail-pa0-f52.google.com with SMTP id cm16so5456226pac.0 for ; Wed, 07 Sep 2016 03:59:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=x5PY9AmeWB+SOKc1WY62OiJcc+CeRxkC7CyIiDx/beU=; b=kF/nOGwcJq/5c5DOe1i5wbIXqWS3UjQmAfCWAbbTUqSXB+8e0huDdw6HaVm7yZThZ3 zH+e3GT8uYdMwmBut+fv3vj4AfX2J2NxklxogQqtjAHLGVOOxdDa9nbM/31ECFpJziLG NJZIEt+IOHDJrWvHCiI6GxmrszO7tO8+014W8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=x5PY9AmeWB+SOKc1WY62OiJcc+CeRxkC7CyIiDx/beU=; b=QAWCrf8gsPMdhgmkf1YMoYqCOOlI4fGWVJ2ZNPwvdIiSnW3sCejmSfMSli7f0f3GtJ 6g8jqsibbcpuP3lA26w3M/URLhOa91C4DMCbTFkrYMRNbUIq0g/wO4FK8vdtJIKReRIl vo218WG6xzpi0xkknT5UBSO3LOu0tkmjoVwYlAzpGyU1pVUaPIMF1Df+EZfLEjfk6G3m FV8+sIlbvV+6DEbuDOJAcq00OUFFoO/kCG3p9tmyD2N/G0aUyJQcz2g+BNtnIaowfbqQ F4ONIMRwKytabf9wPh3+bIOXk97fZECeL282SZCM6NSQUkY5R+8EZeSGOYUg0C5OMu/S K4NA== X-Gm-Message-State: AE9vXwMiPI+2uC+527iRvRinq5QuR22OEZrSMdZA0D5GnzmqY9sjg3w5GREpDDNot4MtdJNf X-Received: by 10.66.155.7 with SMTP id vs7mr80720837pab.154.1473245946317; Wed, 07 Sep 2016 03:59:06 -0700 (PDT) Received: from localhost.localdomain ([104.237.91.64]) by smtp.gmail.com with ESMTPSA id b20sm21065714pfb.55.2016.09.07.03.59.00 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 07 Sep 2016 03:59:05 -0700 (PDT) From: Baoyou Xie To: robdclark@gmail.com, airlied@linux.ie, daniel.vetter@ffwll.ch, CARLOS.PALMINHA@synopsys.com, ville.syrjala@linux.intel.com, architt@codeaurora.org, daniels@collabora.com, maarten.lankhorst@linux.intel.com Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, arnd@arndb.de, baoyou.xie@linaro.org, xie.baoyou@zte.com.cn Subject: [PATCH] drm: msm: mdp4: mark symbols static where possible Date: Wed, 7 Sep 2016 18:58:44 +0800 Message-Id: <1473245924-655-1-git-send-email-baoyou.xie@linaro.org> X-Mailer: git-send-email 2.7.4 Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org We get 2 warnings when building kernel with W=1: drivers/gpu/drm/msm/mdp/mdp4/mdp4_lcdc_encoder.c:96:23: warning: no previous prototype for 'get_connector' [-Wmissing-prototypes] drivers/gpu/drm/msm/mdp/mdp4/mdp4_plane.c:84:5: warning: no previous prototype for 'mdp4_plane_set_property' [-Wmissing-prototypes] In fact, these functions are only used in the file in which they are declared and don't need a declaration, but can be made static. So this patch marks these functions with 'static'. Signed-off-by: Baoyou Xie --- drivers/gpu/drm/msm/mdp/mdp4/mdp4_lcdc_encoder.c | 2 +- drivers/gpu/drm/msm/mdp/mdp4/mdp4_plane.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) -- 2.7.4 -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/gpu/drm/msm/mdp/mdp4/mdp4_lcdc_encoder.c b/drivers/gpu/drm/msm/mdp/mdp4/mdp4_lcdc_encoder.c index bc3d8e7..a06b064 100644 --- a/drivers/gpu/drm/msm/mdp/mdp4/mdp4_lcdc_encoder.c +++ b/drivers/gpu/drm/msm/mdp/mdp4/mdp4_lcdc_encoder.c @@ -93,7 +93,7 @@ static const struct drm_encoder_funcs mdp4_lcdc_encoder_funcs = { }; /* this should probably be a helper: */ -struct drm_connector *get_connector(struct drm_encoder *encoder) +static struct drm_connector *get_connector(struct drm_encoder *encoder) { struct drm_device *dev = encoder->dev; struct drm_connector *connector; diff --git a/drivers/gpu/drm/msm/mdp/mdp4/mdp4_plane.c b/drivers/gpu/drm/msm/mdp/mdp4/mdp4_plane.c index 9f96dfe..c5adef0 100644 --- a/drivers/gpu/drm/msm/mdp/mdp4/mdp4_plane.c +++ b/drivers/gpu/drm/msm/mdp/mdp4/mdp4_plane.c @@ -81,7 +81,7 @@ static void mdp4_plane_install_properties(struct drm_plane *plane, // XXX } -int mdp4_plane_set_property(struct drm_plane *plane, +static int mdp4_plane_set_property(struct drm_plane *plane, struct drm_property *property, uint64_t val) { // XXX