From patchwork Wed Oct 7 21:47:49 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jorge Ramirez-Ortiz X-Patchwork-Id: 54618 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-lb0-f200.google.com (mail-lb0-f200.google.com [209.85.217.200]) by patches.linaro.org (Postfix) with ESMTPS id D5BA422FEF for ; Wed, 7 Oct 2015 21:48:05 +0000 (UTC) Received: by lbwr8 with SMTP id r8sf13727427lbw.0 for ; Wed, 07 Oct 2015 14:48:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:subject:date :message-id:in-reply-to:references:sender:precedence:list-id :x-original-sender:x-original-authentication-results:mailing-list :list-post:list-help:list-archive:list-unsubscribe; bh=WvAPwrtxEleNdc5NAES2wRuue0gbJRn6oEyTajRFVuk=; b=NH1k3Kg1M3nwTHUoc5hMh5o61WXtcwI1I0+Tst1qQs0vMUY7vpGoDy+T+cFJOUNPRN MrHN+jMJMsdKQ07mL2Z1EO+Ig1ymXYxrxUXxVK9AUAn416KwF1Ku9nPbupZ0vgIZrDyh NA94nWgSHOs0wmzJjavO0Advt9MdCV77j7oXVeagUr1nXVH4bNTaOUCMDhv1mVolnw2w tT8evy1EKgrXzMbmICPxiC26MXp8hvALfM6xhXmml83ee6kdOGzz4WMRiiQVvoIQ7l0K lNJ1m5j5jV+DFw44pm12prG8Qt0mpuu+nurdA4Mrw2d/iMwCFGY/L52S+sS5L4f7p/mE Wo1Q== X-Gm-Message-State: ALoCoQkcaQfUPrgsq6qgyubldy2gskA9Qg2LvOE1sehU3KdGb8GAM9NGXdT8sUmQ5HSwuQVwka1j X-Received: by 10.112.138.4 with SMTP id qm4mr683739lbb.6.1444254484841; Wed, 07 Oct 2015 14:48:04 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.25.141.198 with SMTP id p189ls121876lfd.79.gmail; Wed, 07 Oct 2015 14:48:04 -0700 (PDT) X-Received: by 10.25.39.76 with SMTP id n73mr1190226lfn.60.1444254484705; Wed, 07 Oct 2015 14:48:04 -0700 (PDT) Received: from mail-lb0-f181.google.com (mail-lb0-f181.google.com. [209.85.217.181]) by mx.google.com with ESMTPS id ue7si26992985lbb.33.2015.10.07.14.48.04 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 07 Oct 2015 14:48:04 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.217.181 as permitted sender) client-ip=209.85.217.181; Received: by lbos8 with SMTP id s8so26368357lbo.0 for ; Wed, 07 Oct 2015 14:48:04 -0700 (PDT) X-Received: by 10.25.205.198 with SMTP id d189mr1195302lfg.72.1444254484551; Wed, 07 Oct 2015 14:48:04 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.59.35 with SMTP id w3csp214470lbq; Wed, 7 Oct 2015 14:48:03 -0700 (PDT) X-Received: by 10.68.197.196 with SMTP id iw4mr3579478pbc.153.1444254483369; Wed, 07 Oct 2015 14:48:03 -0700 (PDT) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id af1si60718373pad.198.2015.10.07.14.48.03; Wed, 07 Oct 2015 14:48:03 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-arm-msm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756540AbbJGVsB (ORCPT + 6 others); Wed, 7 Oct 2015 17:48:01 -0400 Received: from mail-qg0-f42.google.com ([209.85.192.42]:34804 "EHLO mail-qg0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756537AbbJGVsB (ORCPT ); Wed, 7 Oct 2015 17:48:01 -0400 Received: by qgez77 with SMTP id z77so27040340qge.1 for ; Wed, 07 Oct 2015 14:48:00 -0700 (PDT) X-Received: by 10.140.42.136 with SMTP id c8mr4292046qga.64.1444254480270; Wed, 07 Oct 2015 14:48:00 -0700 (PDT) Received: from localhost.localdomain (cpe-67-253-128-196.rochester.res.rr.com. [67.253.128.196]) by smtp.gmail.com with ESMTPSA id h10sm17143857qgf.29.2015.10.07.14.47.59 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 07 Oct 2015 14:47:59 -0700 (PDT) From: Jorge Ramirez-Ortiz To: jorge.ramirez-ortiz@linaro.org, agross@codeaurora.org, linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org, srinivas.kandagatla@linaro.org, nicolas.dechesne@linaro.org Subject: [PATCH] drivers/spi: spi-qup: report errors on probe failures Date: Wed, 7 Oct 2015 17:47:49 -0400 Message-Id: <1444254469-12431-2-git-send-email-jorge.ramirez-ortiz@linaro.org> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1444254469-12431-1-git-send-email-jorge.ramirez-ortiz@linaro.org> References: <1444254469-12431-1-git-send-email-jorge.ramirez-ortiz@linaro.org> Sender: linux-arm-msm-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: jorge.ramirez-ortiz@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.217.181 as permitted sender) smtp.mailfrom=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Signed-off-by: Jorge Ramirez-Ortiz --- drivers/spi/spi-qup.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/spi/spi-qup.c b/drivers/spi/spi-qup.c index 810a7fa..01a0f47 100644 --- a/drivers/spi/spi-qup.c +++ b/drivers/spi/spi-qup.c @@ -901,8 +901,10 @@ static int spi_qup_probe(struct platform_device *pdev) ret = devm_request_irq(dev, irq, spi_qup_qup_irq, IRQF_TRIGGER_HIGH, pdev->name, controller); - if (ret) + if (ret) { + dev_err(dev, "failed to request IRQ\n"); goto error_dma; + } pm_runtime_set_autosuspend_delay(dev, MSEC_PER_SEC); pm_runtime_use_autosuspend(dev); @@ -910,8 +912,10 @@ static int spi_qup_probe(struct platform_device *pdev) pm_runtime_enable(dev); ret = devm_spi_register_master(dev, master); - if (ret) + if (ret) { + dev_err(dev, "failed to register controller\n"); goto disable_pm; + } return 0;