mbox series

[0/2] Modify sa8775p.dtsi

Message ID cover.1737459414.git.quic_lxu5@quicinc.com
Headers show
Series Modify sa8775p.dtsi | expand

Message

Ling Xu Jan. 21, 2025, 11:54 a.m. UTC
Delete duplicate fastrpc nodes and remove cdsp compute-cb@10.

Ling Xu (2):
  arm64: dts: qcom: sa8775p: Delete duplicate fastrpc nodes
  arm64: dts: qcom: sa8775p: Remove cdsp compute-cb@10

 arch/arm64/boot/dts/qcom/sa8775p.dtsi | 246 +++-----------------------
 1 file changed, 23 insertions(+), 223 deletions(-)

Comments

Dmitry Baryshkov Jan. 21, 2025, 11:59 a.m. UTC | #1
On Tue, Jan 21, 2025 at 05:24:03PM +0530, Ling Xu wrote:
> There are some items come out to be same value if we do SID & ~MASK.
> Remove duplicate compute-cb nodes for sa8775p to simplify.

No, you are not removing duplicate compute-cb nodes, you are removing
extra entries from the iommus property.

> 
> Signed-off-by: Ling Xu <quic_lxu5@quicinc.com>
> ---
>  arch/arm64/boot/dts/qcom/sa8775p.dtsi | 240 +++-----------------------
>  1 file changed, 24 insertions(+), 216 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sa8775p.dtsi b/arch/arm64/boot/dts/qcom/sa8775p.dtsi
> index 9da62d7c4d27..0aa27db21f3d 100644
> --- a/arch/arm64/boot/dts/qcom/sa8775p.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sa8775p.dtsi
> @@ -4517,15 +4517,7 @@ compute-cb@1 {
>  						compatible = "qcom,fastrpc-compute-cb";
>  						reg = <1>;
>  						iommus = <&apps_smmu 0x2141 0x04a0>,
> -							 <&apps_smmu 0x2161 0x04a0>,
> -							 <&apps_smmu 0x2181 0x0400>,
> -							 <&apps_smmu 0x21c1 0x04a0>,
> -							 <&apps_smmu 0x21e1 0x04a0>,
> -							 <&apps_smmu 0x2541 0x04a0>,
> -							 <&apps_smmu 0x2561 0x04a0>,
> -							 <&apps_smmu 0x2581 0x0400>,
> -							 <&apps_smmu 0x25c1 0x04a0>,
> -							 <&apps_smmu 0x25e1 0x04a0>;
> +							 <&apps_smmu 0x2181 0x0400>;
>  						dma-coherent;
>  					};
>
Dmitry Baryshkov Jan. 21, 2025, noon UTC | #2
On Tue, Jan 21, 2025 at 05:24:02PM +0530, Ling Xu wrote:
> Delete duplicate fastrpc nodes and remove cdsp compute-cb@10.

- This is useless and incorrect
- Please use correponding prefix for the cover letter too.

> 
> Ling Xu (2):
>   arm64: dts: qcom: sa8775p: Delete duplicate fastrpc nodes
>   arm64: dts: qcom: sa8775p: Remove cdsp compute-cb@10
> 
>  arch/arm64/boot/dts/qcom/sa8775p.dtsi | 246 +++-----------------------
>  1 file changed, 23 insertions(+), 223 deletions(-)
> 
> -- 
> 2.34.1
>