| Message ID | ZpV6o8JUJWg9lZFE@windev.fritz.box |
|---|---|
| Headers | show |
| Series | arm64: dts: qcom: x1e80100-yoga: add wifi calibration variant | expand |
On Mon, Jul 15, 2024 at 09:39:51PM +0200, Patrick Wildt wrote: > Add devicetree bindings for Qualcomm ath12k PCIe devices such as WCN7850 > for which the calibration data variant may need to be described. Hi Patrick General, the device tree binding and the needed changes to the driver to implement the binding are in the same patchset. I don't see anything implementing qcom,ath12k-calibration-variant here? Does the driver already support this, and you are just fixing up missing documentation? Andrew
Am Mon, Jul 15, 2024 at 10:54:18PM +0200 schrieb Andrew Lunn: > On Mon, Jul 15, 2024 at 09:39:51PM +0200, Patrick Wildt wrote: > > Add devicetree bindings for Qualcomm ath12k PCIe devices such as WCN7850 > > for which the calibration data variant may need to be described. > > Hi Patrick > > General, the device tree binding and the needed changes to the driver > to implement the binding are in the same patchset. I don't see > anything implementing qcom,ath12k-calibration-variant here? Does the > driver already support this, and you are just fixing up missing > documentation? > > Andrew Hi there, technically I could try and make that change, but I don't actually run this driver or Linux at all; this change is for running OpenBSD on that machine with a correctly defined device tree. The realities of Linux being the de facto upstream for device tree bindings force me to submit changes here so they end up being usable for other operating systems as well. I would assume that eventually someone that runs Linux will adjust the ath12k driver as well, because this kind of binding has been used for both ath10k and ath11k and this is just a copy with a name change for ath12k. Cheers, Patrick
On 15/07/2024 21:39, Patrick Wildt wrote: > Add devicetree bindings for Qualcomm ath12k PCIe devices such as WCN7850 > for which the calibration data variant may need to be described. > > Signed-off-by: Patrick Wildt <patrick@blueri.se> > --- > .../net/wireless/qcom,ath12k-pci.yaml | 59 +++++++++++++++++++ > 1 file changed, 59 insertions(+) > create mode 100644 Documentation/devicetree/bindings/net/wireless/qcom,ath12k-pci.yaml > > diff --git a/Documentation/devicetree/bindings/net/wireless/qcom,ath12k-pci.yaml b/Documentation/devicetree/bindings/net/wireless/qcom,ath12k-pci.yaml > new file mode 100644 > index 000000000000..8f18868ee726 > --- /dev/null > +++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath12k-pci.yaml > @@ -0,0 +1,59 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +# Copyright (c) 2024 Linaro Limited > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/net/wireless/qcom,ath12k-pci.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Qualcomm Technologies ath12k wireless devices (PCIe) > + > +maintainers: > + - Kalle Valo <kvalo@kernel.org> > + - Jeff Johnson <jjohnson@kernel.org> > + > +description: | > + Qualcomm Technologies IEEE 802.11ax PCIe devices > + > +properties: > + compatible: > + enum: > + - pci17cb,1107 # WCN7850 That's a duplicate of: https://lore.kernel.org/all/20240605122106.23818-1-brgl@bgdev.pl/ AFAIK, this was already merged. I don't get why after ~1 month it is not in the linux-next. Best regards, Krzysztof
On 7/15/2024 12:38 PM, Patrick Wildt wrote: > This series adds the missing calibration variant devicetree property > which is needed to load the calibration data and use the ath12k wifi > on the Lenovo Yoga Slim 7x. > > Patrick Wildt (2): > dt-bindings: net: wireless: add ath12k pcie bindings > arm64: dts: qcom: x1e80100-yoga: add wifi calibration variant > > .../net/wireless/qcom,ath12k-pci.yaml | 59 +++++++++++++++++++ > .../dts/qcom/x1e80100-lenovo-yoga-slim7x.dts | 9 +++ > arch/arm64/boot/dts/qcom/x1e80100.dtsi | 10 ++++ > 3 files changed, 78 insertions(+) > create mode 100644 Documentation/devicetree/bindings/net/wireless/qcom,ath12k-pci.yaml > +ath12k mailing list. Qualcomm expects, on x86 and Qualcomm-based ARM devices, that this information come from ACPI. That support is currently under review: https://lore.kernel.org/all/20240717111023.78798-1-quic_lingbok@quicinc.com/ /jeff
On Thu, Jul 18, 2024 at 7:40 AM Jeff Johnson <quic_jjohnson@quicinc.com> wrote: > > On 7/15/2024 12:38 PM, Patrick Wildt wrote: > > This series adds the missing calibration variant devicetree property > > which is needed to load the calibration data and use the ath12k wifi > > on the Lenovo Yoga Slim 7x. > > > > Patrick Wildt (2): > > dt-bindings: net: wireless: add ath12k pcie bindings > > arm64: dts: qcom: x1e80100-yoga: add wifi calibration variant > > > > .../net/wireless/qcom,ath12k-pci.yaml | 59 +++++++++++++++++++ > > .../dts/qcom/x1e80100-lenovo-yoga-slim7x.dts | 9 +++ > > arch/arm64/boot/dts/qcom/x1e80100.dtsi | 10 ++++ > > 3 files changed, 78 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/net/wireless/qcom,ath12k-pci.yaml > > > > +ath12k mailing list. > > Qualcomm expects, on x86 and Qualcomm-based ARM devices, that this information > come from ACPI. That is fine for acpi boot. But it never prevented adding needed information in dt. BR, -R > That support is currently under review: > https://lore.kernel.org/all/20240717111023.78798-1-quic_lingbok@quicinc.com/ > > /jeff >
On Thu, Jul 18, 2024 at 07:40:13AM GMT, Jeff Johnson wrote: > On 7/15/2024 12:38 PM, Patrick Wildt wrote: > > This series adds the missing calibration variant devicetree property > > which is needed to load the calibration data and use the ath12k wifi > > on the Lenovo Yoga Slim 7x. > > > > Patrick Wildt (2): > > dt-bindings: net: wireless: add ath12k pcie bindings > > arm64: dts: qcom: x1e80100-yoga: add wifi calibration variant > > > > .../net/wireless/qcom,ath12k-pci.yaml | 59 +++++++++++++++++++ > > .../dts/qcom/x1e80100-lenovo-yoga-slim7x.dts | 9 +++ > > arch/arm64/boot/dts/qcom/x1e80100.dtsi | 10 ++++ > > 3 files changed, 78 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/net/wireless/qcom,ath12k-pci.yaml > > > > +ath12k mailing list. > > Qualcomm expects, on x86 and Qualcomm-based ARM devices, that this information > come from ACPI. Unfortunately we can not use ACPI on Qualcomm-based ARM devices. They all are manually converted to DT. > > That support is currently under review: > https://lore.kernel.org/all/20240717111023.78798-1-quic_lingbok@quicinc.com/ > > /jeff
On Mon, 15 Jul 2024 21:38:11 +0200, Patrick Wildt wrote: > This series adds the missing calibration variant devicetree property > which is needed to load the calibration data and use the ath12k wifi > on the Lenovo Yoga Slim 7x. > > Patrick Wildt (2): > dt-bindings: net: wireless: add ath12k pcie bindings > arm64: dts: qcom: x1e80100-yoga: add wifi calibration variant > > [...] Applied, thanks! [2/2] arm64: dts: qcom: x1e80100-yoga: add wifi calibration variant commit: 8bc7cb73df8644423758c79d4504d501c8ef3854 Best regards,