mbox series

[net-next,0/4] net: stmmac: qcom-ethqos: simplifications

Message ID Z_p0LzY2_HFupWK0@shell.armlinux.org.uk
Headers show
Series net: stmmac: qcom-ethqos: simplifications | expand

Message

Russell King (Oracle) April 12, 2025, 2:09 p.m. UTC 
Remove unnecessary code from the qcom-ethqos glue driver.

Start by consistently using -> serdes_speed to set the speed of the
serdes PHY rather than sometimes using ->serdes_speed and sometimes
using ->speed.

This then allows the removal of ->speed in the second patch.

There is no need to set the maximum speed just because we're using
2500BASE-X - phylink already knows that 2500BASE-X can't support
faster speeds.

This then makes qcom_ethqos_speed_mode_2500() redundant as it's
setting the interface mode to the value that was determined in the
switch statement that already determined that the interface mode
had this value.

Not tested on hardware.

 .../ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c    | 43 ++++++++--------------
 1 file changed, 15 insertions(+), 28 deletions(-)