From patchwork Sat May 3 07:16:59 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Baryshkov X-Patchwork-Id: 887569 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1244133F7 for ; Sat, 3 May 2025 07:17:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746256629; cv=none; b=DQfyJyrbKMUlAK2llfEhP6c7fmascMxHDcUODD7InWexhrnaxQ2VHJhkrYlpgfLZNOgZtTn6GlNvDebHWHjQkOgjFWYgGdtHET2yD62JL3URehKz54x9N23vd887aim3eoxe0U0nNDJSr0TSKpQAH8nntlJxDnTUD89hsD8WlXY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746256629; c=relaxed/simple; bh=zpaWzihcAkuFU7mOqkmcCp0zLATW5X8ucLZXXq16CRE=; h=From:Subject:Date:Message-Id:MIME-Version:Content-Type:To:Cc; b=LHxlREeOabbx5N1PGdVGBL3Vh2+0nDPMmK3wEdgaIkLCv6YLJlgJRGU9JXJH3tAmA1oDfSnEidjglVlbG2aCIGG7opEiXN8Gr52KlIdtQjI77XHF0d1EdET/m/Ys19EKPQrZe8VwbVgG0n6W0ZKj+SWRID1Ajf6ubzy3bG2u2eE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=USQTKPJB; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="USQTKPJB" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 5433WeSu027198 for ; Sat, 3 May 2025 07:17:07 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:message-id :mime-version:subject:to; s=qcppdkim1; bh=hNcb6Gt2GU+K2Wi4MQP5kS 7q72CjyKeIq2SG9MvFUcI=; b=USQTKPJBPplgMjd97YJLDJckRumEbguqRAhtHB 9BrkHmawrsgkpLKvkPlk2nuyzZp92z9+9k+B/gqYLT8KZUJZpDVA1ih0uUEEqQ16 LhOR8vborCjdH1/nbJi14vL5kMQ/5J9OizSZHSeunjCW03aPWjNZVsVpmMVVKOa2 iNnfeDLBEA00KDOK5de+yVIAa7Q0mfHN5XMdHJ9rGrz2KhGqZFFciPnd1MqHdwnC sV2iYtK/GwmR9V+HNqbZskLD0oNaFjJifNVVN688Dpzb3L7clDw7W1CDgTcKWEar 4diYZY5cBUEFLvz3HQzIRtOLCLnoO97c7KJkXQDRKJwanNjw== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 46d9nkrbw8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Sat, 03 May 2025 07:17:06 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-7c5b9333642so329867085a.3 for ; Sat, 03 May 2025 00:17:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746256625; x=1746861425; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=hNcb6Gt2GU+K2Wi4MQP5kS7q72CjyKeIq2SG9MvFUcI=; b=jOxU2BFfRy7BWNrzZ4xERtOwMMAkUs7pxLHaA0CN7n328Dtr6+yKZWb1EK8MCiklV2 +5JXQUvCYzwQw3zQGHLHA1PKGrsK99Re52IdpffDRFgIzHpotodpVSSj/xuAvyi4Jo7S 6d/6WJakPkXWYrZXET+N0YFSCpmWZ1eAFTJrAe/2+/qVg7eniUe2dVwqUaHYfN7QnMNS 8Z9CU/CzV2uNkHBTzOh3Hm06nB74vfeNU3qa42B0wwL1ODkYTIc10rgr6RSxpy+VGFgR iJBWM3YojFBz1skiaIxyMma7/ySC3D9f08YOW2aYiS6bQE1w568mYVdOAKYNbhatx91T SgfA== X-Gm-Message-State: AOJu0YwAfE4FcG1RJ+Jsf9O80vfQ6SjpJaMJ5m9kNxVXl36W2B4bk4nF 9XG2nOIBgbFYPb9+Z2uWk+FClKMP+/VubrDEp2/m1bI2E+1+8WPnnXozYK8lEMyS2iT9r1w4PrT ttoFgXZOkJm9Y5d+zgF0Z447TqAjkFjlROmBMeqA44dXBoYAauQT8HT3GG5QU23as X-Gm-Gg: ASbGnctMy+t8SZd/VvTC/rOtPbMWjf0eO+fgL/0pM/O4m5xQXizaSjOwm7U97G7Iqb3 H2Owt5aayPnEw2dg23fgn2JbTO4gKJ9amU7eYfK8vK/AiPxMUkhYO1NY0wFj+EwKu0VSyMN/491 wSxta1aZn/xFUlf3cgcFERX2CqskmquJO6X5v4mOFXK4yY4uQJetGUOBIjLcXP5KvQtsf9mOjDR e69C+s5XNy8dEpKGHHJs+f6MNWprHaRStdr8VHlaZ4xUqOzk0rUBYhcb2eexstNOEinA5V0WKQr OiUQ/YHCvF8RTNJ7cuKHRRPnxyPPx9Z2t1Ia+pXs+5E96SPMmKstnV5eWzF86q9skJhoiv2bQaz LVhwXyxs/scFdeGN+d4Jbft4/ X-Received: by 2002:a05:620a:4711:b0:7c5:3e22:616e with SMTP id af79cd13be357-7cae3b05993mr23303685a.56.1746256625494; Sat, 03 May 2025 00:17:05 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGzZAh6r7yk34zBACICarYn+7ksNe9H7A/jXSfVMrZqR4QFbAiT+CavYkAqQqGM9qu4e0Vd/A== X-Received: by 2002:a05:620a:4711:b0:7c5:3e22:616e with SMTP id af79cd13be357-7cae3b05993mr23301485a.56.1746256625139; Sat, 03 May 2025 00:17:05 -0700 (PDT) Received: from umbar.lan (2001-14ba-a0c3-3a00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a0c3:3a00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-54ea94c5557sm692816e87.84.2025.05.03.00.17.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 03 May 2025 00:17:03 -0700 (PDT) From: Dmitry Baryshkov Subject: [PATCH v2 00/11] drm/msm: rework the ties between KMS and GPU parts of the driver Date: Sat, 03 May 2025 10:16:59 +0300 Message-Id: <20250503-msm-gpu-split-v2-0-1292cba0f5ad@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-B4-Tracking: v=1; b=H4sIAOvCFWgC/13MwQqDMAzG8VeRnBdpaqdsp73H8OBc1IK12qhsi O++Tthll8A/8P02EA6WBa7JBoFXK9YPMfQpgbqrhpbRPmODVvqsDBE6cdiOC8rY2xl1oYjNhY1 qFMTNGLixr8O7l7E7K7MP74Nf6fv9SdmftBIqJMp0Yx455XVx8yLptFR97Z1L44Fy3/cPq4nWm LEAAAA= X-Change-ID: 20250411-msm-gpu-split-2701e49e40f0 To: Rob Clark , Abhinav Kumar , Dmitry Baryshkov , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Konrad Dybcio Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=3290; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=zpaWzihcAkuFU7mOqkmcCp0zLATW5X8ucLZXXq16CRE=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBoFcLs8czfk2fFmfLywbFlWfcNnIy7EbvZg8VT8 /qJGFPSEjuJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCaBXC7AAKCRCLPIo+Aiko 1ezOCACf61qvE4g158ByABGSe5jNgTEE03FziSvWkgJ8Q6a1kEDquwUWSM+kLn2Fw082s/18auQ GaFv7xvox6sh1/lYH9wKmeBMHF1XdEjN4mUVzdN9C9ex6tltonKwfXNMtTH3WT9XPC5awHbif9P kfdavGnHZjbnmaqkVMCrpy/GQ7z+QNgjvZXlPTd+ymoDjeFiyCgYZSpwFknfPo0/Ob838jBaZ7H soAlQGItpaUhPixnN45BHGXaM18QwU+56sKMJHMgTmqKP/rsj+1xFT4280eDV/087Nag/YvVebH EYwuNOj2xV9kWyrdDW8W22TeY14O4EuXGWQFqCfnRrc6ik5Q X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNTAzMDA2MSBTYWx0ZWRfX4LgRvDE2T1/8 aez6tcbLB/1KNhSmAjMgry6PLqkYlKuVrkV4vMEiIFjI16nEHRdwapJYZv6dqhsL70nLTnbCIoL 5pIeXs4AlC+74ZVGWzIdwxh11A/G8tbTp0M1wNn2MsvhhYyIr0NzdpftDzXL0H14E4Y7hKtrggr Hcehd362g85TUNz7sogJ8Y5R5ALBOpk1xZ5RhaFwZce3/73me2IQlS0LpYvqk2IIZ27f00FO501 +2yompObA66liOZLDyAWIGW8UiTsrBLw0AhIDMrceesq2qE81S04RkP58hnqJv9Q9+2k5Lv10U5 Je31BgF5LiELtf/PKS9XBHKxwy0YNEUxLe7jRAD9hfhpMX61PS3T6x1f+dHD2hbhzlJP2Dyw3WV J+NpegETMXJOLJszyAPgh+E/L4ItDGPLOOwIfpBAuzMbH+7i95Sra8RMKVu8P/pMx/vNsDGl X-Proofpoint-GUID: xhzpPRAyBMF3FXStZSj-f4gAc5sn_3AD X-Authority-Analysis: v=2.4 cv=LpeSymdc c=1 sm=1 tr=0 ts=6815c2f2 cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=dt9VzEwgFbYA:10 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=3aS5ecUQXdRO32CnfYUA:9 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 X-Proofpoint-ORIG-GUID: xhzpPRAyBMF3FXStZSj-f4gAc5sn_3AD X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-05-03_03,2025-04-30_01,2025-02-21_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=999 adultscore=0 lowpriorityscore=0 impostorscore=0 mlxscore=0 spamscore=0 malwarescore=0 priorityscore=1501 clxscore=1015 phishscore=0 bulkscore=0 suspectscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2504070000 definitions=main-2505030061 Currently the KMS and GPU parts of the msm driver are pretty much intertwined. It is impossible to register a KMS-only device and registering a GPU-only DRM device requires modifying the DT. Not to mention that binding the GPU-only device creates an interim platform devices, which complicates IOMMU setup. Rework the driver: - Make it possible to disable KMS parts (if MDP4, MDP5 and DPU drivers are disabled). - Register GPU-only devices without an interim platform device. - Add module param that makes msm driver register GPU and KMS devices separately. Signed-off-by: Dmitry Baryshkov --- Changes in v2: - Got rid of mdp4_crtc.id and msm_drm_private.num_crtcs - Moved msm_drm_private.wq and msm_drm_private.event_thread to struct msm_kms (Rob Clark) - Moved HDMI / DSI / DP pointers to msm_kms (Abhinav) - Link to v1: https://lore.kernel.org/r/20250413-msm-gpu-split-v1-0-1132f4b616c7@oss.qualcomm.com --- Dmitry Baryshkov (11): drm/msm: move wq handling to KMS code drm/msm: move helper calls to msm_kms.c drm/msm/mdp4: get rid of mdp4_crtc.id drm/msm: get rid of msm_drm_private::num_crtcs drm/msm: move KMS driver data to msm_kms drm/msm: make it possible to disable KMS-related code. drm/msm: bail out late_init_minor() if it is not a GPU device drm/msm: rearrange symbol selection drm/msm: rework binding of Imageon GPUs drm/msm: enable separate binding of GPU and display devices drm/msm: make it possible to disable GPU support drivers/gpu/drm/msm/Kconfig | 54 ++++-- drivers/gpu/drm/msm/Makefile | 31 +-- drivers/gpu/drm/msm/adreno/adreno_device.c | 39 +--- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 4 +- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 13 +- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 35 ++-- drivers/gpu/drm/msm/disp/mdp4/mdp4_crtc.c | 9 +- drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c | 13 +- drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.h | 2 +- drivers/gpu/drm/msm/disp/mdp5/mdp5_crtc.c | 2 +- drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c | 17 +- drivers/gpu/drm/msm/disp/msm_disp_snapshot_util.c | 12 +- drivers/gpu/drm/msm/dp/dp_debug.c | 4 + drivers/gpu/drm/msm/dp/dp_display.c | 6 +- drivers/gpu/drm/msm/dsi/dsi.c | 4 +- drivers/gpu/drm/msm/hdmi/hdmi.c | 13 +- drivers/gpu/drm/msm/msm_debugfs.c | 222 ++++++++++++---------- drivers/gpu/drm/msm/msm_drv.c | 205 +++++++++++++------- drivers/gpu/drm/msm/msm_drv.h | 34 ++-- drivers/gpu/drm/msm/msm_gpu.h | 71 ++++++- drivers/gpu/drm/msm/msm_kms.c | 41 +++- drivers/gpu/drm/msm/msm_kms.h | 46 +++++ drivers/gpu/drm/msm/msm_submitqueue.c | 12 +- 23 files changed, 549 insertions(+), 340 deletions(-) --- base-commit: 37ff6e9a2ce321b7932d3987701757fb4d87b0e6 change-id: 20250411-msm-gpu-split-2701e49e40f0 Best regards,