mbox series

[0/6] arm64: dts: qcom: qcs615: enable remoteprocs - ADSP and CDSP

Message ID 20250423-add_qcs615_remoteproc_support-v1-0-a94fe8799f14@quicinc.com
Headers show
Series arm64: dts: qcom: qcs615: enable remoteprocs - ADSP and CDSP | expand

Message

Lijuan Gao April 23, 2025, 9:17 a.m. UTC
Enable the remote processor PAS loader for QCS615 ADSP and CDSP
processors. This allows different platforms/architectures to control
(power on, load firmware, power off) those remote processors while
abstracting the hardware differences. Additionally, and add a PIL region
in IMEM so that post mortem debug tools can collect ramdumps. 

Signed-off-by: Lijuan Gao <quic_lijuang@quicinc.com>
---
Kyle Deng (1):
      arm64: dts: qcom: qcs615: Add mproc node for SEMP2P

Lijuan Gao (5):
      dt-bindings: remoteproc: qcom,sm8150-pas: Document QCS615 remoteproc
      dt-bindings: soc: qcom: add qcom,qcs615-imem compatible
      arm64: dts: qcom: qcs615: Add IMEM and PIL info region
      arm64: dts: qcom: qcs615: add ADSP and CDSP nodes
      arm64: dts: qcom: qcs615-ride: enable remoteprocs

 .../bindings/remoteproc/qcom,sm8150-pas.yaml       |  59 ++++---
 .../devicetree/bindings/sram/qcom,imem.yaml        |   1 +
 arch/arm64/boot/dts/qcom/qcs615-ride.dts           |  10 ++
 arch/arm64/boot/dts/qcom/qcs615.dtsi               | 179 +++++++++++++++++++++
 4 files changed, 225 insertions(+), 24 deletions(-)
---
base-commit: f660850bc246fef15ba78c81f686860324396628
change-id: 20250416-add_qcs615_remoteproc_support-61ddab556c4e

Best regards,

Comments

Konrad Dybcio April 26, 2025, 9:54 a.m. UTC | #1
On 4/24/25 9:56 AM, Lijuan Gao wrote:
> 
> 
> 在 4/23/2025 5:34 PM, Konrad Dybcio 写道:
>> On 4/23/25 11:17 AM, Lijuan Gao wrote:
>>> Add nodes for remoteprocs: ADSP and CDSP for QCS615 SoC to enable proper
>>> remoteproc functionality.
>>>
>>> Signed-off-by: Lijuan Gao <quic_lijuang@quicinc.com>
>>> ---

[...]

>>> +        remoteproc_adsp: remoteproc-adsp@62400000 {
>>> +            compatible = "qcom,qcs615-adsp-pas", "qcom,sm8150-adsp-pas";
>>> +            reg = <0x0 0x62400000 0x0 0x100>;
>>
>> The size is 0x100000 (1 MiB)
> 
> Sorry, my mistake. I checked the latest datasheet, and the size should be 0x4040. I will update the register size for both ADSP and CDSP

Yes you're right

Konrad
Krzysztof Kozlowski April 28, 2025, 7:48 a.m. UTC | #2
On Wed, Apr 23, 2025 at 05:17:37PM GMT, Lijuan Gao wrote:
>  
>    reg:
>      maxItems: 1
> @@ -59,16 +68,17 @@ allOf:
>    - if:
>        properties:
>          compatible:
> -          enum:
> -            - qcom,sc8180x-adsp-pas
> -            - qcom,sc8180x-cdsp-pas
> -            - qcom,sc8180x-slpi-pas

This needs fixes, but it is not related to this patch. I'll send a fix
but might conflict in first diff chunk.

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof