From patchwork Mon Mar 24 11:51:18 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Baryshkov X-Patchwork-Id: 875825 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 058351A317E for ; Mon, 24 Mar 2025 11:51:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742817087; cv=none; b=GBMSSUTvT8yrnaoztQe7r+wUKO6wPD/xzUr+OO9N5XIYfsXfJ6ApdvlhWLW557CubKHthjs17YVDaw0ECYToCHhfivz2CieyoRb/mdFLagAen7CNams4Aym3qPUGNGKkoSfRpZcvE39zrGC4ufjAhlbs5ox6NLneizwAS529IEY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742817087; c=relaxed/simple; bh=66iKtCroS+wUxpRA2gMU25wN8Ri0QuCTAm5ya+VinMY=; h=From:Subject:Date:Message-Id:MIME-Version:Content-Type:To:Cc; b=rj9HxlefNM9hQZD0AqanTa4K7PjLUeeAk/pI8l65VyIylV8SK2IrmTz5u3MkcMsDoTO7+G+RQtmph3CO6VuA6CIC8ILtJCNb0iGaeoF3Fe9rJgfEjH73kmuw9vsriM9e/r0e+g/ukbiG/0C5SkUWLj7ZRZcHxk+8jL0Gynz2Vw0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=V4rCg6EY; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="V4rCg6EY" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 52O9PNdi002610 for ; Mon, 24 Mar 2025 11:51:24 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:message-id :mime-version:subject:to; s=qcppdkim1; bh=HHHT+h2di88Hnsl4xAfhOo ua3p6DucIksRCHqcJkWEM=; b=V4rCg6EYFROlD5m3BJXIoTh++HFyBLwwUYQvJM ejGltDmwp7wU+WUjgeog6cw2CIEQxWiBpzzvMsKc5r/xo3GtPQ5StrQA58O1syWX B23ux4YsrajS5JUWN3t1DfezECNYiQhMeZoa+LKVDmg2BLvK5Y2Ihew+x3FEQ5yu aHrTNXVXvtZdSkUW9W7A04UpDmN+FhGaH5n2sUqtw0ekW1MiqgrfwNEogYPQJRyn LDttiBjeaiarlMYxwn8fTxx/nzs3r9pgUofhjzNpykXUfPHTHtjW/rrfgdJmRM5N UxoNP7On5YycpNBATG1gJNOUcsi0JMt+T5fF5Qnd5FEJFdQQ== Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 45hmhk491a-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Mon, 24 Mar 2025 11:51:24 +0000 (GMT) Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-6e917965e3eso58857036d6.3 for ; Mon, 24 Mar 2025 04:51:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742817084; x=1743421884; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=HHHT+h2di88Hnsl4xAfhOoua3p6DucIksRCHqcJkWEM=; b=NXP10n9+K4wF4qh8W/tapEJRqeko7B4sECAFsNKu13DqK6T6VGBrg6IXkBb/Kp77FI 9F7yqFSdlRelz0CipiWqnkNEwDP2jUrydyfexRi5tAc6o+qcS+Zn1TJDttgUgJG7zzfh HNpt115xuvFnlqtlUqyksZ01RI9ONfts6ybNMZicmk++xXE77Bx8SPlgTZC7wvOJIuMf pA6jH2cVfOC1QfrZaFTOkyQSRr3PXY8llCpuo5o9pazrwCx+0zvPLJTblZncYpb4wVxy KshhHe+ORcbwnLXzo3iQzUfaZ+S1MVVfth/Xs8z+6HVbY95uAVCfe2Bh+VBcJgeAjWiv xZlQ== X-Forwarded-Encrypted: i=1; AJvYcCX09ATqEHmUJTHYThYjEnPknN5kHCAKm2mAUAMqIBbVdQeFwKg6oFqEjNxmh0mNI2irxeJftGsDRVZtz5Yy@vger.kernel.org X-Gm-Message-State: AOJu0YzLuOfPq03KBtg2w3Mk6BtDfV0pH480Y+qJq969nZ5khMEVdp0X kKoNEO7oHZdL6CeR4fCgVvjmTUuLlD4vcm3K4L92coVuyp6vQ6q5gf+D/RqNduR8h/8zQZkzafq LeXqOpjbJGongpHHLYaaJzAzZKsFeDQbmFiCv9HnZ8jC+rfoXCDpCId7+KedGzwxL X-Gm-Gg: ASbGncsoS0aAtNr5qTZHqjyMbTlv9w3NrobLpd1MYzh4EDigyGoGW1jrnB08+2qwEs1 Iom3UGb0vUHmFrtMipq30xcggpAzMvHbChx1hf1xa/wSisuK47Kpp3gUqzJdjUZRtBk5HM6S5Vw 6VU6MEM1d+g69HgEv6Z530jo8WzHM265kO+QTFSZN+GglWspiCu163zb6ECDgl1H32YZEWI7f6y zHA3tHOTaYA5oNnSIFlw3/rY5vBAfrMrSEowBO+uu1jX1BfbTe1weTTfcsD1Z8WIhKVZZANzI/1 bSL/n0VTL9M10CCQK6xuJqICAkqPiFuCV0twBAH6y8dwEiVm15J5p9bxtl/qMMaPO1MQ2JeUN6e V6qdFQWscYrp1AzotPMk390QDCB7p X-Received: by 2002:a05:6214:da4:b0:6d3:fa03:23f1 with SMTP id 6a1803df08f44-6eb3f2939ddmr188499386d6.13.1742817083570; Mon, 24 Mar 2025 04:51:23 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGj36F0l6G1JaL0ogDw4h1JCUGq+59PIS80e7WBjTosUk6vT7x5Yv8yf3mUz+pC+Do4mi+8+Q== X-Received: by 2002:a05:6214:da4:b0:6d3:fa03:23f1 with SMTP id 6a1803df08f44-6eb3f2939ddmr188498636d6.13.1742817083013; Mon, 24 Mar 2025 04:51:23 -0700 (PDT) Received: from umbar.lan (2001-14ba-a0c3-3a00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a0c3:3a00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-54ad64fbb51sm1142907e87.135.2025.03.24.04.51.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Mar 2025 04:51:22 -0700 (PDT) From: Dmitry Baryshkov Subject: [RFC PATCH RESEND v4 0/6] drm/display: dp: add new DPCD access functions Date: Mon, 24 Mar 2025 13:51:18 +0200 Message-Id: <20250324-drm-rework-dpcd-access-v4-0-e80ff89593df@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 To: Lyude Paul , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Clark , Abhinav Kumar , Sean Paul , Marijn Suijten , Jani Nikula , Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Xinliang Liu , Tian Tao , Xinwei Kong , Sumit Semwal , Yongqin Liu , John Stultz Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, Dmitry Baryshkov , Jani Nikula X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2996; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=66iKtCroS+wUxpRA2gMU25wN8Ri0QuCTAm5ya+VinMY=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBn4Uc3j8hi7hRD+ymVE4ZaY94BaAKhBUU1YaVP5 QlAqLvMy6qJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCZ+FHNwAKCRCLPIo+Aiko 1U5YB/9Er45q0Cnmx/cxb3wpGStaZkp9jILfFprTtlgc8IQjnhjovAuz7jPIFzspv+9BxGb6eAy 2OTUyjJYJjwATk57dZEQGENUMO/pDgokQOAOMSYQWWxs04ePJT7go3UnR5U86af59Gwkv/Gt+ls 0svFOWah1z9cXpJU3rvAeaXJyDTnSuGd3ayHHGofSOl7NBh2ZxZl1ZQKSC7QvCNx4urQJGoF19U OqQRqsC80zHDKJaSoLr/hsgjm81s9ydm6e9Flq65OSSlMpOvl0rkwrD+1oMo2jA83or8sDX2uMz TVfNVZ4bRb9Dzu/NTuJq9gOHchEx1jJ3G0iu0IjlkA/NAAQB X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Authority-Analysis: v=2.4 cv=C4PpyRP+ c=1 sm=1 tr=0 ts=67e1473c cx=c_pps a=7E5Bxpl4vBhpaufnMqZlrw==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Vs1iUdzkB0EA:10 a=VwQbUJbxAAAA:8 a=KKAkSRfTAAAA:8 a=EUspDBNiAAAA:8 a=BDmTPyut6bhdKis1t5QA:9 a=QEXdDO2ut3YA:10 a=pJ04lnu7RYOZP9TFuWaZ:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-GUID: 1Fdas6cCWCufbMkS-SFtIZLwIY-hy8_o X-Proofpoint-ORIG-GUID: 1Fdas6cCWCufbMkS-SFtIZLwIY-hy8_o X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1093,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-03-24_04,2025-03-21_01,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 mlxscore=0 phishscore=0 mlxlogscore=999 priorityscore=1501 impostorscore=0 bulkscore=0 clxscore=1015 spamscore=0 malwarescore=0 suspectscore=0 lowpriorityscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2502280000 definitions=main-2503240086 Existing DPCD access functions return an error code or the number of bytes being read / write in case of partial access. However a lot of drivers either (incorrectly) ignore partial access or mishandle error codes. In other cases this results in a boilerplate code which compares returned value with the size. As suggested by Jani implement new set of DPCD access helpers, which ignore partial access, always return 0 or an error code. Implement new helpers using existing functions to ensure backwards compatibility and to assess necessity to handle incomplete reads on a global scale. Currently only one possible place has been identified, dp-aux-dev, which needs to handle possible holes in DPCD. This series targets only the DRM helpers code. If the approach is found to be acceptable, each of the drivers should be converted on its own. Signed-off-by: Dmitry Baryshkov --- Changes in v4: - Actually dropped the dp-aux-dev patch (Lyude). - Added two missing full stops in linuxdoc (Lyude). - Link to v3: https://lore.kernel.org/r/20250307-drm-rework-dpcd-access-v3-0-9044a3a868ee@linaro.org Changes in v3: - Fixed cover letter (Jani) - Added intel-gfx and intel-xe to get the series CI-tested (Jani) - Link to v2: https://lore.kernel.org/r/20250301-drm-rework-dpcd-access-v2-0-4d92602fc7cd@linaro.org Changes in v2: - Reimplemented new helpers using old ones (Lyude) - Reworked the drm_dp_dpcd_read_link_status() patch (Lyude) - Dropped the dp-aux-dev patch (Jani) - Link to v1: https://lore.kernel.org/r/20250117-drm-rework-dpcd-access-v1-0-7fc020e04dbc@linaro.org --- Dmitry Baryshkov (6): drm/display: dp: implement new access helpers drm/display: dp: change drm_dp_dpcd_read_link_status() return value drm/display: dp: use new DCPD access helpers drm/display: dp-cec: use new DCPD access helpers drm/display: dp-mst-topology: use new DCPD access helpers drm/display: dp-tunnel: use new DCPD access helpers drivers/gpu/drm/amd/amdgpu/atombios_dp.c | 8 +- .../gpu/drm/bridge/cadence/cdns-mhdp8546-core.c | 2 +- drivers/gpu/drm/display/drm_dp_cec.c | 37 ++- drivers/gpu/drm/display/drm_dp_helper.c | 307 +++++++++------------ drivers/gpu/drm/display/drm_dp_mst_topology.c | 105 ++++--- drivers/gpu/drm/display/drm_dp_tunnel.c | 20 +- drivers/gpu/drm/hisilicon/hibmc/dp/dp_link.c | 4 +- drivers/gpu/drm/msm/dp/dp_ctrl.c | 24 +- drivers/gpu/drm/msm/dp/dp_link.c | 18 +- drivers/gpu/drm/radeon/atombios_dp.c | 8 +- include/drm/display/drm_dp_helper.h | 92 +++++- 11 files changed, 317 insertions(+), 308 deletions(-) --- base-commit: b0894e40afe2bd05d1fda68cc364665ac2b00e09 change-id: 20241231-drm-rework-dpcd-access-b0fc2e47d613 Best regards,