| Message ID | 20250321135854.1431375-1-ivo.ivanov.ivanov1@gmail.com |
|---|---|
| Headers | show |
| Series | phy: samsung: add Exynos2200 SNPS eUSB2 driver | expand |
On 3/21/25 16:15, Dmitry Baryshkov wrote: > On Fri, Mar 21, 2025 at 03:58:47PM +0200, Ivaylo Ivanov wrote: >> As not only Qualcomm, but also Samsung is using the Synopsys eUSB2 IP >> (albeit with a different register layout) in their newer SoCs, move the >> driver out of its vendor sub-directory and rename it to phy-snps-eusb2. >> >> Signed-off-by: Ivaylo Ivanov <ivo.ivanov.ivanov1@gmail.com> >> Suggested-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Please fix the order of the tags. SoB should come after Suggested-by > (and usually it is the last one). Hm? I haven't had issues with SoB at the top in the past. > >> --- >> drivers/phy/Kconfig | 8 ++++++++ >> drivers/phy/Makefile | 1 + >> .../{qualcomm/phy-qcom-snps-eusb2.c => phy-snps-eusb2.c} | 0 >> drivers/phy/qualcomm/Kconfig | 9 --------- >> drivers/phy/qualcomm/Makefile | 1 - >> 5 files changed, 9 insertions(+), 10 deletions(-) >> rename drivers/phy/{qualcomm/phy-qcom-snps-eusb2.c => phy-snps-eusb2.c} (100%) > With that fixed: > > > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com> Thanks! Best regards, Ivaylo > >
On Fri, Mar 21, 2025 at 03:58:49PM +0200, Ivaylo Ivanov wrote: > The current phy init consists of hardware power-up, as well as > QCOM-specific eUSB2 init code. Split it into two parts, to make room > for such non-QCOM init code. > > Signed-off-by: Ivaylo Ivanov <ivo.ivanov.ivanov1@gmail.com> > --- > drivers/phy/phy-snps-eusb2.c | 96 +++++++++++++++++++++++------------- > 1 file changed, 63 insertions(+), 33 deletions(-) > > @@ -378,6 +401,11 @@ static int snps_eusb2_hsphy_probe(struct platform_device *pdev) > if (!phy) > return -ENOMEM; > > + drv_data = of_device_get_match_data(dev); > + if (!drv_data) > + return -EINVAL; > + phy->data = drv_data; Nit and completely bikeshedding, but this looks simpler: phy->data = of_device_get_match_data(dev); if (!phy->data) return -EINVAL; Anyway: Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com> > + > phy->base = devm_platform_ioremap_resource(pdev, 0); > if (IS_ERR(phy->base)) > return PTR_ERR(phy->base); > @@ -424,8 +452,10 @@ static int snps_eusb2_hsphy_probe(struct platform_device *pdev) > } > > static const struct of_device_id snps_eusb2_hsphy_of_match_table[] = { > - { .compatible = "qcom,sm8550-snps-eusb2-phy", }, > - { }, > + { > + .compatible = "qcom,sm8550-snps-eusb2-phy", > + .data = &sm8550_snps_eusb2_phy, > + }, { }, > }; > MODULE_DEVICE_TABLE(of, snps_eusb2_hsphy_of_match_table); > > -- > 2.43.0 >
On Fri, Mar 21, 2025 at 03:58:53PM +0200, Ivaylo Ivanov wrote: > The Exynos2200 SoC reuses the Synopsis eUSB2 PHY IP, alongside an > external repeater, for USB 2.0. Add support for it to the existing > driver, while keeping in mind that it requires enabled more than the > reference clock. > > Signed-off-by: Ivaylo Ivanov <ivo.ivanov.ivanov1@gmail.com> > --- > drivers/phy/Kconfig | 2 +- > drivers/phy/phy-snps-eusb2.c | 162 ++++++++++++++++++++++++++++++++++- > 2 files changed, 159 insertions(+), 5 deletions(-) > Acked-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
On Fri, Mar 21, 2025 at 03:58:45PM +0200, Ivaylo Ivanov wrote: > description: > - eUSB2 controller supports LS/FS/HS usb connectivity on Qualcomm chipsets. > + eUSB2 controller supports LS/FS/HS usb connectivity. > > properties: > compatible: > @@ -23,6 +23,7 @@ properties: > - qcom,x1e80100-snps-eusb2-phy > - const: qcom,sm8550-snps-eusb2-phy > - const: qcom,sm8550-snps-eusb2-phy > + - const: samsung,exynos2200-snps-eusb2-phy These two entries is just an enum. > > reg: > maxItems: 1 > @@ -31,12 +32,12 @@ properties: > const: 0 > > clocks: > - items: > - - description: ref > + minItems: 1 > + maxItems: 3 I am still not conviced that creating one schema for these devices brings benefits. If this is going to be one binding, then keep the list here with three items and add minItems, so the list is the same for all variants. > > clock-names: > - items: > - - const: ref > + minItems: 1 > + maxItems: 3 Keep the list here with three items and add minItems. > > resets: > maxItems: 1 > @@ -62,7 +63,52 @@ required: > - clock-names > - vdd-supply > - vdda12-supply > - - resets > + > +allOf: > + - if: > + properties: > + compatible: > + contains: > + enum: > + - qcom,sm8550-snps-eusb2-phy > + > + then: > + properties: > + reg: > + maxItems: 1 Not much improved, my comment is still valid. > + > + clocks: > + items: > + - description: ref maxItems: 1 > + > + clock-names: > + items: > + - const: ref maxItems: 1 > + > + required: > + - resets > + > + - if: > + properties: > + compatible: > + contains: > + enum: > + - samsung,exynos2200-snps-eusb2-phy > + > + then: > + properties: > + Drop blank line. and the clocks get here minItems: 3 Best regards, Krzysztof
Hey folks, This patchset adds Exynos2200 support to the existing eUSB2 phy driver, as well as USBDRD support for that SoC. The SoC features the same (as far as I can tell from comparing code) USBDRD 3.2 4nm block that Exynos2400 has, hence the common denominator. It consists of a SEC USB link controller, Synopsys eUSB2 and Synopsys USBDP combophy, which are independent underlying hardware blocks of the USBDRD controller. In the vendor kernel, everything is handled in the usbdrd controller driver, with helpers for underlying hardware block functions outside it. Clocks and regulators are specified and enabled in one node, which makes it difficult to separate what clocks and regulators go where without access to schematics or TRMs. The following gates are defined for USB: CLK_BLK_HSI0_UID_USB32DRD_IPCLKPORT_I_USBSUBCTL_APB_PCLK CLK_BLK_HSI0_UID_USB32DRD_IPCLKPORT_I_USBDPPHY_CTRL_PCLK CLK_BLK_HSI0_UID_USB32DRD_IPCLKPORT_I_USBDPPHY_TCA_APB_CLK CLK_BLK_HSI0_UID_USB32DRD_IPCLKPORT_I_USBLINK_ACLK CLK_BLK_HSI0_UID_USB32DRD_IPCLKPORT_I_USB32DRD_REF_CLK_40 CLK_BLK_HSI0_UID_USB32DRD_IPCLKPORT_I_EUSB_CTRL_PCLK CLK_BLK_HSI0_UID_USB32DRD_IPCLKPORT_I_EUSB_APB_CLK CLK_BLK_HSI0_UID_AS_APB_EUSBPHY_HSI0_IPCLKPORT_PCLKM CLK_BLK_HSI0_UID_RSTNSYNC_CLK_HSI0_EUSB_IPCLKPORT_CLK The vendor kernel specifies 4 regulators, 2 of which are for eUSB and the other 2 for the repeater. The rest of the PHYs and the dwc3 controller are on a single power domain (hsi0), so they're most likely sharing power rails. As Qualcomm is also using the eUSB2 IP, the approach taken here is to rename the driver so that it can be used by other SoC vendors as well while keeping compatibles SoC-vendor prefixed (different vendors have different implementations of the IP with different register maps), add support for exynos2200 in it and implement support for exynos2200 in the existing exynos5-usbdrd driver (with link controller init). A new USBDP driver will be added later on, so that super-speed can be configured. Bindings have been tested: $ make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- -j4 dt_binding_check DT_SCHEMA_FILES="Documentation/devicetree/bindings/phy/snps,eusb2-phy.yaml" CHKDT ./Documentation/devicetree/bindings LINT ./Documentation/devicetree/bindings DTC [C] Documentation/devicetree/bindings/phy/snps,eusb2-phy.example.dtb Best regards, Ivaylo Changes in v3: USBCON changes: - drop the driver and introduce it all in existing exynos5-usbdrd driver EUSB2 changes: - split changes into multiple commits with clear diff - add a commit to do table-based lookup for refclk - clean up here and there - correct the cover letter according to my new knowledge of how the hardware functions - change commit message of the optional repeater patch Changes in v2: USBCON changes: - drop unused header includes - sanitize the binding - proper init and exit power management - shorten some variables - unrelax reads and writes - update commit description - remodel to take other phys - drop specified regulators as these are for the repeater - make the kconfig description better - general cleanup EUSB2 changes: - merge the previous separate driver into the qualcomm one - drop the previous model of taking usbcon phandle Ivaylo Ivanov (10): dt-bindings: phy: add exynos2200 eusb2 phy support dt-bindings: phy: samsung,usb3-drd-phy: add exynos2200 support phy: move phy-qcom-snps-eusb2 out of its vendor sub-directory phy: phy-snps-eusb2: refactor constructs names phy: phy-snps-eusb2: split phy init code phy: phy-snps-eusb2: make repeater optional phy: phy-snps-eusb2: make reset control optional phy: phy-snps-eusb2: refactor reference clock init phy: phy-snps-eusb2: add support for exynos2200 phy: exynos5-usbdrd: support Exynos USBDRD 3.2 4nm controller .../bindings/phy/samsung,usb3-drd-phy.yaml | 38 +- ...nps-eusb2-phy.yaml => snps,eusb2-phy.yaml} | 62 +- drivers/phy/Kconfig | 8 + drivers/phy/Makefile | 1 + drivers/phy/phy-snps-eusb2.c | 629 ++++++++++++++++++ drivers/phy/qualcomm/Kconfig | 9 - drivers/phy/qualcomm/Makefile | 1 - drivers/phy/qualcomm/phy-qcom-snps-eusb2.c | 442 ------------ drivers/phy/samsung/phy-exynos5-usbdrd.c | 227 ++++++- include/linux/soc/samsung/exynos-regs-pmu.h | 3 + 10 files changed, 941 insertions(+), 479 deletions(-) rename Documentation/devicetree/bindings/phy/{qcom,snps-eusb2-phy.yaml => snps,eusb2-phy.yaml} (59%) create mode 100644 drivers/phy/phy-snps-eusb2.c delete mode 100644 drivers/phy/qualcomm/phy-qcom-snps-eusb2.c