| Message ID | 20250321-sm6350-videocc-v1-0-c5ce1f1483ee@fairphone.com |
|---|---|
| Headers | show |
| Series | Add video clock controller for SM6350 | expand |
On Fri Mar 21, 2025 at 4:55 PM CET, Dmitry Baryshkov wrote: > On Fri, Mar 21, 2025 at 03:45:00PM +0100, Luca Weiss wrote: >> From: Konrad Dybcio <konradybcio@kernel.org> >> >> Add support for the video clock controller found on SM6350 based >> devices. >> >> Signed-off-by: Konrad Dybcio <konradybcio@kernel.org> >> Co-developed-by: Luca Weiss <luca.weiss@fairphone.com> >> Signed-off-by: Luca Weiss <luca.weiss@fairphone.com> >> --- >> drivers/clk/qcom/Kconfig | 9 + >> drivers/clk/qcom/Makefile | 1 + >> drivers/clk/qcom/videocc-sm6350.c | 355 ++++++++++++++++++++++++++++++++++++++ >> 3 files changed, 365 insertions(+) >> >> + >> +/* 600 MHz */ >> +static const struct alpha_pll_config video_pll0_config = { >> + .l = 0x1F, > > Nit: lowercase hex please. No need to repost just for the sake of this > single line. Sounds like there'll be a v2 anyways with dts changes, so I'll fix it! Regards Luca > > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com> > > >> + .alpha = 0x4000, >> + .config_ctl_val = 0x20485699, >> + .config_ctl_hi_val = 0x00002067, >> + .test_ctl_val = 0x40000000, >> + .test_ctl_hi_val = 0x00000002, >> + .user_ctl_val = 0x00000101, >> + .user_ctl_hi_val = 0x00004005, >> +}; >> + >>
The driver for the SM6350 videocc has been lying around in some branches of my git tree for a long time, let's upstream it. It doesn't get any better by letting it age! Signed-off-by: Luca Weiss <luca.weiss@fairphone.com> --- Konrad Dybcio (2): dt-bindings: clock: add SM6350 QCOM video clock bindings clk: qcom: Add video clock controller driver for SM6350 Luca Weiss (1): arm64: dts: qcom: sm6350: Add video clock controller .../devicetree/bindings/clock/qcom,videocc.yaml | 20 ++ arch/arm64/boot/dts/qcom/sm6350.dtsi | 14 + drivers/clk/qcom/Kconfig | 9 + drivers/clk/qcom/Makefile | 1 + drivers/clk/qcom/videocc-sm6350.c | 355 +++++++++++++++++++++ include/dt-bindings/clock/qcom,sm6350-videocc.h | 27 ++ 6 files changed, 426 insertions(+) --- base-commit: 73b8c1dbc2508188e383023080ce6a582ff5f279 change-id: 20250321-sm6350-videocc-6ecdb9ab2756 Best regards,