| Message ID | 20250121180746.1989996-1-quic_vikramsa@quicinc.com |
|---|---|
| Headers | show |
| Series | Update clocks for sc7280-camss | expand |
On 21/01/2025 18:07, Vikram Sharma wrote: > Update clock names to make them consistent with existing platform i.e > qcom,sc8280xp-camss.yaml. Rename gcc_cam_hf_axi to gcc_axi_hf and add > gcc_axi_sf. > > gcc_camera_ahb is always on and we don't need to enable it explicitly. > gcc_axi_sf is added to avoid unexpected hardware behaviour. > > This change will not break ABI because the ABI hasn't been cemented yet as > the dtsi changes are not merged yet and there are no users for this driver > as of now. > > Signed-off-by: Vikram Sharma <quic_vikramsa@quicinc.com> > --- > .../devicetree/bindings/media/qcom,sc7280-camss.yaml | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/Documentation/devicetree/bindings/media/qcom,sc7280-camss.yaml b/Documentation/devicetree/bindings/media/qcom,sc7280-camss.yaml > index e11141b812a0..ee35e3bc97ff 100644 > --- a/Documentation/devicetree/bindings/media/qcom,sc7280-camss.yaml > +++ b/Documentation/devicetree/bindings/media/qcom,sc7280-camss.yaml > @@ -55,8 +55,8 @@ properties: > - const: csiphy3_timer > - const: csiphy4 > - const: csiphy4_timer > - - const: gcc_camera_ahb > - - const: gcc_cam_hf_axi > + - const: gcc_axi_hf > + - const: gcc_axi_sf > - const: icp_ahb > - const: vfe0 > - const: vfe0_axi > @@ -310,8 +310,8 @@ examples: > <&camcc CAM_CC_CSI3PHYTIMER_CLK>, > <&camcc CAM_CC_CSIPHY4_CLK>, > <&camcc CAM_CC_CSI4PHYTIMER_CLK>, > - <&gcc GCC_CAMERA_AHB_CLK>, > <&gcc GCC_CAMERA_HF_AXI_CLK>, > + <&gcc GCC_CAMERA_SF_AXI_CLK>, > <&camcc CAM_CC_ICP_AHB_CLK>, > <&camcc CAM_CC_IFE_0_CLK>, > <&camcc CAM_CC_IFE_0_AXI_CLK>, > @@ -343,8 +343,8 @@ examples: > "csiphy3_timer", > "csiphy4", > "csiphy4_timer", > - "gcc_camera_ahb", > - "gcc_cam_hf_axi", > + "gcc_axi_hf", > + "gcc_axi_sf", > "icp_ahb", > "vfe0", > "vfe0_axi", Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Update clock names as follow-up change for series. https://lore.kernel.org/linux-arm-msm/20241206191900.2545069-1-quic_vikramsa@quicinc.com/ We have got comments on our dtsi change to update clock names as - GCC_CAMERA_AHB_CLK is always enabled clock so it can be removed. - Change clock name from gcc_cam_hf_axi to `gcc_axi_hf` for consistency. - Add gcc_axi_sf as missing to enable it can have undefined hw behaviour. To handle these comments in our base series we need to update documentaion and driver (already merged) to work with dtsi. We are not breaking ABI here because the ABI hasn't been cemented yet as the dtsi changes are not merged yet also there are no users for this driver as of now. Used following tools for the sanity check of these changes. - make CHECK_DTBS=y W=1 DT_SCHEMA_FILES=media/qcom,sc7280-camss.yaml - make DT_CHECKER_FLAGS=-m W=1 DT_SCHEMA_FILES=media/qcom,sc7280-camss.yaml dt_binding_check - make -j32 W=1 - ./scripts/checkpatch.pl Changes in V2: - Updated commit text to explain the reason behind this change. - Updated commit text to use imperative mood. - Updated commit text to utilize 75 character limit properly. - Link to v1: https://lore.kernel.org/linux-arm-msm/20250121120901.1841142-1-quic_vikramsa@quicinc.com/ Signed-off-by: Vikram Sharma <quic_vikramsa@quicinc.com> Vikram Sharma (2): media: dt-bindings: update clocks for sc7280-camss media: qcom: camss: update clock names for sc7280 .../bindings/media/qcom,sc7280-camss.yaml | 10 +++++----- drivers/media/platform/qcom/camss/camss.c | 15 ++++++++++----- 2 files changed, 15 insertions(+), 10 deletions(-)