| Message ID | 20250121-dts_qcs615-v3-0-fa4496950d8a@quicinc.com |
|---|---|
| Headers | show |
| Series | Enable ethernet on qcs615 | expand |
On Tue, 21 Jan 2025 15:54:53 +0800 Yijie Yang <quic_yijiyang@quicinc.com> wrote: > Correct the definition of 'phy-mode' to reflect that RX and TX delays are > added by the board, not the MAC, to prevent confusion and ensure accurate > documentation. That's not entirely correct though. The purpose of the RGMII variants (TXID, RXID, ID) are mostly to know whether or not the PHY must add internal delays. That would be when the MAC can't AND there's no PCB delay traces. Some MAC can insert delays. There's documentation here as well on that point : https://elixir.bootlin.com/linux/v6.13-rc3/source/Documentation/networking/phy.rst#L82 So, MACs may insert delays. A modification for the doc, if needed, would rather be : - # RX and TX delays are added by the MAC when required + # RX and TX delays are added by the MAC or PCB traces when required Thanks, Maxime
Correct the definition and usage of phy-mode in both the DT binding and driver code. Add dts nodes and EMAC driver data to enable ethernet interface on qcs615-ride platform. The EMAC version currently in use on this platform is the same as that in qcs404. The EPHY model is Micrel KSZ9031. Signed-off-by: Yijie Yang <quic_yijiyang@quicinc.com> --- Changes in v3: - Correct the definition of 'rgmii' in ethernet-controller.yaml. - Remove the redundant max-speed limit in the dts file. - Update the definition of 'rgmii' to prevent any further misunderstandings. - Update the phy-mode in the dts file from rgmii to rgmii-id. - Mask the PHY mode passed to the driver to allow the MAC to add the delay. - Update the low power mode exit interrupt from 662 to 661. - Update the compatible string to fallback to qcs404 since they share the same hardware. - Update base commit to next-20250120. - Link to v2: https://lore.kernel.org/r/20241118-dts_qcs615-v2-0-e62b924a3cbd@quicinc.com --- Yijie Yang (4): dt-bindings: net: ethernet-controller: Correct the definition of phy-mode net: stmmac: dwmac-qcom-ethqos: Mask PHY mode if configured with rgmii-id arm64: dts: qcom: qcs615: add ethernet node arm64: dts: qcom: qcs615-ride: Enable ethernet node .../bindings/net/ethernet-controller.yaml | 2 +- arch/arm64/boot/dts/qcom/qcs615-ride.dts | 104 +++++++++++++++++++++ arch/arm64/boot/dts/qcom/qcs615.dtsi | 34 +++++++ .../ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c | 18 +++- 4 files changed, 152 insertions(+), 6 deletions(-) --- base-commit: 9424d9acada6461344c71ac02f2f3fbcdd775498 change-id: 20241224-dts_qcs615-9612efea02cb prerequisite-message-id: <20250120-schema_qcs615-v4-1-d9d122f89e64@quicinc.com> prerequisite-patch-id: b97f36116c87036abe66e061db82588eb1bbaa9a Best regards,