From patchwork Wed Dec 25 13:35:07 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Depeng Shao X-Patchwork-Id: 853490 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E7CFB1804E; Wed, 25 Dec 2024 13:35:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735133751; cv=none; b=fWFeFvTCGNNEpp4d6/Q0Zrvs+eqiKhhsP+tEQrz5gkeMov1d8vG2LnwW9tDmZJQGsMUYCl//eQfJtrSHOcKJDd+9ZxLM36Pcx58MjepyMLN6kfLU0eOpNVu0jSXHGkBOp+m4tuEEMF+HA3edu8epJaJr/tCVGiRCb3uUzE65YKg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735133751; c=relaxed/simple; bh=1JQgNf6XS7hDtdX8zNoUqbaSCkMJIi2rCxERE6ygeo8=; h=From:To:CC:Subject:Date:Message-ID:MIME-Version:Content-Type; b=nefw8fXdpohoyldlTlo8H0ptTax16H3ijgL1WAzTE8fi8o9HN5mhjFPo6wgdakp/p7nV6od7NZ1UBEf+Hp2bZDiezJ7iBTQLAcrXBFrC69dGAQoy343q5UzNlFy17T3NkT2MIakF0GbLsEfRZOyYoXK4PVZi7LY6nT7N3aMWsho= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com; spf=pass smtp.mailfrom=quicinc.com; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b=VX59sONQ; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=quicinc.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="VX59sONQ" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4BPDPcab004733; Wed, 25 Dec 2024 13:35:44 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= cc:content-transfer-encoding:content-type:date:from:message-id :mime-version:subject:to; s=qcppdkim1; bh=XoSTrjSpDycHKG6GATUchA E3zzuVFbd/RRJiqZCfWNA=; b=VX59sONQeywoEQkKR9SnHF5XMzEeLaybTuTjyE yg+5TTZEAVMjIq82pne3Biqb9ta9FGkO6gPsWTPYZwLmSQ1X4sYIINxRB07NDQCX Z6TGZATk1fq22ToBwfXu7J8g94afEUblI7DPIXuQNoqOlJ670fPA73Gd96HPkQhF exGWpAymGSrmjOiR6F+Gvcw3ns08WalY9yI0arwdmw79CqhvuCdQ0vO2Av3t1iDq I4GI4zvIfRru/AzJTtD+IMen394dHqNSjz28bGKwHpgtpRHN/UagzaHk/+ZVnnb0 tY3MKNeXOaroB76iTSj3wL/EnwqxPkWq8ViClCXM2JOAQI+w== Received: from nasanppmta01.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 43rdqmrwg3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 25 Dec 2024 13:35:44 +0000 (GMT) Received: from nasanex01b.na.qualcomm.com (nasanex01b.na.qualcomm.com [10.46.141.250]) by NASANPPMTA01.qualcomm.com (8.18.1.2/8.18.1.2) with ESMTPS id 4BPDZhPt014824 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 25 Dec 2024 13:35:44 GMT Received: from hu-depengs-sha.qualcomm.com (10.80.80.8) by nasanex01b.na.qualcomm.com (10.46.141.250) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Wed, 25 Dec 2024 05:35:37 -0800 From: Depeng Shao To: , , , , , , , CC: , , , , , , Subject: [PATCH v7 00/16] media: qcom: camss: Add sm8550 support Date: Wed, 25 Dec 2024 19:05:07 +0530 Message-ID: <20241225133523.4034820-1-quic_depengs@quicinc.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nasanex01b.na.qualcomm.com (10.46.141.250) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: K6Rw_k_fZ6WFHZKKTzJL8kdgUm3kPRBy X-Proofpoint-ORIG-GUID: K6Rw_k_fZ6WFHZKKTzJL8kdgUm3kPRBy X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-06_09,2024-09-06_01,2024-09-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 malwarescore=0 adultscore=0 clxscore=1015 phishscore=0 bulkscore=0 lowpriorityscore=0 mlxlogscore=999 impostorscore=0 suspectscore=0 priorityscore=1501 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2411120000 definitions=main-2412250120 v7: - Due to the patches in https://lore.kernel.org/all/20241217140656.965235-1-quic_vikramsa@quicinc.com/ are merged, so rebased below patches to fix the conflict. media: qcom: camss: csiphy-3ph: Remove redundant PHY init sequence control loop media: qcom: camss: csiphy-3ph: Move CSIPHY variables to data field inside csiphy struct media: qcom: camss: Add sm8550 compatible media: qcom: camss: csiphy-3ph: Move CSIPHY variables to data field inside csiphy struct media: qcom: camss: csiphy-3ph: Add Gen2 v2.1.2 two-phase MIPI CSI-2 DPHY support media: qcom: camss: Add support for VFE 780 - Add RB for "media: qcom: camss: Add CSID 780 support" - Bryan - Use TAG name for ICC and remove offline HW ICC - Bryan - Remove the logic that moving enable_irq();/disable_irq(); to wm_start() and wm_stop() to make sure no logical change in VFE refactor change. - Update the commit message and title for the TPG change. - Bryan - Link to v6: https://lore.kernel.org/all/20241211140738.3835588-1-quic_depengs@quicinc.com/ v6: - Add bus type property in dt-binding which will be limited by a latest change https://lore.kernel.org/all/20241209-camss-dphy-v1-0-5f1b6f25ed92@fairphone.com/ - Add RB for "media: qcom: camss: Add sm8550 compatible" and "media: qcom: camss: Add support for VFE 780" - Uppercase the hex in csiphy register list - Bryan - Add empty function for csid tpg - Vladimir - Set testgen mode to CSID_PAYLOAD_MODE_DISABLED in subdev init interface - encapsulate the guard __thus__ for new header - Bryan - Add a standalone patch for the platform which doesn't support CSID TPG to make sure new platform driver can set CSID_PAYLOAD_MODE_DISABLED to disable TPG - Update the csid for csid and vfe driver - Bryan - Link to v5: https://lore.kernel.org/all/20241205155538.250743-1-quic_depengs@quicinc.com/ v5: - Update dt-bindings required items order - Krzysztof - Sort the reg order based on the comments in sc7280 dt-binding - Vladimir - Change the irq type to IRQ_TYPE_EDGE_RISING - Vladimir - Remove the Krzysztof's RB tag from dt-binding patch due to above updates in dt-binding patch - Move regulator from csid resource to csiphy resource - Bryan, Vladimir - Move the change to add default case in vfe_src_pad_code to a standalone patch. - Bryan - Rename csid-gen3 as csid-780 - Bryan - use macros() to bury bit shifts - Bryan - Sort the macros by register offset order - Vladimir - Redefine a macro for rup_aup in csid driver - Vladimir - Remove the unused macros in vfe 780 driver - Vladimir - Add dummy function for unsupported hw_ops in vfe 780 driver - Vladimir, Bryan - Use a standalone patch for the callback API of RUP and buf done update - Use a standalone patch to make CSID TPG optional - Vladimir - Link to v4: https://lore.kernel.org/all/20240812144131.369378-1-quic_depengs@quicinc.com/ v4: - Update dt-bindings based on comments - Krzysztof, bod, Vladimir - Move common code into csid core and vfe core driver - bod - Remove *_relaxed in the csid and vfe drivers - Krzysztof - Reorganize patches in logical junks, make sure that new added structures have users in current patch - Krzysztof - Remove notify function and add new functions in camss for buf done and reg update - bod - Remove custom code to get csid base - bod - Remove ISR function in vfe780 driver since it is never fired - bod - Move csid_top_base to camss structure since we only have one csid top block, and just need to get base once for csid top - Add Vladimir's RB - Remove prerequisite-patch-id in the cover letter since the changes have been merged - Add dtsi patch link for reference - Krzysztof https://lore.kernel.org/all/20240807123333.2056518-1-quic_depengs@quicinc.com/ - Link to v3: https://lore.kernel.org/all/20240709160656.31146-1-quic_depengs@quicinc.com/ v3: - Rebased the change based on below change which will be merged firstly. "Move camss version related defs in to resources" Link: https://lore.kernel.org/all/20240522154659.510-1-quic_grosikop@quicinc.com/ - Rebased the change based on Bryan's csiphy optimization change and add these changes into this series, so that the new csiphy-3ph driver don't need to add duplicate code. This has got Bryan's permission to add his patches into this series. - Refactor some changes based on the comments to move the random code to patches where they are used. - Remove the vfe780 irq function since it isn't doing the actual work. - Add dt-binding for sm8550 camss driver. Link to V2: https://lore.kernel.org/all/20240320141136.26827-1-quic_depengs@quicinc.com/ v2: - Update some commit messages Link to V1: https://lore.kernel.org/all/20240320134227.16587-1-quic_depengs@quicinc.com/ v1: SM8550 is a Qualcomm flagship SoC. This series adds support to bring up the CSIPHY, CSID, VFE/RDI interfaces in SM8550. SM8550 provides - 3 x VFE, 3 RDI per VFE - 2 x VFE Lite, 4 RDI per VFE - 3 x CSID - 2 x CSID Lite - 8 x CSI PHY Bryan O'Donoghue (6): media: qcom: camss: csiphy-3ph: Fix trivial indentation fault in defines media: qcom: camss: csiphy-3ph: Remove redundant PHY init sequence control loop media: qcom: camss: csiphy-3ph: Rename struct media: qcom: camss: csiphy: Add an init callback to CSI PHY devices media: qcom: camss: csiphy-3ph: Move CSIPHY variables to data field inside csiphy struct media: qcom: camss: csiphy-3ph: Use an offset variable to find common control regs Depeng Shao (10): media: qcom: camss: csid: Move common code into csid core media: qcom: camss: vfe: Move common code into vfe core media: qcom: camss: Add callback API for RUP update and buf done media: qcom: camss: Add default case in vfe_src_pad_code media: qcom: camss: csid: Only add TPG v4l2 ctrl if TPG hardware is available dt-bindings: media: camss: Add qcom,sm8550-camss binding media: qcom: camss: Add sm8550 compatible media: qcom: camss: csiphy-3ph: Add Gen2 v2.1.2 two-phase MIPI CSI-2 DPHY support media: qcom: camss: Add CSID 780 support media: qcom: camss: Add support for VFE 780 .../bindings/media/qcom,sm8550-camss.yaml | 597 +++++++++++++ drivers/media/platform/qcom/camss/Makefile | 2 + .../platform/qcom/camss/camss-csid-4-1.c | 19 - .../platform/qcom/camss/camss-csid-4-7.c | 42 - .../platform/qcom/camss/camss-csid-780.c | 337 ++++++++ .../platform/qcom/camss/camss-csid-780.h | 25 + .../platform/qcom/camss/camss-csid-gen2.c | 60 -- .../media/platform/qcom/camss/camss-csid.c | 137 ++- .../media/platform/qcom/camss/camss-csid.h | 31 + .../qcom/camss/camss-csiphy-2ph-1-0.c | 6 + .../qcom/camss/camss-csiphy-3ph-1-0.c | 794 ++++++++++-------- .../media/platform/qcom/camss/camss-csiphy.c | 4 + .../media/platform/qcom/camss/camss-csiphy.h | 8 + .../media/platform/qcom/camss/camss-vfe-17x.c | 112 +-- .../media/platform/qcom/camss/camss-vfe-4-1.c | 9 - .../media/platform/qcom/camss/camss-vfe-4-7.c | 11 - .../media/platform/qcom/camss/camss-vfe-4-8.c | 11 - .../media/platform/qcom/camss/camss-vfe-480.c | 274 +----- .../media/platform/qcom/camss/camss-vfe-780.c | 159 ++++ drivers/media/platform/qcom/camss/camss-vfe.c | 274 ++++++ drivers/media/platform/qcom/camss/camss-vfe.h | 59 +- drivers/media/platform/qcom/camss/camss.c | 359 ++++++++ drivers/media/platform/qcom/camss/camss.h | 4 + 23 files changed, 2464 insertions(+), 870 deletions(-) create mode 100644 Documentation/devicetree/bindings/media/qcom,sm8550-camss.yaml create mode 100644 drivers/media/platform/qcom/camss/camss-csid-780.c create mode 100644 drivers/media/platform/qcom/camss/camss-csid-780.h create mode 100644 drivers/media/platform/qcom/camss/camss-vfe-780.c base-commit: 8155b4ef3466f0e289e8fcc9e6e62f3f4dceeac2