| Message ID | 20241025123227.3527720-1-quic_sibis@quicinc.com |
|---|---|
| Headers | show |
| Series | X1E001DE Snapdragon Devkit for Windows | expand |
On 25.10.24 14:32, Sibi Sankar wrote: > Add initial support for X1E001DE Snapdragon Devkit for Windows. X1E001DE > is the speed binned variant of X1E80100 that supports turbo boost up to > 4.3 Ghz. The initial support includes the following: > > -DSPs > -Ethernet (RTL8125BG) over the pcie 5 instance. > -NVme > -Wifi > -USB-C ports > > V3: > * Asked around and looked at the firmware, couldn't find a codename so > will keep it as DEVKIT. Will update it if someone from the community > finds something else. > * Update type c roles as reported by ucsi. [Dmitry] > * Update THUNDERCOMM to Thundercomm. [Dmitry] > * Update regulator names and sort Order. [Dmitry] > * Add x1e001DE devkit to the safe list. > * Mark regulator-nmve as boot enabled. > > > V2: > * Fix Ghz -> GHz [Jeff] > * Pick up Ab tag from Rob. > * Use Vendor in ADSP/CDSP firmware path [Dmitry] > * Fix reserved gpios [Dmitry] > * Only port0 supports DRD update the dt accordingly [Dmitry] > > Sibi Sankar (3): > dt-bindings: arm: qcom: Add Snapdragon Devkit for Windows > firmware: qcom: uefisecapp: Allow X1E Devkit devices > arm64: dts: qcom: Add X1E001DE Snapdragon Devkit for Windows > > .../devicetree/bindings/arm/qcom.yaml | 6 + > arch/arm64/boot/dts/qcom/Makefile | 1 + > arch/arm64/boot/dts/qcom/x1e001de-devkit.dts | 814 ++++++++++++++++++ > drivers/firmware/qcom/qcom_scm.c | 1 + > 4 files changed, 822 insertions(+) > create mode 100644 arch/arm64/boot/dts/qcom/x1e001de-devkit.dts > I have used this dt to bring up my Dev Kit, it is a great help. Thank you! - Jens link: https://github.com/jglathe/linux_ms_dev_kit/wiki/Bringing-up-the-SnapDragon-Dev-Kit-for-Windows-with-Linux-%E2%80%90-without-working-display Tested-by: Jens Glathe <jens.glathe@oldschoolsolutions.biz>
On Fri, 25 Oct 2024 13:32:24 +0100, Sibi Sankar <quic_sibis@quicinc.com> wrote: > > Add initial support for X1E001DE Snapdragon Devkit for Windows. X1E001DE > is the speed binned variant of X1E80100 that supports turbo boost up to > 4.3 Ghz. The initial support includes the following: > > -DSPs > -Ethernet (RTL8125BG) over the pcie 5 instance. > -NVme > -Wifi > -USB-C ports > > V3: > * Asked around and looked at the firmware, couldn't find a codename so > will keep it as DEVKIT. Will update it if someone from the community > finds something else. My machine has the following information as part of its DMI tables: Handle 0x0005, DMI type 1, 27 bytes System Information Manufacturer: Qualcomm Product Name: Snapdragon-Devkit Version: 2.1 Serial Number: 5 UUID: 63b5fc8b-9c50-89aa-fd0f-3fcef93dc291 Wake-up Type: Power Switch SKU Number: 6 Family: SCP_HAMOA So I guess that Snapdragon-Devkit is another possible name. But given that it is a bit of a mouthful, devkit, Devkit, or any other variation on the case would work for me. > * Update type c roles as reported by ucsi. [Dmitry] > * Update THUNDERCOMM to Thundercomm. [Dmitry] > * Update regulator names and sort Order. [Dmitry] > * Add x1e001DE devkit to the safe list. > * Mark regulator-nmve as boot enabled. > > > V2: > * Fix Ghz -> GHz [Jeff] > * Pick up Ab tag from Rob. > * Use Vendor in ADSP/CDSP firmware path [Dmitry] > * Fix reserved gpios [Dmitry] > * Only port0 supports DRD update the dt accordingly [Dmitry] > > Sibi Sankar (3): > dt-bindings: arm: qcom: Add Snapdragon Devkit for Windows > firmware: qcom: uefisecapp: Allow X1E Devkit devices > arm64: dts: qcom: Add X1E001DE Snapdragon Devkit for Windows > > .../devicetree/bindings/arm/qcom.yaml | 6 + > arch/arm64/boot/dts/qcom/Makefile | 1 + > arch/arm64/boot/dts/qcom/x1e001de-devkit.dts | 814 ++++++++++++++++++ > drivers/firmware/qcom/qcom_scm.c | 1 + > 4 files changed, 822 insertions(+) > create mode 100644 arch/arm64/boot/dts/qcom/x1e001de-devkit.dts FWIW, I'm running this as part of my KVM test rig with minor changes to expose the SMMU and allow the ITS on pcie5, and things work as well as you can expect. FWIW: Acked-by: Marc Zyngier <maz@kernel.org> Tested-by: Marc Zyngier <maz@kernel.org> M.
On 25.10.2024 2:32 PM, Sibi Sankar wrote: > Add initial support for x1e001de devkit platform. This includes: > > -DSPs > -Ethernet (RTL8125BG) over the pcie 5 instance. > -NVme > -Wifi > -USB-C ports > > Link: https://www.qualcomm.com/news/releases/2024/05/qualcomm-accelerates-development-for-copilot--pcs-with-snapdrago > Signed-off-by: Sibi Sankar <quic_sibis@quicinc.com> > --- [...] > + vreg_nvme: regulator-nvme { > + compatible = "regulator-fixed"; > + > + regulator-name = "VREG_NVME_3P3"; > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + > + gpio = <&tlmm 18 GPIO_ACTIVE_HIGH>; > + enable-active-high; > + > + pinctrl-names = "default"; > + pinctrl-0 = <&nvme_reg_en>; these are backwards otherwise lgtm Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> Konrad
On Fri, 25 Oct 2024 18:02:24 +0530, Sibi Sankar wrote: > Add initial support for X1E001DE Snapdragon Devkit for Windows. X1E001DE > is the speed binned variant of X1E80100 that supports turbo boost up to > 4.3 Ghz. The initial support includes the following: > > -DSPs > -Ethernet (RTL8125BG) over the pcie 5 instance. > -NVme > -Wifi > -USB-C ports > > [...] Applied, thanks! [2/3] firmware: qcom: uefisecapp: Allow X1E Devkit devices commit: 75837f0b2bc61c62c8326fe3a1eb9a100714cfd7 Best regards,