| Message ID | 20241018-qcs8300-mm-patches-v1-0-859095e0776c@quicinc.com |
|---|---|
| Headers | show |
| Series | Add support for GPUCC, CAMCC and VIDEOCC on Qualcomm QCS8300 platform | expand |
On Fri, Oct 18, 2024 at 04:42:29PM +0530, Imran Shaik wrote:
> Add support for qcom GPU clock controller bindings for QCS8300 platform.
Why are you adding defines to SA8775p header? Commit msg should explain
non-obvious contents.
Best regards,
Krzysztof
On 10/21/2024 11:46 PM, Rob Herring wrote: > On Fri, Oct 18, 2024 at 04:42:33PM +0530, Imran Shaik wrote: >> Add device tree bindings for the video clock controller on Qualcomm >> QCS8300 platform. > > That's obvious reading the diff. How is it different from the sa8775p > version? It must be different or you should have a fallback compatible. > The QCS8300 Video clock controller is mostly identical to SA8775P, but QCS8300 has minor difference. Hence, re-using the SA8775P VideoCC for QCS8300. I will update the commit text with the details and post next series. Thanks, Imran >> >> Signed-off-by: Imran Shaik <quic_imrashai@quicinc.com> >> --- >> Documentation/devicetree/bindings/clock/qcom,sa8775p-videocc.yaml | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/Documentation/devicetree/bindings/clock/qcom,sa8775p-videocc.yaml b/Documentation/devicetree/bindings/clock/qcom,sa8775p-videocc.yaml >> index 928131bff4c1..07e5d811d816 100644 >> --- a/Documentation/devicetree/bindings/clock/qcom,sa8775p-videocc.yaml >> +++ b/Documentation/devicetree/bindings/clock/qcom,sa8775p-videocc.yaml >> @@ -18,6 +18,7 @@ description: | >> properties: >> compatible: >> enum: >> + - qcom,qcs8300-videocc >> - qcom,sa8775p-videocc >> >> clocks: >> >> -- >> 2.25.1 >>
This patch series add support for GPUCC, CAMCC and VIDEOCC on Qualcomm QCS8300 platform. Please note that this series is dependent on [1] and [2], which adds support for QCS8300 GCC and SA8775P multi media clock controllers respectively. [1] https://lore.kernel.org/all/20240822-qcs8300-gcc-v2-0-b310dfa70ad8@quicinc.com/ [2] https://lore.kernel.org/all/20241011-sa8775p-mm-v4-resend-patches-v5-0-4a9f17dc683a@quicinc.com/ Signed-off-by: Imran Shaik <quic_imrashai@quicinc.com> --- Imran Shaik (6): dt-bindings: clock: qcom: Add GPU clocks for QCS8300 clk: qcom: Add support for GPU Clock Controller on QCS8300 dt-bindings: clock: qcom: Add CAMCC clocks for QCS8300 clk: qcom: Add support for Camera Clock Controller on QCS8300 dt-bindings: clock: qcom: Add QCS8300 video clock controller clk: qcom: Add support for Video Clock Controller on QCS8300 .../devicetree/bindings/clock/qcom,gpucc.yaml | 1 + .../bindings/clock/qcom,sa8775p-camcc.yaml | 1 + .../bindings/clock/qcom,sa8775p-videocc.yaml | 1 + drivers/clk/qcom/camcc-sa8775p.c | 99 +++++++++++++++++++++- drivers/clk/qcom/gpucc-sa8775p.c | 47 ++++++++++ drivers/clk/qcom/videocc-sa8775p.c | 4 + include/dt-bindings/clock/qcom,sa8775p-camcc.h | 1 + include/dt-bindings/clock/qcom,sa8775p-gpucc.h | 4 +- 8 files changed, 153 insertions(+), 5 deletions(-) --- base-commit: 891a4dc5705df4de9a258accef31786b46700394 change-id: 20241016-qcs8300-mm-patches-fc01e8c75ed4 Best regards,