mbox series

[0/3] arm: qcom: sm8550: Change camcc power domain from MMCX to MXC

Message ID 20240927103212.4154273-1-vladimir.zapolskiy@linaro.org
Headers show
Series arm: qcom: sm8550: Change camcc power domain from MMCX to MXC | expand

Message

Vladimir Zapolskiy Sept. 27, 2024, 10:32 a.m. UTC
The problem is trivial to reproduce and the fix is trivial to verify,
it's sufficient to enable SM8550 camera clock controller and a CCI
controller, for instance on SM8550-QRD CCI0 or CCI1 can be enabled:

    &cci0 {
	status = "okay";
    };

I made a special effort to check that the power domain in SM8550 camcc
is sufficient to be replaced, and Titan and other provided GDSCs can
be turned on/off, if the clock controller is disconneced from MMCX and
MMCX is off according to /sys/kernel/debug/pm_genpd/pm_genpd_summary.

Vladimir Zapolskiy (3):
  arm64: dts: qcom: sm8550: Change camcc power domain from MMCX to MXC
  dt-bindings: clock: qcom,sm8450-camcc: do not restrict power domain to MMCX
  dt-bindings: clock: qcom,sm8450-camcc: generalize title and description

 .../devicetree/bindings/clock/qcom,sm8450-camcc.yaml      | 8 ++++----
 arch/arm64/boot/dts/qcom/sm8550.dtsi                      | 2 +-
 2 files changed, 5 insertions(+), 5 deletions(-)


base-commit: 11a299a7933e03c83818b431e6a1c53ad387423d

Comments

Rob Herring (Arm) Sept. 27, 2024, 10:48 p.m. UTC | #1
On Fri, Sep 27, 2024 at 01:32:11PM +0300, Vladimir Zapolskiy wrote:
> It was unveiled that Qualcomm SM8550 Camera clock controller is attached
> to MXC power domain, therefore it has to be reflected and generalized in
> the device tree bindings description.
> 
> Signed-off-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
> ---
>  .../devicetree/bindings/clock/qcom,sm8450-camcc.yaml          | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/clock/qcom,sm8450-camcc.yaml b/Documentation/devicetree/bindings/clock/qcom,sm8450-camcc.yaml
> index 26afbbe65511..9ef967523987 100644
> --- a/Documentation/devicetree/bindings/clock/qcom,sm8450-camcc.yaml
> +++ b/Documentation/devicetree/bindings/clock/qcom,sm8450-camcc.yaml
> @@ -40,12 +40,12 @@ properties:
>    power-domains:
>      maxItems: 1
>      description:
> -      A phandle and PM domain specifier for the MMCX power domain.
> +      A phandle and PM domain specifier for the supplying power domain.

Just drop as it just describes every 'power-domains' property.

>  
>    required-opps:
>      maxItems: 1
>      description:
> -      A phandle to an OPP node describing required MMCX performance point.
> +      A phandle to an OPP node describing the power domain's performance point.

Same