| Message ID | 20240910-add_qcs615_pinctrl_driver-v1-0-36f4c0d527d8@quicinc.com |
|---|---|
| Headers | show |
| Series | dt-bindings: pinctrl: describe qcs615-tlmm | expand |
On Tue, Sep 10, 2024 at 06:26:14PM +0800, Lijuan Gao wrote: > Document the Top Level Mode Multiplexer on the QCS615 Platform. > It concisely explains the pin multiplexing and configuration in > the device tree, and includes simple examples of typical device > tree snippets, making it easier for designers to configure and > manage chip pins. > > Signed-off-by: Lijuan Gao <quic_lijuang@quicinc.com> > --- > .../bindings/pinctrl/qcom,qcs615-tlmm.yaml | 123 +++++++++++++++++++++ > 1 file changed, 123 insertions(+) > > diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,qcs615-tlmm.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,qcs615-tlmm.yaml > new file mode 100644 > index 000000000000..2bfb0a453880 > --- /dev/null > +++ b/Documentation/devicetree/bindings/pinctrl/qcom,qcs615-tlmm.yaml > @@ -0,0 +1,123 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/pinctrl/qcom,qcs615-tlmm.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Qualcomm Technologies, Inc. QCS615 TLMM block > + > +maintainers: > + - Lijuan Gao <quic_lijuang@quicinc.com> > + > +description: > + Top Level Mode Multiplexer pin controller in Qualcomm QCS615 SoC. > + > +allOf: > + - $ref: /schemas/pinctrl/qcom,tlmm-common.yaml# > + > +properties: > + compatible: > + const: qcom,qcs615-tlmm > + > + reg: > + maxItems: 3 > + > + reg-names: > + items: > + - const: east > + - const: west > + - const: south > + > + interrupts: > + maxItems: 1 > + > + gpio-reserved-ranges: > + minItems: 1 > + maxItems: 62 > + > + gpio-line-names: > + maxItems: 123 > + > +patternProperties: > + "-state$": > + oneOf: > + - $ref: "#/$defs/qcom-qcs615-tlmm-state" > + - patternProperties: Needs 'type: object' before patternProperties. Otherwise, Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
在 9/11/2024 11:18 PM, Rob Herring 写道: > On Tue, Sep 10, 2024 at 06:26:14PM +0800, Lijuan Gao wrote: >> Document the Top Level Mode Multiplexer on the QCS615 Platform. >> It concisely explains the pin multiplexing and configuration in >> the device tree, and includes simple examples of typical device >> tree snippets, making it easier for designers to configure and >> manage chip pins. >> >> Signed-off-by: Lijuan Gao <quic_lijuang@quicinc.com> >> --- >> .../bindings/pinctrl/qcom,qcs615-tlmm.yaml | 123 +++++++++++++++++++++ >> 1 file changed, 123 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,qcs615-tlmm.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,qcs615-tlmm.yaml >> new file mode 100644 >> index 000000000000..2bfb0a453880 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,qcs615-tlmm.yaml >> @@ -0,0 +1,123 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/pinctrl/qcom,qcs615-tlmm.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Qualcomm Technologies, Inc. QCS615 TLMM block >> + >> +maintainers: >> + - Lijuan Gao <quic_lijuang@quicinc.com> >> + >> +description: >> + Top Level Mode Multiplexer pin controller in Qualcomm QCS615 SoC. >> + >> +allOf: >> + - $ref: /schemas/pinctrl/qcom,tlmm-common.yaml# >> + >> +properties: >> + compatible: >> + const: qcom,qcs615-tlmm >> + >> + reg: >> + maxItems: 3 >> + >> + reg-names: >> + items: >> + - const: east >> + - const: west >> + - const: south >> + >> + interrupts: >> + maxItems: 1 >> + >> + gpio-reserved-ranges: >> + minItems: 1 >> + maxItems: 62 >> + >> + gpio-line-names: >> + maxItems: 123 >> + >> +patternProperties: >> + "-state$": >> + oneOf: >> + - $ref: "#/$defs/qcom-qcs615-tlmm-state" >> + - patternProperties: > > Needs 'type: object' before patternProperties. > > Otherwise, > > Reviewed-by: Rob Herring (Arm) <robh@kernel.org> Well noted.
Introduce Top Level Mode Multiplexer dt-binding and driver for Qualcomm QCS615 SoC. Signed-off-by: Lijuan Gao <quic_lijuang@quicinc.com> --- patch made the following modifications and verifications: - Successfully ran dt_binding_check for the current binding file. - Sorted enums, function names, and groups alphabetically. - Specified each tile in DeviceTree referenced with pinctrl-sm8150.c. - Consolidated duplicate functions. - Verified functional with UART function on QCS615 ride board. --- Lijuan Gao (2): dt-bindings: pinctrl: document the QCS615 Top Level Mode Multiplexer pinctrl: qcom: add the tlmm driver for QCS615 platform .../bindings/pinctrl/qcom,qcs615-tlmm.yaml | 123 +++ drivers/pinctrl/qcom/Kconfig.msm | 7 + drivers/pinctrl/qcom/Makefile | 1 + drivers/pinctrl/qcom/pinctrl-qcs615.c | 1107 ++++++++++++++++++++ 4 files changed, 1238 insertions(+) --- base-commit: fdadd93817f124fd0ea6ef251d4a1068b7feceba change-id: 20240906-add_qcs615_pinctrl_driver-eb91a94b2b61 Best regards,