| Message ID | 20240709-add_qcs9100_ethqos_compatible-v2-0-ba22d1a970ff@quicinc.com |
|---|---|
| Headers | show |
| Series | net: stmmac: dwmac-qcom-ethqos: Add QCS9100 ethqos compatible | expand |
These patches are for netdev, so you need to follow the netdev
rules, i.e. the subject should be have [PATCH net-next] in it, etc as
documented over here:
https://docs.kernel.org/process/maintainer-netdev.html#tl-dr
On Tue, Jul 09, 2024 at 10:13:18PM GMT, Tengfei Fan wrote:
> QCS9100 uses EMAC version 4, add the relevant defines, rename the
> has_emac3 switch to has_emac_ge_3 (has emac greater-or-equal than 3)
> and add the new compatible.
This blurb isn't capturing what's done in this change, please make it
reflect the patch.
Thanks,
Andrew
On Tue, Jul 09, 2024 at 09:40:55AM -0500, Andrew Halaney wrote: > These patches are for netdev, so you need to follow the netdev > rules, i.e. the subject should be have [PATCH net-next] in it, etc as > documented over here: > > https://docs.kernel.org/process/maintainer-netdev.html#tl-dr > > On Tue, Jul 09, 2024 at 10:13:18PM GMT, Tengfei Fan wrote: > > QCS9100 uses EMAC version 4, add the relevant defines, rename the > > has_emac3 switch to has_emac_ge_3 (has emac greater-or-equal than 3) > > and add the new compatible. > > This blurb isn't capturing what's done in this change, please make it > reflect the patch. Hi Tengfei If i remember correctly, there was a similar comment made to one of the patches in the huge v1 series. The commit messages are very important, just as important as the code itself. Please review them all and fixup issues like this before you repost. Andrew --- pw-bot: cr
On 7/9/2024 11:33 PM, Andrew Lunn wrote: > On Tue, Jul 09, 2024 at 09:40:55AM -0500, Andrew Halaney wrote: >> These patches are for netdev, so you need to follow the netdev >> rules, i.e. the subject should be have [PATCH net-next] in it, etc as >> documented over here: >> >> https://docs.kernel.org/process/maintainer-netdev.html#tl-dr >> >> On Tue, Jul 09, 2024 at 10:13:18PM GMT, Tengfei Fan wrote: >>> QCS9100 uses EMAC version 4, add the relevant defines, rename the >>> has_emac3 switch to has_emac_ge_3 (has emac greater-or-equal than 3) >>> and add the new compatible. >> >> This blurb isn't capturing what's done in this change, please make it >> reflect the patch. > > Hi Tengfei > > If i remember correctly, there was a similar comment made to one of > the patches in the huge v1 series. > > The commit messages are very important, just as important as the code > itself. Please review them all and fixup issues like this before you > repost. Thx Andrew L for the info. > > Andrew > > --- > pw-bot: cr
On 7/10/2024 11:02 AM, Aiqun Yu (Maria) wrote: > > > On 7/9/2024 11:33 PM, Andrew Lunn wrote: >> On Tue, Jul 09, 2024 at 09:40:55AM -0500, Andrew Halaney wrote: >>> These patches are for netdev, so you need to follow the netdev >>> rules, i.e. the subject should be have [PATCH net-next] in it, etc as >>> documented over here: >>> >>> https://docs.kernel.org/process/maintainer-netdev.html#tl-dr >>> >>> On Tue, Jul 09, 2024 at 10:13:18PM GMT, Tengfei Fan wrote: >>>> QCS9100 uses EMAC version 4, add the relevant defines, rename the >>>> has_emac3 switch to has_emac_ge_3 (has emac greater-or-equal than 3) >>>> and add the new compatible. >>> >>> This blurb isn't capturing what's done in this change, please make it >>> reflect the patch. >> >> Hi Tengfei >> >> If i remember correctly, there was a similar comment made to one of >> the patches in the huge v1 series. >> >> The commit messages are very important, just as important as the code >> itself. Please review them all and fixup issues like this before you >> repost. > > Thx Andrew L for the info. >> >> Andrew >> >> --- >> pw-bot: cr > After considering the feedback provided on the subject, We have decided to keep current SA8775p compatible and ABI compatibility in drivers. Let's close this session and ignore all the current patches here. Thank you for your input.
Introduce support for the QCS9100 SoC device tree (DTSI) and the QCS9100 RIDE board DTS. The QCS9100 is a variant of the SA8775p. While the QCS9100 platform is still in the early design stage, the QCS9100 RIDE board is identical to the SA8775p RIDE board, except it mounts the QCS9100 SoC instead of the SA8775p SoC. The QCS9100 SoC DTSI is directly renamed from the SA8775p SoC DTSI, and all the compatible strings will be updated from "SA8775p" to "QCS9100". The QCS9100 device tree patches will be pushed after all the device tree bindings and device driver patches are reviewed. The final dtsi will like: https://lore.kernel.org/linux-arm-msm/20240703025850.2172008-3-quic_tengfan@quicinc.com/ The detailed cover letter reference: https://lore.kernel.org/linux-arm-msm/20240703025850.2172008-1-quic_tengfan@quicinc.com/ Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com> --- Changes in v2: - Split huge patch series into different patch series according to subsytems - Update patch commit message prevous disscussion here: [1] v1: https://lore.kernel.org/linux-arm-msm/20240703025850.2172008-1-quic_tengfan@quicinc.com/ --- Tengfei Fan (2): dt-bindings: net: qcom,ethqos: add description for qcs9100 net: stmmac: dwmac-qcom-ethqos: add support for emac4 on qcs9100 platforms Documentation/devicetree/bindings/net/qcom,ethqos.yaml | 1 + Documentation/devicetree/bindings/net/snps,dwmac.yaml | 2 ++ drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c | 1 + 3 files changed, 4 insertions(+) --- base-commit: 0b58e108042b0ed28a71cd7edf5175999955b233 change-id: 20240709-add_qcs9100_ethqos_compatible-fb5bb898ff43 Best regards,