| Message ID | 20240708-icc_bw_voting_from_ethqos-v4-0-c6bc3db86071@quicinc.com |
|---|---|
| Headers | show |
| Series | Add interconnect support for stmmac driver. | expand |
On 08/07/2024 23:29, Sagar Cheluvegowda wrote: > Interconnect is a software framework to access NOC bus topology > of the system, this framework is designed to provide a standard > kernel interface to control the settings of the interconnects on > an SoC. > The interconnect support is now being added to the stmmac driver > so that any vendors who wants to use this feature can just > define corresponging dtsi properties according to their > NOC bus topologies. > > here is a patch series which is enabling interconnect support > for ethernet node of SA8775P > https://lore.kernel.org/all/20240708-icc_bw_voting_emac_dtsi-v1-1-4b091b3150c0@quicinc.com/ > > Signed-off-by: Sagar Cheluvegowda <quic_scheluve@quicinc.com> > --- > Changes in v4: > - Add reference to the series which is enabling interconnect-properties defined in this series > - Link to v3: https://lore.kernel.org/r/20240703-icc_bw_voting_from_ethqos-v3-0-8f9148ac60a3@quicinc.com You got two or three times review, but you keep ignoring it. You are expecting the community to keep doing the same work, which is waste of our time and resources. Best regards, Krzysztof
On 7/9/2024 1:58 AM, Krzysztof Kozlowski wrote: > On 08/07/2024 23:29, Sagar Cheluvegowda wrote: >> Interconnect is a software framework to access NOC bus topology >> of the system, this framework is designed to provide a standard >> kernel interface to control the settings of the interconnects on >> an SoC. >> The interconnect support is now being added to the stmmac driver >> so that any vendors who wants to use this feature can just >> define corresponging dtsi properties according to their >> NOC bus topologies. >> >> here is a patch series which is enabling interconnect support >> for ethernet node of SA8775P >> https://lore.kernel.org/all/20240708-icc_bw_voting_emac_dtsi-v1-1-4b091b3150c0@quicinc.com/ >> >> Signed-off-by: Sagar Cheluvegowda <quic_scheluve@quicinc.com> >> --- >> Changes in v4: >> - Add reference to the series which is enabling interconnect-properties defined in this series >> - Link to v3: https://lore.kernel.org/r/20240703-icc_bw_voting_from_ethqos-v3-0-8f9148ac60a3@quicinc.com > > You got two or three times review, but you keep ignoring it. You are > expecting the community to keep doing the same work, which is waste of > our time and resources. > > Best regards, > Krzysztof > I will make sure to add the required Reviewed by or any other tags on the patches in future.
On 7/9/2024 1:56 AM, Krzysztof Kozlowski wrote: > On 08/07/2024 23:30, Sagar Cheluvegowda wrote: >> Add documentation for the interconnect and interconnect-names >> properties required when voting for AHB and AXI buses. >> >> Suggested-by: Andrew Halaney <ahalaney@redhat.com> >> Signed-off-by: Sagar Cheluvegowda <quic_scheluve@quicinc.com> > > <form letter> > This is a friendly reminder during the review process. > > It looks like you received a tag and forgot to add it. > > If you do not know the process, here is a short explanation: > Please add Acked-by/Reviewed-by/Tested-by tags when posting new > versions, under or above your Signed-off-by tag. Tag is "received", when > provided in a message replied to you on the mailing list. Tools like b4 > can help here. However, there's no need to repost patches *only* to add > the tags. The upstream maintainer will do that for tags received on the > version they apply. > > https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/submitting-patches.rst#L577 > > If a tag was not added on purpose, please state why and what changed. > </form letter> > > Best regards, > Krzysztof > Thanks Krzysztof for the explanation, i will make a note of it.
Interconnect is a software framework to access NOC bus topology of the system, this framework is designed to provide a standard kernel interface to control the settings of the interconnects on an SoC. The interconnect support is now being added to the stmmac driver so that any vendors who wants to use this feature can just define corresponging dtsi properties according to their NOC bus topologies. here is a patch series which is enabling interconnect support for ethernet node of SA8775P https://lore.kernel.org/all/20240708-icc_bw_voting_emac_dtsi-v1-1-4b091b3150c0@quicinc.com/ Signed-off-by: Sagar Cheluvegowda <quic_scheluve@quicinc.com> --- Changes in v4: - Add reference to the series which is enabling interconnect-properties defined in this series - Link to v3: https://lore.kernel.org/r/20240703-icc_bw_voting_from_ethqos-v3-0-8f9148ac60a3@quicinc.com Changes in v3: - Drop the patch: [PATCH v2 3/3] net: stmmac: Bring down the clocks to lower frequencies when mac link goes down. - Modify the dt-bindings property names from "axi" and "ahb" to "mac-mem" and "cpu-mac" respectively. - Link to v2: https://lore.kernel.org/r/20240625-icc_bw_voting_from_ethqos-v2-0-eaa7cf9060f0@quicinc.com Changes in v2: - Edit the cover letter to give a big picture of this change. - Move the interconnect changes from ethqos driver to stmmac driver. - Reorder the the patches to place bindings patch on the top. - Remove "_icc_path" redundant string from the "interconnect-names" property. - Link to v1: https://lore.kernel.org/r/20240619-icc_bw_voting_from_ethqos-v1-0-6112948b825e@quicinc.com --- Sagar Cheluvegowda (2): dt-bindings: net: qcom: ethernet: Add interconnect properties net: stmmac: Add interconnect support Documentation/devicetree/bindings/net/qcom,ethqos.yaml | 8 ++++++++ drivers/net/ethernet/stmicro/stmmac/stmmac.h | 1 + drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 8 ++++++++ drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c | 12 ++++++++++++ include/linux/stmmac.h | 2 ++ 5 files changed, 31 insertions(+) --- base-commit: 8a92980606e3585d72d510a03b59906e96755b8a change-id: 20240610-icc_bw_voting_from_ethqos-12f5c6ed46c2 Best regards,