| Message ID | 20240624-sy7802-v5-0-7abc9d96bfa6@apitzsch.eu |
|---|---|
| Headers | show |
| Series | Add sy7802 flash led driver | expand |
On Mon, 24 Jun 2024 23:25:11 +0200, André Apitzsch wrote: > This series introduces a driver for the Silergy SY7802 charge pump used > in the BQ Aquaris M5 and X5 smartphones. > > The implementation is based on information extracted from downstream as > the datasheet provided by a distributor of the hardware didn't include > any information about the i2c register description. > > [...] Applied, thanks! [1/3] dt-bindings: leds: Add Silergy SY7802 flash LED commit: 8c063929fe3d24d9c2c9544d1c1e2add4190b80b [2/3] leds: sy7802: Add support for Silergy SY7802 flash LED controller commit: d0838d7c837820733c4e6b9c6d16323d307ebd96 -- Lee Jones [李琼斯]
On 24.06.2024 11:25 PM, André Apitzsch via B4 Relay wrote: > From: André Apitzsch <git@apitzsch.eu> > > The phone has a Silergy SY7802 flash LED controller. > > Signed-off-by: André Apitzsch <git@apitzsch.eu> > --- > .../boot/dts/qcom/msm8939-longcheer-l9100.dts | 26 ++++++++++++++++++++++ > 1 file changed, 26 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/msm8939-longcheer-l9100.dts b/arch/arm64/boot/dts/qcom/msm8939-longcheer-l9100.dts > index e3404c4455cf..528737929274 100644 > --- a/arch/arm64/boot/dts/qcom/msm8939-longcheer-l9100.dts > +++ b/arch/arm64/boot/dts/qcom/msm8939-longcheer-l9100.dts > @@ -159,6 +159,25 @@ led@2 { > }; > }; > }; > + > + flash-led-controller@53 { > + compatible = "silergy,sy7802"; > + reg = <0x53>; > + #address-cells = <1>; > + #size-cells = <0>; #address-/size-cells usually go at the end, but looks good otherwise Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> Konrad
This series introduces a driver for the Silergy SY7802 charge pump used in the BQ Aquaris M5 and X5 smartphones. The implementation is based on information extracted from downstream as the datasheet provided by a distributor of the hardware didn't include any information about the i2c register description. Signed-off-by: André Apitzsch <git@apitzsch.eu> --- Changes in v5: - Fix language in driver description comment - Unwrap function arguments - Remove unnecessary empty lines - Add Acked-by tag to second patch - Link to v4: https://lore.kernel.org/r/20240616-sy7802-v4-0-789994180e05@apitzsch.eu Changes in v4: - Use for_each_available_child_of_node_scoped() to simplify code - Use dev_err_probe() to be consistent with the other code in sy7802_probe() - Split devm_add_action() into 2 devm_add_action_or_reset() to simplify code and balance regulator_enable() - Link to v3: https://lore.kernel.org/r/20240612-sy7802-v3-0-1e9cc1c79b79@apitzsch.eu Changes in v3: - Add R-b tag to first patch - Extend driver commit message - Improve readability of defines by using BIT() - Rename some variables/parameters * led_no -> led_id * level -> brightness * curr -> fled_{strobe,torch}_used_tmp * mask -> {flash,torch}_mask * i -> child_num - Restructure structs ("Place th big stuff at the top") - Declare 'child' on a separate line - Move multi-line assignments out of declaration block - Update warning/error messages and comments - Use gotos to handle error path - Use devm API to cleanup module's resources - Init mutex before LED class device is registered to avoid race condition - Link to v2: https://lore.kernel.org/r/20240401-sy7802-v2-0-1138190a7448@apitzsch.eu Changes in v2: - bindings: remove unneeded allOf - bindings: example: move flash-led-controller under i2c node to fix check error - Cc to phone-devel - Link to v1: https://lore.kernel.org/r/20240327-sy7802-v1-0-db74ab32faaf@apitzsch.eu --- André Apitzsch (3): dt-bindings: leds: Add Silergy SY7802 flash LED leds: sy7802: Add support for Silergy SY7802 flash LED controller arm64: dts: qcom: msm8939-longcheer-l9100: Add rear flash .../devicetree/bindings/leds/silergy,sy7802.yaml | 100 ++++ .../boot/dts/qcom/msm8939-longcheer-l9100.dts | 26 + drivers/leds/flash/Kconfig | 11 + drivers/leds/flash/Makefile | 1 + drivers/leds/flash/leds-sy7802.c | 539 +++++++++++++++++++++ 5 files changed, 677 insertions(+) --- base-commit: 6a03b35e4395eb2d6e89a38aca00a9fe9cb39ba1 change-id: 20240325-sy7802-f40fc6f56525 Best regards,