From patchwork Wed Jun 5 12:17:07 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bibek Kumar Patro X-Patchwork-Id: 802103 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5E3301991C9; Wed, 5 Jun 2024 12:18:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717589917; cv=none; b=ohFrQPEGmqdlixQpZa3juPZmjeH5eoNyT74POP925OLej6+ihW4dAoF4Lp7hwbSzCBswYB1TwCFzSChBEyKQG48RQINGFLdINnMbX1A971u2IoIqZXq94imFh6ZwYX/EPuUuHz16mLTFmMCskG07LIAMS9spD8rTUAUe/CD7Ilo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717589917; c=relaxed/simple; bh=Qe6xU5/2WPH8TVP78kPiN81IWMwEHmhYCUSxzi7WrmQ=; h=From:To:CC:Subject:Date:Message-ID:MIME-Version:Content-Type; b=HBe7z7B53HhUt6pogjcN9qZyUN4AuyYYQuzODOSFhpID3c+pl7p0vfKBiCIJha7XXmgtHRdaHUSK8euQwcz8tBWnUvGWHCVhvC0f61qDboTpFCl1AnVDTS+uUBet5JZRK0Aq4jmd2BsUP0Lt11q5Z6VxevZrNVVpTeahi5aaRPw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com; spf=pass smtp.mailfrom=quicinc.com; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b=OTsTc1Cp; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=quicinc.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="OTsTc1Cp" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 455B1Rx8016651; Wed, 5 Jun 2024 12:18:16 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= cc:content-transfer-encoding:content-type:date:from:message-id :mime-version:subject:to; s=qcppdkim1; bh=nbULwnwP3UltMQS70MB3bp pWxTh+nGgf1XXs8WvgVFQ=; b=OTsTc1CpsMBoey+a3/24RKhJlTSbJhwcwoaJKx 10KBhsCKIYHkaVnzUMnTGnp7aS3J7vDBI97ydb38WroT0xVzbFIokbmQZ49erp1p D6+47t71O99XUFGxGlf9Is5ThnXU6f+p2CmpRDsvYvXGiiCrdOQcuOpjxNICPVIp NWzRvThHOyc3974uOy5donMpiH05RzOwCJJsY0vcK+U1KxjQzE58wNu5Fn0TaFMh MKwOTo0frAOg2KyijIhd9Z8sQ/JwFa9GWMNS+WYIx6iZy5Z6K7/J2soKt6GzM8hz uI6VmF/dtclVMVmsW15ss/tmIKbTFbsnXjOmeIVpM6xzCpSA== Received: from nalasppmta05.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3yjan2hn3y-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 05 Jun 2024 12:18:16 +0000 (GMT) Received: from nalasex01c.na.qualcomm.com (nalasex01c.na.qualcomm.com [10.47.97.35]) by NALASPPMTA05.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 455CIF9G024620 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 5 Jun 2024 12:18:15 GMT Received: from hu-bibekkum-hyd.qualcomm.com (10.80.80.8) by nalasex01c.na.qualcomm.com (10.47.97.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Wed, 5 Jun 2024 05:18:09 -0700 From: Bibek Kumar Patro To: , , , , , , , , , , CC: , , , , "Bibek Kumar Patro" Subject: [PATCH v11 0/6] iommu/arm-smmu: introduction of ACTLR implementation for Qualcomm SoCs Date: Wed, 5 Jun 2024 17:47:07 +0530 Message-ID: <20240605121713.3596499-1-quic_bibekkum@quicinc.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01c.na.qualcomm.com (10.47.97.35) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: iHIcMu0GujT2P_kUHACFALAaZMQ4LigB X-Proofpoint-ORIG-GUID: iHIcMu0GujT2P_kUHACFALAaZMQ4LigB X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16 definitions=2024-06-05_02,2024-06-05_02,2024-05-17_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 phishscore=0 adultscore=0 spamscore=0 clxscore=1015 mlxscore=0 malwarescore=0 impostorscore=0 mlxlogscore=999 bulkscore=0 suspectscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2405170001 definitions=main-2406050093 This patch series consist of six parts and covers the following: 1. Re-enable context caching for Qualcomm SoCs to retain prefetcher settings during reset and runtime suspend. 2. Remove cfg inside qcom_smmu structure and replace it with single pointer to qcom_smmu_match_data avoiding replication of multiple members from same. 3. Introduce intital set of driver changes to implement ACTLR register for custom prefetcher settings in Qualcomm SoCs. 4. Add ACTLR data and implementation operations for SM8550. 5. Add ACTLR data and implementation operations for SC7280. 6. Add support for ACTLR PRR bit setup via adreno-smmu-priv interface. Changes in v11 from v10: - Include a new patch 6/6 to add support for ACTLR PRR bit through adreno-smmu-priv interface as suggested by Rob and Dmitry. Link to v10: https://lore.kernel.org/all/20240524131800.2288259-1-quic_bibekkum@quicinc.com/ Changes in v10 from v9: - Added reviewed-by tags 1/5,2/5,3/5. Changes incorporated: - Remove redundant PRR bit setting from gfx actlr table(patch 4/5,5/5) as this bit needs special handling in the gfx driver along with the associated register settings. Link to discussion on PRR bit: https://lore.kernel.org/all/f2222714-1e00-424e-946d-c314d55541b8@quicinc.com/ Link to v9: https://lore.kernel.org/all/20240123144543.9405-1-quic_bibekkum@quicinc.com/ Changes in v9 from v8: Changes to incorporate suggestions from Konrad as follows: - Re-wrap struct members of actlr_variant in patch 4/5,5/5 in a cleaner way. - Move actlr_config members to the header. Link to v8: https://lore.kernel.org/all/20240116150411.23876-1-quic_bibekkum@quicinc.com/ Changes in v8 from v7: - Added reviewed-by tags on patch 1/5, 2/5. Changes to incorporate suggestions from Pavan and Konrad: - Remove non necessary extra lines. - Use num_smmu and num_actlrcfg to store the array size and use the same to traverse the table and save on sentinel space along with indentation levels. - Refactor blocks containing qcom_smmu_set_actlr to remove block repetition in patch 3/5. - Change copyright year from 2023 to 2022-2023 in patch 3/5. - Modify qcom_smmu_match_data.actlrvar and actlr_variant.actlrcfg to const pointer to a const resource. - use C99 designated initializers and put the address first. Link to v7: https://lore.kernel.org/all/20240109114220.30243-1-quic_bibekkum@quicinc.com/ Changes in v7 from v6: Changes to incorporate suggestions from Dmitry as follows: - Use io_start address instead of compatible string to identify the correct instance by comparing with smmu start address and check for which smmu the corresponding actlr table is to be picked. Link to v6: https://lore.kernel.org/all/20231220133808.5654-1-quic_bibekkum@quicinc.com/ Changes in v6 from v5: - Remove extra Suggested-by tags. - Add return check for arm_mmu500_reset in 1/5 as discussed. Link to v5: https://lore.kernel.org/all/20231219135947.1623-1-quic_bibekkum@quicinc.com/ Changes in v5 from v4: New addition: - Modify copyright year in arm-smmu-qcom.h to 2023 from 2022. Changes to incorporate suggestions from Dmitry as follows: - Modify the defines for prefetch in (foo << bar) format as suggested.(FIELD_PREP could not be used in defines is not inside any block/function) Changes to incorporate suggestions from Konrad as follows: - Shift context caching enablement patch as 1/5 instead of 5/5 to be picked up as independent patch. - Fix the codestyle to orient variables in reverse xmas tree format for patch 1/5. - Fix variable name in patch 1/5 as suggested. Link to v4: https://lore.kernel.org/all/20231215101827.30549-1-quic_bibekkum@quicinc.com/ Changes in v4 from v3: New addition: - Remove actlrcfg_size and use NULL end element instead to traverse the actlr table, as this would be a cleaner approach by removing redundancy of actlrcfg_size. - Renaming of actlr set function to arm_smmu_qcom based proprietary convention. - break from loop once sid is found and ACTLR value is initialized in qcom_smmu_set_actlr. - Modify the GFX prefetch value separating into 2 sensible defines. - Modify comments for prefetch defines as per SMMU-500 TRM. Changes to incorporate suggestions from Konrad as follows: - Use Reverse-Christmas-tree sorting wherever applicable. - Pass arguments directly to arm_smmu_set_actlr instead of creating duplicate variables. - Use array indexing instead of direct pointer addressed by new addition of eliminating actlrcfg_size. - Switch the HEX value's case from upper to lower case in SC7280 actlrcfg table. Changes to incorporate suggestions from Dmitry as follows: - Separate changes not related to ACTLR support to different commit with patch 5/5. - Using pointer to struct for arguments in smr_is_subset(). Changes to incorporate suggestions from Bjorn as follows: - fix the commit message for patch 2/5 to properly document the value space to avoid confusion. Fixed build issues reported by kernel test robot [1] for arm64-allyesconfig [2]. [1]: https://lore.kernel.org/all/202312011750.Pwca3TWE-lkp@intel.com/ [2]: https://download.01.org/0day-ci/archive/20231201/202312011750.Pwca3TWE-lkp@intel.com/config Link to v3: https://lore.kernel.org/all/20231127145412.3981-1-quic_bibekkum@quicinc.com/ Changes in v3 from v2: New addition: - Include patch 3/4 for adding ACTLR support and data for SC7280. - Add driver changes for actlr support in gpu smmu. - Add target wise actlr data and implementation ops for gpu smmu. Changes to incorporate suggestions from Robin as follows: - Match the ACTLR values with individual corresponding SID instead of assuming that any SMR will be programmed to match a superset of the data. - Instead of replicating each elements from qcom_smmu_match_data to qcom_smmu structre during smmu device creation, replace the replicated members with qcom_smmu_match_data structure inside qcom_smmu structre and handle the dereference in places that requires them. Changes to incorporate suggestions from Dmitry and Konrad as follows: - Maintain actlr table inside a single structure instead of nested structure. - Rename prefetch defines to more appropriately describe their behavior. - Remove SM8550 specific implementation ops and roll back to default qcom_smmu_500_impl implementation ops. - Add back the removed comments which are NAK. - Fix commit description for patch 4/4. Link to v2: https://lore.kernel.org/all/20231114135654.30475-1-quic_bibekkum@quicinc.com/ Changes in v2 from v1: - Incorporated suggestions on v1 from Dmitry,Konrad,Pratyush. - Added defines for ACTLR values. - Linked sm8550 implementation structure to corresponding compatible string. - Repackaged actlr value set implementation to separate function. - Fixed indentation errors. - Link to v1: https://lore.kernel.org/all/20231103215124.1095-1-quic_bibekkum@quicinc.com/ Changes in v1 from RFC: - Incorporated suggestion form Robin on RFC - Moved the actlr data table into driver, instead of maintaining it inside soc specific DT and piggybacking on exisiting iommus property (iommu = ) to set this value during smmu probe. - Link to RFC: https://lore.kernel.org/all/a01e7e60-6ead-4a9e-ba90-22a8a6bbd03f@quicinc.com/ Bibek Kumar Patro (6): iommu/arm-smmu: re-enable context caching in smmu reset operation iommu/arm-smmu: refactor qcom_smmu structure to include single pointer iommu/arm-smmu: introduction of ACTLR for custom prefetcher settings iommu/arm-smmu: add ACTLR data and support for SM8550 iommu/arm-smmu: add ACTLR data and support for SC7280 iommu/arm-smmu: add support for PRR bit setup .../iommu/arm/arm-smmu/arm-smmu-qcom-debug.c | 2 +- drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c | 244 +++++++++++++++++- drivers/iommu/arm/arm-smmu/arm-smmu-qcom.h | 18 +- drivers/iommu/arm/arm-smmu/arm-smmu.c | 5 +- drivers/iommu/arm/arm-smmu/arm-smmu.h | 7 + include/linux/adreno-smmu-priv.h | 5 +- 6 files changed, 270 insertions(+), 11 deletions(-) --- 2.34.1