mbox series

[V3,0/8] clk: qcom: Add support for DISPCC, CAMCC and GPUCC on SM4450

Message ID 20240528114254.3147988-1-quic_ajipan@quicinc.com
Headers show
Series clk: qcom: Add support for DISPCC, CAMCC and GPUCC on SM4450 | expand

Message

Ajit Pandey May 28, 2024, 11:42 a.m. UTC 
This patch series add dt-bindings, driver and device tree support for DISPCC, CAMCC
and GPUCC on QCOM SM4450 platform and also includes a fix related to LUCID EVO PLL
config issue in clk-alpha-pll driver which is required for correct scaling of few
supported frequencies in graphics clock controllers on SM4450.

Changes in V3:
- [PATCH 1/8]: Updated commit tags order and added Reviewed-by: tags
- [PATCH 3/8]: Fixed reusing of pll0_config and added Reviewed-by: tags 
- [PATCH 6/8]: Updated commit text and added Reviewed-by tags
- [PATCH 8/8]: Updated node order for gpucc.
- Link to v2: https://lore.kernel.org/all/20240416182005.75422-1-quic_ajipan@quicinc.com/ 

Ajit Pandey (8):
  clk: qcom: clk-alpha-pll: Fix CAL_L_VAL override for LUCID EVO PLL
  dt-bindings: clock: qcom: add DISPCC clocks on SM4450
  clk: qcom: Add DISPCC driver support for SM4450
  dt-bindings: clock: qcom: add CAMCC clocks on SM4450
  clk: qcom: Add CAMCC driver support for SM4450
  dt-bindings: clock: qcom: add GPUCC clocks on SM4450
  clk: qcom: Add GPUCC driver support for SM4450
  arm64: dts: qcom: sm4450: add camera, display and gpu clock controller

 .../bindings/clock/qcom,sm4450-camcc.yaml     |   63 +
 .../bindings/clock/qcom,sm4450-dispcc.yaml    |   71 +
 .../bindings/clock/qcom,sm8450-gpucc.yaml     |    2 +
 arch/arm64/boot/dts/qcom/sm4450.dtsi          |   38 +
 drivers/clk/qcom/Kconfig                      |   27 +
 drivers/clk/qcom/Makefile                     |    3 +
 drivers/clk/qcom/camcc-sm4450.c               | 1688 +++++++++++++++++
 drivers/clk/qcom/clk-alpha-pll.c              |    2 +-
 drivers/clk/qcom/dispcc-sm4450.c              |  770 ++++++++
 drivers/clk/qcom/gpucc-sm4450.c               |  805 ++++++++
 include/dt-bindings/clock/qcom,sm4450-camcc.h |  106 ++
 .../dt-bindings/clock/qcom,sm4450-dispcc.h    |   51 +
 include/dt-bindings/clock/qcom,sm4450-gpucc.h |   62 +
 13 files changed, 3687 insertions(+), 1 deletion(-)
 create mode 100644 Documentation/devicetree/bindings/clock/qcom,sm4450-camcc.yaml
 create mode 100644 Documentation/devicetree/bindings/clock/qcom,sm4450-dispcc.yaml
 create mode 100644 drivers/clk/qcom/camcc-sm4450.c
 create mode 100644 drivers/clk/qcom/dispcc-sm4450.c
 create mode 100644 drivers/clk/qcom/gpucc-sm4450.c
 create mode 100644 include/dt-bindings/clock/qcom,sm4450-camcc.h
 create mode 100644 include/dt-bindings/clock/qcom,sm4450-dispcc.h
 create mode 100644 include/dt-bindings/clock/qcom,sm4450-gpucc.h

Comments

Ajit Pandey June 6, 2024, 6:11 a.m. UTC | #1 
On 5/30/2024 1:18 AM, Stephen Boyd wrote:
> Quoting Dmitry Baryshkov (2024-05-28 06:23:27)
>> On Tue, May 28, 2024 at 05:12:53PM +0530, Ajit Pandey wrote:
>>> Add Graphics Clock Controller (GPUCC) support for SM4450 platform.
>>>
>>> Signed-off-by: Ajit Pandey <quic_ajipan@quicinc.com>
>>> ---
>>>   drivers/clk/qcom/Kconfig        |   9 +
>>>   drivers/clk/qcom/Makefile       |   1 +
>>>   drivers/clk/qcom/gpucc-sm4450.c | 805 ++++++++++++++++++++++++++++++++
>>>   3 files changed, 815 insertions(+)
>>>   create mode 100644 drivers/clk/qcom/gpucc-sm4450.c
>>
>> [trimmed]
>>
>>> +
>>> +     /* Keep some clocks always enabled */
>>> +     qcom_branch_set_clk_en(regmap, 0x93a4); /* GPU_CC_CB_CLK */
>>> +     qcom_branch_set_clk_en(regmap, 0x9004); /* GPU_CC_CXO_AON_CLK */
>>> +     qcom_branch_set_clk_en(regmap, 0x900c); /* GPU_CC_DEMET_CLK */
>>
>> I pinged Stephen regarding these clocks. LGTM otherwise.
>>
> 
> Looks OK to me. I assume that these clks don't get turned off when the
> GPU power domain is turned off. If that's the case then presumably we
> would need to turn these on and off during power transitions.

Yes, these clocks will not get turned off with GPU power domain 
transitions hence explicit on and off isn't required.
Konrad Dybcio June 6, 2024, 2:18 p.m. UTC | #2 
On 28.05.2024 1:42 PM, Ajit Pandey wrote:
> Add Graphics Clock Controller (GPUCC) support for SM4450 platform.
> 
> Signed-off-by: Ajit Pandey <quic_ajipan@quicinc.com>
> ---

Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad