mbox series

[00/10] arm64: dts: qcom: sc8180x: Enable the USB multiport controller

Message ID 20240525-sc8180x-usb-mp-v1-0-60a904392438@quicinc.com
Headers show
Series arm64: dts: qcom: sc8180x: Enable the USB multiport controller | expand

Message

Bjorn Andersson May 25, 2024, 6:03 p.m. UTC
The USB multiport controller found in SC8180X is used to driver the
camera in the Lenovo Flex 5G, and a couple of additional USB ports on
the Primus AUX board.

Signed-off-by: Bjorn Andersson <quic_bjorande@quicinc.com>
---
Bjorn Andersson (10):
      dt-bindings: phy: qcom,sc8280xp-qmp-usb3-uni: Add sc8180x USB3 compatible
      phy: qcom-qmp-usb: Add sc8180x USB UNIPHY
      dt-bindings: clock: qcom: Add missing USB MP resets
      clk: qcom: gcc-sc8180x: Add missing USB MP resets
      dt-bindings: usb: qcom,dwc3: Add SC8180X compatibles
      arm64: dts: qcom: sc8180x-pmics: Add second PMC8180 GPIO
      arm64: dts: qcom: sc8180x: Align USB nodes with binding
      arm64: dts: qcom: sc8180x: Add USB MP controller and phys
      arm64: dts: qcom: sc8180x-primus: Enable the two MP USB ports
      arm64: dts: qcom: sc8180x-lenovo-flex-5g: Enable USB multiport controller

 .../phy/qcom,sc8280xp-qmp-usb3-uni-phy.yaml        |   3 +
 .../devicetree/bindings/usb/qcom,dwc3.yaml         |  29 ++++
 .../arm64/boot/dts/qcom/sc8180x-lenovo-flex-5g.dts |  32 ++++
 arch/arm64/boot/dts/qcom/sc8180x-pmics.dtsi        |  16 +-
 arch/arm64/boot/dts/qcom/sc8180x-primus.dts        |  60 +++++++
 arch/arm64/boot/dts/qcom/sc8180x.dtsi              | 175 +++++++++++++++++++--
 drivers/clk/qcom/gcc-sc8180x.c                     |   4 +
 drivers/phy/qualcomm/phy-qcom-qmp-usb.c            |   3 +
 include/dt-bindings/clock/qcom,gcc-sc8180x.h       |   4 +
 9 files changed, 312 insertions(+), 14 deletions(-)
---
base-commit: 3689b0ef08b70e4e03b82ebd37730a03a672853a
change-id: 20240524-sc8180x-usb-mp-4eb278df7ef1

Best regards,

Comments

Dmitry Baryshkov May 25, 2024, 8:16 p.m. UTC | #1
On Sat, May 25, 2024 at 11:04:02AM -0700, Bjorn Andersson wrote:
> From: Bjorn Andersson <quic_bjorande@quicinc.com>
> 
> The SC8180X Primus comes with an AUX card with two USB ports, fed by the
> two multiport ports.
> 
> Enable the involved nodes and define two always-on regulators to enable
> VBUS for these ports.
> 
> Signed-off-by: Bjorn Andersson <quic_bjorande@quicinc.com>
> ---
>  arch/arm64/boot/dts/qcom/sc8180x-primus.dts | 60 +++++++++++++++++++++++++++++
>  1 file changed, 60 insertions(+)
> 

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Krzysztof Kozlowski May 26, 2024, 6:17 p.m. UTC | #2
On 25/05/2024 20:03, Bjorn Andersson wrote:
> From: Bjorn Andersson <quic_bjorande@quicinc.com>
> 
> The SC8180X has two USB3 UNIPHY QMP blocks, add a compatible for these.
> 
> Signed-off-by: Bjorn Andersson <quic_bjorande@quicinc.com>
> ---
>  .../devicetree/bindings/phy/qcom,sc8280xp-qmp-usb3-uni-phy.yaml        | 3 +++
>  1 file changed, 3 insertions(+)

Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>

Best regards,
Krzysztof
Krzysztof Kozlowski May 26, 2024, 6:22 p.m. UTC | #3
On 25/05/2024 20:03, Bjorn Andersson wrote:
> From: Bjorn Andersson <quic_bjorande@quicinc.com>
> 
> The SC8180X platform has two single port DWC3 instances and a two-port
> DWC3 instance. Add compatibles for these to the binding.
> 

Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>

Best regards,
Krzysztof
Konrad Dybcio May 28, 2024, 12:42 p.m. UTC | #4
On 5/25/24 20:04, Bjorn Andersson wrote:
> From: Bjorn Andersson <quic_bjorande@quicinc.com>
> 
> Add the pwr_event interrupt and rearrange the order of the other
> interrupts to match the binding.
> 
> Signed-off-by: Bjorn Andersson <quic_bjorande@quicinc.com>
> ---

The new numbers look correct as well

Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad
Rob Herring May 28, 2024, 5:41 p.m. UTC | #5
On Sat, 25 May 2024 11:03:53 -0700, Bjorn Andersson wrote:
> The USB multiport controller found in SC8180X is used to driver the
> camera in the Lenovo Flex 5G, and a couple of additional USB ports on
> the Primus AUX board.
> 
> Signed-off-by: Bjorn Andersson <quic_bjorande@quicinc.com>
> ---
> Bjorn Andersson (10):
>       dt-bindings: phy: qcom,sc8280xp-qmp-usb3-uni: Add sc8180x USB3 compatible
>       phy: qcom-qmp-usb: Add sc8180x USB UNIPHY
>       dt-bindings: clock: qcom: Add missing USB MP resets
>       clk: qcom: gcc-sc8180x: Add missing USB MP resets
>       dt-bindings: usb: qcom,dwc3: Add SC8180X compatibles
>       arm64: dts: qcom: sc8180x-pmics: Add second PMC8180 GPIO
>       arm64: dts: qcom: sc8180x: Align USB nodes with binding
>       arm64: dts: qcom: sc8180x: Add USB MP controller and phys
>       arm64: dts: qcom: sc8180x-primus: Enable the two MP USB ports
>       arm64: dts: qcom: sc8180x-lenovo-flex-5g: Enable USB multiport controller
> 
>  .../phy/qcom,sc8280xp-qmp-usb3-uni-phy.yaml        |   3 +
>  .../devicetree/bindings/usb/qcom,dwc3.yaml         |  29 ++++
>  .../arm64/boot/dts/qcom/sc8180x-lenovo-flex-5g.dts |  32 ++++
>  arch/arm64/boot/dts/qcom/sc8180x-pmics.dtsi        |  16 +-
>  arch/arm64/boot/dts/qcom/sc8180x-primus.dts        |  60 +++++++
>  arch/arm64/boot/dts/qcom/sc8180x.dtsi              | 175 +++++++++++++++++++--
>  drivers/clk/qcom/gcc-sc8180x.c                     |   4 +
>  drivers/phy/qualcomm/phy-qcom-qmp-usb.c            |   3 +
>  include/dt-bindings/clock/qcom,gcc-sc8180x.h       |   4 +
>  9 files changed, 312 insertions(+), 14 deletions(-)
> ---
> base-commit: 3689b0ef08b70e4e03b82ebd37730a03a672853a
> change-id: 20240524-sc8180x-usb-mp-4eb278df7ef1
> 
> Best regards,
> --
> Bjorn Andersson <quic_bjorande@quicinc.com>
> 
> 
> 


My bot found new DTB warnings on the .dts files added or changed in this
series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:

  pip3 install dtschema --upgrade


New warnings running 'make CHECK_DTBS=y qcom/sc8180x-lenovo-flex-5g.dtb qcom/sc8180x-primus.dtb' for 20240525-sc8180x-usb-mp-v1-0-60a904392438@quicinc.com:

arch/arm64/boot/dts/qcom/sc8180x-lenovo-flex-5g.dtb: clock-controller@af00000: clocks: [[41, 0], [42], [120, 0], [120, 1], [124, 0], [124, 1], [127, 0], [127, 1]] is too long
	from schema $id: http://devicetree.org/schemas/clock/qcom,dispcc-sm8x50.yaml#
arch/arm64/boot/dts/qcom/sc8180x-primus.dtb: clock-controller@af00000: clocks: [[41, 0], [42], [122, 0], [122, 1], [126, 0], [126, 1], [129, 0], [129, 1]] is too long
	from schema $id: http://devicetree.org/schemas/clock/qcom,dispcc-sm8x50.yaml#