| Message ID | 20240418122859.2079099-1-f.suligoi@asem.it |
|---|---|
| Headers | show |
| Series | arm64: dts: remove tx-sched-sp property in snps,dwmac | expand |
On 18/04/2024 14:28, Flavio Suligoi wrote: > Strict priority for the tx scheduler is by default in Linux driver, so the > tx-sched-sp property was removed in commit aed6864035b1 ("net: stmmac: > platform: Delete a redundant condition branch"). > > So we can safely remove this property from this device-tree. > > Signed-off-by: Flavio Suligoi <f.suligoi@asem.it> > Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org> NAK, not true. Best regards, Krzysztof
On 18/04/2024 14:28, Flavio Suligoi wrote: > Strict priority for the tx scheduler is by default in Linux driver, so the > tx-sched-sp property was removed in commit aed6864035b1 ("net: stmmac: > platform: Delete a redundant condition branch"). > > So we can safely remove this property from this device-tree. > > Signed-off-by: Flavio Suligoi <f.suligoi@asem.it> > Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org> NAK. Not true. Please point me to my review for this patch. Best regards, Krzysztof
Hi Krzysztof, ... > On 18/04/2024 14:28, Flavio Suligoi wrote: > > Strict priority for the tx scheduler is by default in Linux driver, so > > the tx-sched-sp property was removed in commit aed6864035b1 ("net: > stmmac: > > platform: Delete a redundant condition branch"). > > > > So we can safely remove this property from this device-tree. > > > > Signed-off-by: Flavio Suligoi <f.suligoi@asem.it> > > Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org> > > NAK. Not true. Please point me to my review for this patch. I'm very sorry for the misunderstanding, I saw your reply in: https://lore.kernel.org/netdev/010d67c7-ca71-43fc-a3e3-ec3e5cd8b149@kernel.org/ and thought it might be okay for all the other patches. Do you want me to resend a v3 version of the patches without the "Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>" ? > > Best regards, > Krzysztof Thanks and best regards, Flavio
On 19/04/2024 10:45, FLAVIO SULIGOI wrote: > Hi Krzysztof, > > ... > >> On 18/04/2024 14:28, Flavio Suligoi wrote: >>> Strict priority for the tx scheduler is by default in Linux driver, so >>> the tx-sched-sp property was removed in commit aed6864035b1 ("net: >> stmmac: >>> platform: Delete a redundant condition branch"). >>> >>> So we can safely remove this property from this device-tree. >>> >>> Signed-off-by: Flavio Suligoi <f.suligoi@asem.it> >>> Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org> >> >> NAK. Not true. Please point me to my review for this patch. > > I'm very sorry for the misunderstanding, I saw your reply in: > > https://lore.kernel.org/netdev/010d67c7-ca71-43fc-a3e3-ec3e5cd8b149@kernel.org/ > > and thought it might be okay for all the other patches. Where was it replied? In patch 5. Why can't you use b4 for this? It solves the problems. > > Do you want me to resend a v3 version of the patches without the > "Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>" ? Yes, you must send new version because you added fake tags. Use b4 trailers to collect tags. https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/submitting-patches.rst#L577 Best regards, Krzysztof
In the ethernet stmmac device driver: - drivers/net/ethernet/stmicro/stmmac/ The "Strict priority" for the tx scheduler is by default in Linux driver, so the tx-sched-sp property was removed in commit aed6864035b1 ("net: stmmac: platform: Delete a redundant condition branch"). This patch series remove this property from the following device-tree files: - arch/arm64/boot/dts/freescale/imx8mp-beacon-som.dtsi - arch/arm64/boot/dts/freescale/imx8mp-evk.dts - arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi - arch/arm64/boot/dts/qcom/sa8540p-ride.dts - arch/arm64/boot/dts/qcom/sa8775p-ride.dts There is no problem if that property is still used in these DTS, since, as seen above, it is a default property of the driver. The property is also removed, in a separate patch, from the corresponding dt_bindings file: - Documentation/devicetree/bindings/net/snps,dwmac.yaml v2 - This patch is the 2nd version of a previous patch, where both the DTS and the yaml files were included toghether. Then I split this 1st patch in two, as suggested by Krzysztof. v1 - original version of the patch where, in addition to these DTS patches, there was also the one related to the correspondent snps,dwmac.yaml dt_binding file. Flavio Suligoi (5): arm64: dts: freescale: imx8mp-beacon: remove tx-sched-sp property arm64: dts: freescale: imx8mp-evk: remove tx-sched-sp property arm64: dts: freescale: imx8mp-verdin: remove tx-sched-sp property arm64: dts: qcom: sa8540p-ride: remove tx-sched-sp property arm64: dts: qcom: sa8775p-ride: remove tx-sched-sp property arch/arm64/boot/dts/freescale/imx8mp-beacon-som.dtsi | 1 - arch/arm64/boot/dts/freescale/imx8mp-evk.dts | 1 - arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi | 1 - arch/arm64/boot/dts/qcom/sa8540p-ride.dts | 2 -- arch/arm64/boot/dts/qcom/sa8775p-ride.dts | 2 -- 5 files changed, 7 deletions(-)