mbox series

[0/2] Enable vibrator on PMI632 + Fairphone 3

Message ID 20240418-fp3-vibra-v1-0-b636b8b3ff32@fairphone.com
Headers show
Series Enable vibrator on PMI632 + Fairphone 3 | expand

Message

Luca Weiss April 18, 2024, 6:36 a.m. UTC 
With the patches to add vibration support for PMI632 finally applied,
let's enable this for the PMI632 PMIC and Fairphone 3 smartphone.

https://lore.kernel.org/linux-arm-msm/20240416-pm8xxx-vibrator-new-design-v11-0-7b1c951e1515@quicinc.com/

Patches have landed in the input tree:
https://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git/

Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
---
Luca Weiss (2):
      arm64: dts: qcom: pmi632: Add vibrator
      arm64: dts: qcom: sdm632-fairphone-fp3: Enable vibrator

 arch/arm64/boot/dts/qcom/pmi632.dtsi              | 6 ++++++
 arch/arm64/boot/dts/qcom/sdm632-fairphone-fp3.dts | 4 ++++
 2 files changed, 10 insertions(+)
---
base-commit: eecc5d90861b551d3b8fbd0d0e6f25c40496f3c0
change-id: 20240418-fp3-vibra-18c400889853

Best regards,

Comments

Konrad Dybcio April 18, 2024, 10:01 a.m. UTC | #1 
On 18.04.2024 8:36 AM, Luca Weiss wrote:
> Add a node for the vibrator module found inside the PMI632.
> 
> Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
> ---

Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

On a side note, this is a totally configuration-free peripheral that doesn't do
anything crazy until manually configured.

In the slow quest to be (hopefully) more sane about the defaults, should we keep
them enabled by default? Bjorn?

Konrad
Luca Weiss April 18, 2024, 10:03 a.m. UTC | #2 
On Thu Apr 18, 2024 at 12:01 PM CEST, Konrad Dybcio wrote:
> On 18.04.2024 8:36 AM, Luca Weiss wrote:
> > Add a node for the vibrator module found inside the PMI632.
> > 
> > Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
> > ---
>
> Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
>
> On a side note, this is a totally configuration-free peripheral that doesn't do
> anything crazy until manually configured.
>
> In the slow quest to be (hopefully) more sane about the defaults, should we keep
> them enabled by default? Bjorn?

But many (most?) devices don't have a vibration motor connected to
PMI632, some (like devboards) don't have anything, and other phones have
a separate chip that controls the vibration motor.

Enabling this by default would mean all devices with PMI632 would get an
input device for the vibrator that probably doesn't work?

Regards
Luca

>
> Konrad
Bjorn Andersson May 29, 2024, 2:01 a.m. UTC | #3 
On Thu, 18 Apr 2024 08:36:53 +0200, Luca Weiss wrote:
> With the patches to add vibration support for PMI632 finally applied,
> let's enable this for the PMI632 PMIC and Fairphone 3 smartphone.
> 
> https://lore.kernel.org/linux-arm-msm/20240416-pm8xxx-vibrator-new-design-v11-0-7b1c951e1515@quicinc.com/
> 
> Patches have landed in the input tree:
> https://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git/
> 
> [...]

Applied, thanks!

[1/2] arm64: dts: qcom: pmi632: Add vibrator
      commit: bbb1dd6402f9c67ea00bc6bf0e2a01d71db4c7fd
[2/2] arm64: dts: qcom: sdm632-fairphone-fp3: Enable vibrator
      commit: ffaa4b5d5d07aed600d82929d8862263ce341a71

Best regards,