| Message ID | 20240407-samsung-galaxy-zfold5-q5q-v4-0-8b67b1813653@yahoo.com |
|---|---|
| Headers | show |
| Series | Samsung Galaxy Z Fold5 initial support | expand |
On 07/04/2024 07:38, Alexandru Marc Serdeliuc via B4 Relay wrote: > From: Alexandru Marc Serdeliuc <serdeliuk@yahoo.com> > > Add support for Samsung Galaxy Z Fold5 (q5q) foldable phone based on sm8550 > > Currently working features: > - Framebuffer > - UFS > - i2c > - Buttons > > Signed-off-by: Alexandru Marc Serdeliuc <serdeliuk@yahoo.com> > --- > arch/arm64/boot/dts/qcom/Makefile | 1 + Where is the changelog? This is v4 and nothing (neither here nor in cover letter) explained what was happening with this patchset. Tags were ignored, so maybe comments as well? Please provide *full* and detailed changelog. Best regards, Krzysztof
Hi, please excuse my lack of knowledge, I am still trying to figure out how to properly send a patch. Hopefully not wasting your time too much. Here is what was changed, or I should send a v5 and add the modifications to cover letter? - v4 . removed a spurious new line . removed pcie_1_phy_aux_clk as requested . removed secondary pcie1 which does not exists on the device . changed firmware extension from .mbn to .mdt . added missing reserved memory regions required by firmware to properly load - v3 . added b4 version 3 . removed address and size cells in device description - v2 added both but added an extra v2 in the subject line instead to b4 subject header, was requested to send the patch again, along with following mods: . removed whole bootargs line . fixed underscores in reserved memory by removing all reserved memory regions . added missing idetation to spash_screen remark . validated the dts with "dtbs_check" . removed all comments at the end of nodes . moved status of the node at the end of the node . reversed pin control name with control numbers . ordered the nodes alphabetically - The initial request was split in two patches sent due to the following checkpatch warning, was requested to re send them together: WARNING: DT binding docs and includes should be a separate patch. See: Documentation/devicetree/bindings/submitting-patches.rst On 7/4/24 11:03, Krzysztof Kozlowski wrote: > On 07/04/2024 07:38, Alexandru Marc Serdeliuc via B4 Relay wrote: >> From: Alexandru Marc Serdeliuc <serdeliuk@yahoo.com> >> >> Add support for Samsung Galaxy Z Fold5 (q5q) foldable phone based on sm8550 >> >> Currently working features: >> - Framebuffer >> - UFS >> - i2c >> - Buttons >> >> Signed-off-by: Alexandru Marc Serdeliuc <serdeliuk@yahoo.com> >> --- >> arch/arm64/boot/dts/qcom/Makefile | 1 + > Where is the changelog? This is v4 and nothing (neither here nor in > cover letter) explained what was happening with this patchset. > > Tags were ignored, so maybe comments as well? > > Please provide *full* and detailed changelog. > > Best regards, > Krzysztof >
On 07/04/2024 11:21, Alexandru Serdeliuc wrote: > I am terribly sorry, this is my first patch sent here, I am still > trying to understand what and how to do it. > > How to proceed with those missing tags? i should create a v5 and add them? > You need to add them. Please read the document I linked. Best regards, Krzysztof
On Sun, 07 Apr 2024 07:38:12 +0200, Alexandru Marc Serdeliuc wrote: > - removed extraneous new line > - removed pcie_1_phy_aux_clk > - removed extranous pcie1 > > This documents and add intial dts support for Samsung Galaxy Z Fold5 (samsung,q5q) > which is a foldable phone by Samsung based on the sm8550 SoC. > > Currently working features: > - Framebuffer > - UFS > - i2c > - Buttons > > Signed-off-by: Alexandru Marc Serdeliuc <serdeliuk@yahoo.com> > --- > Alexandru Marc Serdeliuc (2): > dt-bindings: arm: qcom: Document the Samsung Galaxy Z Fold5 > arm64: dts: qcom: sm8550: Add support for Samsung Galaxy Z Fold5 > > Documentation/devicetree/bindings/arm/qcom.yaml | 1 + > arch/arm64/boot/dts/qcom/Makefile | 1 + > arch/arm64/boot/dts/qcom/sm8550-samsung-q5q.dts | 593 ++++++++++++++++++++++++ > 3 files changed, 595 insertions(+) > --- > base-commit: 39cd87c4eb2b893354f3b850f916353f2658ae6f > change-id: 20240407-samsung-galaxy-zfold5-q5q-ab1fdb3df966 > > Best regards, > -- > Alexandru Marc Serdeliuc <serdeliuk@yahoo.com> > > > My bot found new DTB warnings on the .dts files added or changed in this series. Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings are fixed by another series. Ultimately, it is up to the platform maintainer whether these warnings are acceptable or not. No need to reply unless the platform maintainer has comments. If you already ran DT checks and didn't see these error(s), then make sure dt-schema is up to date: pip3 install dtschema --upgrade New warnings running 'make CHECK_DTBS=y qcom/sm8550-samsung-q5q.dtb' for 20240407-samsung-galaxy-zfold5-q5q-v4-0-8b67b1813653@yahoo.com: arch/arm64/boot/dts/qcom/sm8550-samsung-q5q.dtb: pcie-1-phy-aux-clk: 'clock-frequency' is a required property from schema $id: http://devicetree.org/schemas/clock/fixed-clock.yaml# arch/arm64/boot/dts/qcom/sm8550-samsung-q5q.dtb: phy@1c0e000: clock-output-names: ['pcie1_pipe_clk'] is too short from schema $id: http://devicetree.org/schemas/phy/qcom,sc8280xp-qmp-pcie-phy.yaml# arch/arm64/boot/dts/qcom/sm8550-samsung-q5q.dtb: phy@1c0e000: #clock-cells:0:0: 1 was expected from schema $id: http://devicetree.org/schemas/phy/qcom,sc8280xp-qmp-pcie-phy.yaml#
Hi! > - removed extraneous new line > - removed pcie_1_phy_aux_clk > - removed extranous pcie1 > > This documents and add intial dts support for Samsung Galaxy Z Fold5 (samsung,q5q) > which is a foldable phone by Samsung based on the sm8550 SoC. > > Currently working features: > - Framebuffer > - UFS > - i2c > - Buttons Interesting, folding will be fun to play with. Please cc phone-devel@vger.kernel.org with phone patches. Best regards, Pavel
- removed extraneous new line - removed pcie_1_phy_aux_clk - removed extranous pcie1 This documents and add intial dts support for Samsung Galaxy Z Fold5 (samsung,q5q) which is a foldable phone by Samsung based on the sm8550 SoC. Currently working features: - Framebuffer - UFS - i2c - Buttons Signed-off-by: Alexandru Marc Serdeliuc <serdeliuk@yahoo.com> --- Alexandru Marc Serdeliuc (2): dt-bindings: arm: qcom: Document the Samsung Galaxy Z Fold5 arm64: dts: qcom: sm8550: Add support for Samsung Galaxy Z Fold5 Documentation/devicetree/bindings/arm/qcom.yaml | 1 + arch/arm64/boot/dts/qcom/Makefile | 1 + arch/arm64/boot/dts/qcom/sm8550-samsung-q5q.dts | 593 ++++++++++++++++++++++++ 3 files changed, 595 insertions(+) --- base-commit: 39cd87c4eb2b893354f3b850f916353f2658ae6f change-id: 20240407-samsung-galaxy-zfold5-q5q-ab1fdb3df966 Best regards,