| Message ID | 20240311-alpha-pll-stromer-cleanup-v1-0-f7c0c5607cca@gmail.com |
|---|---|
| Headers | show |
| Series | clk: qcom: clk-alpha-pll: Stromer register cleanup | expand |
On 3/11/24 19:45, Gabor Juhos wrote: > The offset of the CONFIG_CTL_U register defined for the Stromer > PLL is wrong. It is not aligned on a 4 bytes boundary which might > causes errors in regmap operations. > > Maybe the intention behind of using the 0xff value was to indicate > that the register is not implemented in the PLL, but this is not > verified anywhere in the code. Moreover, this value is not used > even in other register offset arrays despite that those PLLs also > have unimplemented registers. > > Additionally, on the Stromer PLLs the current code only touches > the CONFIG_CTL_U register if the result of pll_has_64bit_config() > is true which condition is not affected by the change. > > Due to the reasons above, simply remove the CONFIG_CTL_U entry > from the Stromer specific array. > > Fixes: e47a4f55f240 ("clk: qcom: clk-alpha-pll: Add support for Stromer PLLs") > Signed-off-by: Gabor Juhos <j4g8y7@gmail.com> > --- Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> Konrad>
On Mon, 11 Mar 2024 19:45:18 +0100, Gabor Juhos wrote: > This small set contains two patches which are intended to clean > up the Stromer specific register offsets in 'clk_alpha_pll_regs' > a bit. > > Based on v6.8. > > > [...] Applied, thanks! [1/2] clk: qcom: clk-alpha-pll: remove invalid Stromer register offset commit: 4f2bc4acbb1916b8cd2ce4bb3ba7b1cd7cb705fa [2/2] clk: qcom: clk-alpha-pll: reorder Stromer register offsets commit: 8c48466cd7eda9afb37f26c8c9a68f39fae5ef32 Best regards,
This small set contains two patches which are intended to clean up the Stromer specific register offsets in 'clk_alpha_pll_regs' a bit. Based on v6.8. Signed-off-by: Gabor Juhos <j4g8y7@gmail.com> --- Gabor Juhos (2): clk: qcom: clk-alpha-pll: remove invalid Stromer register offset clk: qcom: clk-alpha-pll: reorder Stromer register offsets drivers/clk/qcom/clk-alpha-pll.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) --- base-commit: e8f897f4afef0031fe618a8e94127a0934896aba change-id: 20240311-alpha-pll-stromer-cleanup-01b577e75264 Best regards,