From patchwork Mon Feb 26 02:27:58 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Baryshkov X-Patchwork-Id: 775999 Received: from mail-lj1-f177.google.com (mail-lj1-f177.google.com [209.85.208.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 704841773D for ; Mon, 26 Feb 2024 02:28:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708914484; cv=none; b=s2fiXx6+QVsXiZ3qKknPxzZMPNMzxuP09oALI/QscBK40Gw1rrI2FAW0bsz2RZz16ntW0IIJHYbkQxDeWU36OC0d1FHQTxYYmrnLRn4R5wAnetwLqNNB8/wuEJpxQsZPi4+p3r6Y1y0pyDljkoZ/zeJSRWL4bbe3Xa3l0diXSB0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708914484; c=relaxed/simple; bh=u8jCfED3AAIM0Dr6uUkSBL8XcOIWg1vYet7ORyo2cy0=; h=From:Subject:Date:Message-Id:MIME-Version:Content-Type:To:Cc; b=eFWNezDhTIok08Ayn0qWZRhjEJcgHHAKijMEdrLsAgv/jY2rLTj2CwFeSyo0lE9iv7F48Tmu1MDVMAGwCbN1S2uoiqsBh16LymWh5enD9IqqX2LDU9R7j6o3hrtxLNB5ceVtn7IiqEROaQtG3mk3jbo479mLfAcqH8xFQiIMBBM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=x3vuep3M; arc=none smtp.client-ip=209.85.208.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="x3vuep3M" Received: by mail-lj1-f177.google.com with SMTP id 38308e7fff4ca-2d28e465655so2042781fa.0 for ; Sun, 25 Feb 2024 18:28:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1708914480; x=1709519280; darn=vger.kernel.org; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:from:to:cc:subject:date:message-id:reply-to; bh=okMwD+HI3Hm1J7uyI3T50cIUeGmA4G9Oagnd36eStaI=; b=x3vuep3MxtYTykD2gVl+64Yxz1qwiD9YxoszEr0y6848r9jpufD0VUZeSalbudqt5f nT9XbQGvZZFdIbD7xJp5ibjElI7eTEqt4JPEpgX2cTZzEukN4b+o9ZBUZzbsCyGS7RtI CyWQI9WDBTr54RkinqRB53cYCXY5DCboJ7FWSSstpuHq7arl4yVIp9A1Q4I3I7YWu0ND /g7ADVpxooInb592MUDBEnT7FOwRwJfHGwK+7sY5GFpVwNJAD/nZkJnDLokCQgus70gU 2EfpOB5SNCDtTKltZUfbJijsKO1lQIElL6hXioi4h7y5rTLlUcdyvv/480uknskSbMjM cfdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708914480; x=1709519280; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=okMwD+HI3Hm1J7uyI3T50cIUeGmA4G9Oagnd36eStaI=; b=IWrG7kwS9CkbP5Okg/JbyCgrMQsm0as0CsIvPWefmqJcXppESiqj6wZSfIseYq27RE caFSoODS52N1X6nNrbxHd2rQE/rEWKcBYfoJST41OcVHnKcnnOvLtjungbQidFdHsa31 LEX5vl25FxNeKbdCknMBcRboZQfcT8I5WlZLxYrOHUywYh1t8peXoVc7XJ62yW7YsIwE 04PmPAOvypKNAvwoB2rgE1GnfN2PLhRa0hZMwgDo4lYkKcW4EZ/4RBg7m2pdFFVYpqP9 Xwt2NFMDB5FCbwwPT8m7qT5nlRWiBV5P4mVBO1QHYNELEjYBSa9IlIEv+Z6lEmCtRtL5 pLxg== X-Forwarded-Encrypted: i=1; AJvYcCX2JKQTbdryJh/7TC9hIdPrySTeVE+pM0DdRtXdEJvrEDnK9kutfiO0RClwUcMe5ubfU4L506LFQTVfhtFggia+grMLJzXDqK2WQ79yDQ== X-Gm-Message-State: AOJu0Yxvb1ZEQEwbSJgrFiYm38TTEifSWtIdO3GODGusuY5RcmY8mqBg MuEZeUQ2Mp1kbczuCPdfgYKaTIMXXPtJKTaoR96FlRxEQAL02lF99N6Zo5uWnqk= X-Google-Smtp-Source: AGHT+IFGLuNRRkqyJ84YiBMteFx/W6fawxgt5SBqlorHTEGoOuvKsKcz8VAynwdAnzKsErvRBTJm4g== X-Received: by 2002:a2e:8e90:0:b0:2d2:7813:6ca0 with SMTP id z16-20020a2e8e90000000b002d278136ca0mr2918485ljk.7.1708914480645; Sun, 25 Feb 2024 18:28:00 -0800 (PST) Received: from umbar.lan (dzyjmhybhls-s--zn36gy-3.rev.dnainternet.fi. [2001:14ba:a00e:a300:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id u19-20020a2e8553000000b002d11ef66881sm713092ljj.91.2024.02.25.18.28.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 25 Feb 2024 18:28:00 -0800 (PST) From: Dmitry Baryshkov Subject: [PATCH v4 0/3] drm/msm/dpu: debug commit_done timeouts Date: Mon, 26 Feb 2024 04:27:58 +0200 Message-Id: <20240226-fd-dpu-debug-timeout-v4-0-51eec83dde23@linaro.org> Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-B4-Tracking: v=1; b=H4sIAC7322UC/4XNTQ6CMBCG4auQrh3TDlCKK+9hXEB/oIlS0gLRE O5uYaPGEJfvl8wzMwnaWx3IKZmJ15MN1nUxskNCZFt1jQarYhOkmFFGORgFqh9B6XpsYLB37cY BdMkKQ2spKE9JPO29NvaxsZdr7NaGwfnn9mVi6/oHnBgw4KosOAqR8Yydb7arvDs635BVnPCtI BU7CkalNCUtDKuVEsWPkn4omO8oKVDAHA3WyKSS8ktZluUFfP0DdkUBAAA= To: Rob Clark , Abhinav Kumar , Sean Paul , Marijn Suijten , David Airlie , Daniel Vetter Cc: Steev Klimaszewski , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org X-Mailer: b4 0.13.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1646; i=dmitry.baryshkov@linaro.org; h=from:subject:message-id; bh=u8jCfED3AAIM0Dr6uUkSBL8XcOIWg1vYet7ORyo2cy0=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBl2/cvswuEB9zryNmyO7i/5aXauDX8QwQLWQAka RMUD4mkizCJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCZdv3LwAKCRCLPIo+Aiko 1TlDB/43tK/bein7ge2pajmcDIVMZuxTdeAV4isVizetYKrBenH9uItcj3p7VUY5u4Le4CJ3cpC 4kqF5hevPGzVDS/4TjVU2RAkY2DUAmIi0OFReena7J5OipQJOlRSyA8oxkM3TeO/R4eDcQpr7Vd rE4g14bhQtAZLWhJj18qeNmjsVNArxwl4GnTI1AkA6c3zxc7w6n5rd4Cs4ct3ZyBxjimMuiRmz+ xwyzV5zcU8TVItaS3wEY61WNdDAL4zc55MgwQJ9bXYOjyWhZvMuvrvYpy0Pi48UX04OeN5btAPq xPX1K46ZWpznAtBJFSSwBy6qtVd56Xc06jbR3FnFNdwycecb X-Developer-Key: i=dmitry.baryshkov@linaro.org; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A In order to debug commit_done timeouts ([1]) display the sticky bits of the CTL_FLUSH register and capture the devcore dump when the first such timeout occurs. [1] https://gitlab.freedesktop.org/drm/msm/-/issues/33 Signed-off-by: Dmitry Baryshkov --- Changes in v4: - Reworded documentation for new funcsions (Abhinav) - Link to v3: https://lore.kernel.org/r/20240225-fd-dpu-debug-timeout-v3-0-252f2b21cdcc@linaro.org Changes in v3: - Capture the snapshot only on the first comit_done timeout (Abhinav) - Link to v2: https://lore.kernel.org/r/20240208-fd-dpu-debug-timeout-v2-1-9f907f1bdd87@linaro.org Changes in v2: - Added a call to msm_disp_snapshot_state() to trigger devcore dump (Abhinav) - Link to v1: https://lore.kernel.org/r/20240106-fd-dpu-debug-timeout-v1-1-6d9762884641@linaro.org --- Dmitry Baryshkov (3): drm/msm/dpu: make "vblank timeout" more useful drm/msm/dpu: split dpu_encoder_wait_for_event into two functions drm/msm/dpu: capture snapshot on the first commit_done timeout drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 79 ++++++++++++++++------ drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.h | 22 +----- .../gpu/drm/msm/disp/dpu1/dpu_encoder_phys_vid.c | 2 +- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 2 +- drivers/gpu/drm/msm/msm_drv.h | 10 --- 5 files changed, 65 insertions(+), 50 deletions(-) --- base-commit: 33e1d31873f87d119e5120b88cd350efa68ef276 change-id: 20240106-fd-dpu-debug-timeout-e917f0bc8063 Best regards,