mbox series

[0/3] arm64: dts: qcom: fix USB wakeup interrupts again (pt 2)

Message ID 20231214074319.11023-1-johan+linaro@kernel.org
Headers show
Series arm64: dts: qcom: fix USB wakeup interrupts again (pt 2) | expand

Message

Johan Hovold Dec. 14, 2023, 7:43 a.m. UTC
The USB DP/DM HS PHY interrupts need to be provided by the PDC interrupt
controller in order to be able to wake the system up from low-power
states and to be able to detect disconnect events, which requires
triggering on falling edges.

A recent commit updated the trigger type but failed to change the
interrupt provider as required. This leads to the current Linux driver
failing to probe instead of printing an error during suspend and USB
wakeup not working as intended.

While at it, fix also the SS PHY interrupt so that it too can be used to
wakeup the system up.

Thanks to Konrad and Krishna for providing the sdm670 PDC interrupts
numbers. The sc8180x SS PHY vectors I inferred from sdm670/sdm845/sm8150
which appear to use the name configuration.

After this series, only sm6375 remains to be fixed and I believe Bjorn
is trying to dig out the corresponding vectors.

Also note that these patches have only been compile tested.

Johan


Johan Hovold (3):
  arm64: dts: qcom: sdm670: fix USB DP/DM HS PHY interrupts
  arm64: dts: qcom: sdm670: fix USB SS wakeup
  arm64: dts: qcom: sc8180x: fix USB SS wakeup

 arch/arm64/boot/dts/qcom/sc8180x.dtsi | 4 ++--
 arch/arm64/boot/dts/qcom/sdm670.dtsi  | 8 ++++----
 2 files changed, 6 insertions(+), 6 deletions(-)

Comments

Richard Acayan Dec. 15, 2023, 1:46 a.m. UTC | #1
On Thu, Dec 14, 2023 at 08:43:18AM +0100, Johan Hovold wrote:
> The USB SS PHY interrupt needs to be provided by the PDC interrupt
> controller in order to be able to wake the system up from low-power
> states.
>
> Fixes: 07c8ded6e373 ("arm64: dts: qcom: add sdm670 and pixel 3a device trees")
> Cc: stable@vger.kernel.org      # 6.2
> Cc: Richard Acayan <mailingradian@gmail.com>
> Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
> ---

Tested-by: Richard Acayan <mailingradian@gmail.com>
Bjorn Andersson Dec. 19, 2023, 7:33 p.m. UTC | #2
On Thu, 14 Dec 2023 08:43:16 +0100, Johan Hovold wrote:
> The USB DP/DM HS PHY interrupts need to be provided by the PDC interrupt
> controller in order to be able to wake the system up from low-power
> states and to be able to detect disconnect events, which requires
> triggering on falling edges.
> 
> A recent commit updated the trigger type but failed to change the
> interrupt provider as required. This leads to the current Linux driver
> failing to probe instead of printing an error during suspend and USB
> wakeup not working as intended.
> 
> [...]

Applied, thanks!

[1/3] arm64: dts: qcom: sdm670: fix USB DP/DM HS PHY interrupts
      commit: c42d12ea105f67b0f137f1e52d5c59d13fe12b1f
[2/3] arm64: dts: qcom: sdm670: fix USB SS wakeup
      commit: 047b2edc35b8db22354b4fba37818b548fc18896
[3/3] arm64: dts: qcom: sc8180x: fix USB SS wakeup
      commit: 0afa885d42d05d30161ab8eab1ebacd993edb82b

Best regards,