mbox series

[0/1] Switch on USB as a wakeup source on sm8250

Message ID 20231109004311.2449566-1-bryan.odonoghue@linaro.org
Headers show
Series Switch on USB as a wakeup source on sm8250 | expand

Message

Bryan O'Donoghue Nov. 9, 2023, 12:43 a.m. UTC 
Add in wakeup-source to both USB controllers on sm8250.

I tested that the rb5 gets into and stays in s2idle, subsequently resuming
when a key is pressed on an attached USB keyboard for both Type-A USB 3
ports and via the TCPM controlled Type-C port.

Bryan O'Donoghue (1):
  arm64: dts: qcom: sm8250: Add wakeup-source to usb_1 and usb_2

 arch/arm64/boot/dts/qcom/sm8250.dtsi | 2 ++
 1 file changed, 2 insertions(+)

Comments

Konrad Dybcio Nov. 9, 2023, 1:30 p.m. UTC | #1 
On 11/9/23 01:43, Bryan O'Donoghue wrote:
> To test out a different GDSC change I wanted to have a USB keypress resume
> a system in suspend.
> 
> Adding wakeup-source to usb_1 and usb_2 "just works" for me on rb5.
> Consistent with qcm2290 and sa8775p add wakeup-source to the dtsi for the
> SoC.
> 
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> ---
Maybe we could make it the default in qcom glue somehow..

Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad
Bjorn Andersson Dec. 8, 2023, 2:57 a.m. UTC | #2 
On Thu, 09 Nov 2023 00:43:10 +0000, Bryan O'Donoghue wrote:
> Add in wakeup-source to both USB controllers on sm8250.
> 
> I tested that the rb5 gets into and stays in s2idle, subsequently resuming
> when a key is pressed on an attached USB keyboard for both Type-A USB 3
> ports and via the TCPM controlled Type-C port.
> 
> Bryan O'Donoghue (1):
>   arm64: dts: qcom: sm8250: Add wakeup-source to usb_1 and usb_2
> 
> [...]

Applied, thanks!

[1/1] arm64: dts: qcom: sm8250: Add wakeup-source to usb_1 and usb_2
      commit: 48307d83c998db18db6890dccb569146eb12d313

Best regards,