mbox series

[V8,0/5] scsi: ufs: qcom: Align programming sequence as per HW spec

Message ID 20230905052400.13935-1-quic_nitirawa@quicinc.com
Headers show
Series scsi: ufs: qcom: Align programming sequence as per HW spec | expand

Message

Nitin Rawat Sept. 5, 2023, 5:23 a.m. UTC
This patch series adds programming support for Qualcomm UFS V4 and above
to align avoid with Hardware Specification. This patch series will address
stability and performance issues.

In this patch series below changes are taken care.

1) Register layout for DME_VS_CORE_CLK_CTRL has changed for v4 and above.
2) Adds Support to configure PA_VS_CORE_CLK_40NS_CYCLES attibute for UFS V4
   and above.
3) Adds Support to configure multiple unipro frequencies like 403MHz,
   300MHz, 202MHz, 150 MHz, 75Mhz, 37.5 MHz for Qualcomm UFS Controller V4
   and above.
4) Allow configuration of SYS1CLK_1US_REG for UFS V4 and above.

Changes From v7:
- Fix the compilation error for kernel doc

Changes from v6:
- Addressed bjorn comment to optimize the code.
- Addressed bjorn comment to update commit message
- removed clean up part related for clk div configuration comapared to v6

changes from v5:
- Addressed Mani comment to FIELD_PREP and FIELD_FIT.
- Optimised ufs_qcom_set_core_clk_ctrl API.
- Updated commit text for few patches to capture more details.

Changes from v4:
- Addressed bjorn comment to split single patch to multiple patches.

Changes from v3:
-Addressed bjorn comment to update commit msg to capture change details.

Changes from v2:
- Addressed bao comment, removed duplicate clock timer cfg API call

Changes from v1:
- Addressed bao comment, removed wrapper function
- Tab alignment

Nitin Rawat (5):
  scsi: ufs: qcom: Update MAX_CORE_CLK_1US_CYCLES for UFS V4 and above
  scsi: ufs: qcom: Add multiple frequency support for
    MAX_CORE_CLK_1US_CYCLES
  scsi: ufs: qcom: Add support to Configure PA_VS_CORE_CLK_40NS_CYCLES
  scsi: ufs: qcom: Align programing of unipro clk attributes
  scsi: ufs: qcom: Configure SYS1CLK_1US_REG for UFS V4 and above

 drivers/ufs/host/ufs-qcom.c | 202 ++++++++++++++++++++++++++++--------
 drivers/ufs/host/ufs-qcom.h |  18 +++-
 2 files changed, 175 insertions(+), 45 deletions(-)

--
2.17.1

Comments

Can Guo Sept. 11, 2023, 6:42 a.m. UTC | #1
On 9/5/2023 1:23 PM, Nitin Rawat wrote:
> This patch series adds programming support for Qualcomm UFS V4 and above
> to align avoid with Hardware Specification. This patch series will address
> stability and performance issues.
>
> In this patch series below changes are taken care.
>
> 1) Register layout for DME_VS_CORE_CLK_CTRL has changed for v4 and above.
> 2) Adds Support to configure PA_VS_CORE_CLK_40NS_CYCLES attibute for UFS V4
>     and above.
> 3) Adds Support to configure multiple unipro frequencies like 403MHz,
>     300MHz, 202MHz, 150 MHz, 75Mhz, 37.5 MHz for Qualcomm UFS Controller V4
>     and above.
> 4) Allow configuration of SYS1CLK_1US_REG for UFS V4 and above.
>
> Changes From v7:
> - Fix the compilation error for kernel doc
>
> Changes from v6:
> - Addressed bjorn comment to optimize the code.
> - Addressed bjorn comment to update commit message
> - removed clean up part related for clk div configuration comapared to v6
>
> changes from v5:
> - Addressed Mani comment to FIELD_PREP and FIELD_FIT.
> - Optimised ufs_qcom_set_core_clk_ctrl API.
> - Updated commit text for few patches to capture more details.
>
> Changes from v4:
> - Addressed bjorn comment to split single patch to multiple patches.
>
> Changes from v3:
> -Addressed bjorn comment to update commit msg to capture change details.
>
> Changes from v2:
> - Addressed bao comment, removed duplicate clock timer cfg API call
>
> Changes from v1:
> - Addressed bao comment, removed wrapper function
> - Tab alignment
>
> Nitin Rawat (5):
>    scsi: ufs: qcom: Update MAX_CORE_CLK_1US_CYCLES for UFS V4 and above
>    scsi: ufs: qcom: Add multiple frequency support for
>      MAX_CORE_CLK_1US_CYCLES
>    scsi: ufs: qcom: Add support to Configure PA_VS_CORE_CLK_40NS_CYCLES
>    scsi: ufs: qcom: Align programing of unipro clk attributes
>    scsi: ufs: qcom: Configure SYS1CLK_1US_REG for UFS V4 and above
>
>   drivers/ufs/host/ufs-qcom.c | 202 ++++++++++++++++++++++++++++--------
>   drivers/ufs/host/ufs-qcom.h |  18 +++-
>   2 files changed, 175 insertions(+), 45 deletions(-)
>
> --
> 2.17.1

To the whole series -

Reviewed-by: Can Guo <quic_cang@quicinc.com>
Martin K. Petersen Sept. 14, 2023, 1:16 a.m. UTC | #2
Nitin,

> This patch series adds programming support for Qualcomm UFS V4 and
> above to align avoid with Hardware Specification. This patch series
> will address stability and performance issues.

Applied to 6.7/scsi-staging, thanks!