| Message ID | 20230824211952.1397699-1-dmitry.baryshkov@linaro.org |
|---|---|
| Headers | show |
| Series | phy: qcom-qmp-usb: convert to newer style of bindings | expand |
On Fri, 25 Aug 2023 00:19:36 +0300, Dmitry Baryshkov wrote: > Reviewing several patchsets for newer platforms made it clear that > having two styles of QMP PHY bindings causes confusion. Despite binding > documents having notes telling that old bindings should be used for > older platforms, it is too easy to attempt adding new platform with > older QMP PHY binding. Thus let's have just a single documented style of > bindings. > > [...] Applied, thanks! [01/16] dt-bindings: phy: migrate QMP USB PHY bindings to qcom,sc8280xp-qmp-usb3-uni-phy.yaml commit: 15c83637402c3654dbc7aac368119c3809a119fa [02/16] phy: qcom-qmp-usb: simplify clock handling commit: 7233090aba54d82a1ed64f125b32c3ac0b91803c [03/16] phy: qcom-qmp-usb: rework reset handling commit: fcf63482f6a9d383f04e409bc50f00eecb74ae73 [04/16] phy: qcom-qmp-usb: make QPHY_PCS_MISC_CLAMP_ENABLE access conditional commit: 6e9402261e8c85ec386b473ce3738d6e9d3e5013 [05/16] phy: qcom-qmp: move PCS MISC V4 registers to separate header commit: dc32762214e4bb683bfb21dcb4ade10e27e11c6d [06/16] phy: qcom-qmp-usb: populate offsets configuration commit: 2be22aae6b18326426443d6c0cc9ac6985183a89 Best regards,
Reviewing several patchsets for newer platforms made it clear that having two styles of QMP PHY bindings causes confusion. Despite binding documents having notes telling that old bindings should be used for older platforms, it is too easy to attempt adding new platform with older QMP PHY binding. Thus let's have just a single documented style of bindings. Proposed merge strategy: immutable branch with binding and PHY patches, which can also be merged into Bjorn's dts-for-6.7 Changes since v2: - Added maxItems to qcom,ipq9574-qmp-usb3-phy / clocks so that the clocks array size is always properly constrained (Krzysztof) - Dropped rogue PCIe PHY chunk from msm8998 patch. Changes since v1: - Split large patchset into smaller parts - Rebased on phy/next - Reworked bindings to follow the common standard rather than blindly moving the PHY contents. Dmitry Baryshkov (16): dt-bindings: phy: migrate QMP USB PHY bindings to qcom,sc8280xp-qmp-usb3-uni-phy.yaml phy: qcom-qmp-usb: simplify clock handling phy: qcom-qmp-usb: rework reset handling phy: qcom-qmp-usb: make QPHY_PCS_MISC_CLAMP_ENABLE access conditional phy: qcom-qmp: move PCS MISC V4 registers to separate header phy: qcom-qmp-usb: populate offsets configuration arm64: dts: qcom: ipq6018: switch USB QMP PHY to new style of bindings arm64: dts: qcom: ipq8074: switch USB QMP PHY to new style of bindings arm64: dts: qcom: msm8996: switch USB QMP PHY to new style of bindings arm64: dts: qcom: msm8998: switch USB QMP PHY to new style of bindings arm64: dts: qcom: sdm845: switch USB QMP PHY to new style of bindings arm64: dts: qcom: sm8150: switch USB QMP PHY to new style of bindings arm64: dts: qcom: sm8250: switch USB QMP PHY to new style of bindings arm64: dts: qcom: sm8350: switch USB QMP PHY to new style of bindings ARM: dts: qcom-sdx55: switch USB QMP PHY to new style of bindings ARM: dts: qcom-sdx65: switch USB QMP PHY to new style of bindings .../phy/qcom,msm8996-qmp-usb3-phy.yaml | 287 ------------------ .../phy/qcom,sc8280xp-qmp-usb3-uni-phy.yaml | 55 +++- arch/arm/boot/dts/qcom/qcom-sdx55.dtsi | 41 ++- arch/arm/boot/dts/qcom/qcom-sdx65.dtsi | 35 +-- arch/arm64/boot/dts/qcom/ipq6018.dtsi | 35 +-- arch/arm64/boot/dts/qcom/ipq8074.dtsi | 76 ++--- arch/arm64/boot/dts/qcom/msm8996.dtsi | 40 ++- arch/arm64/boot/dts/qcom/msm8998.dtsi | 35 +-- arch/arm64/boot/dts/qcom/sdm845.dtsi | 39 ++- arch/arm64/boot/dts/qcom/sm8150.dtsi | 39 +-- arch/arm64/boot/dts/qcom/sm8250.dtsi | 38 +-- arch/arm64/boot/dts/qcom/sm8350.dtsi | 39 +-- .../phy/qualcomm/phy-qcom-qmp-pcs-misc-v4.h | 17 ++ drivers/phy/qualcomm/phy-qcom-qmp-usb.c | 225 +++++++------- drivers/phy/qualcomm/phy-qcom-qmp.h | 8 - 15 files changed, 352 insertions(+), 657 deletions(-) delete mode 100644 Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-usb3-phy.yaml create mode 100644 drivers/phy/qualcomm/phy-qcom-qmp-pcs-misc-v4.h