| Message ID | 20230820142035.89903-1-dmitry.baryshkov@linaro.org |
|---|---|
| Headers | show |
| Series | phy: qcom-qmp-pcie: convert to newer style of bindings | expand |
On 20/08/2023 16:20, Dmitry Baryshkov wrote: > Migrate legacy bindings (described in qcom,ipq8074-qmp-pcie-phy.yaml) > to qcom,sc8280xp-qmp-pcie-phy.yaml. This removes a need to declare > the child PHY node or split resource regions. > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > --- Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On Sun, 20 Aug 2023 17:20:17 +0300, Dmitry Baryshkov wrote: > Reviewing several patchsets for newer platforms made it clear that > having two styles of QMP PHY bindings causes confusion. Despite binding > documents having notes telling that old bindings should be used for > older platforms, it is too easy to attempt adding new platform with > older QMP PHY binding. Thus let's have just a single documented style of > bindings. > > [...] Applied, thanks! [01/18] dt-bindings: phy: migrate QMP PCIe PHY bindings to qcom,sc8280xp-qmp-pcie-phy.yaml commit: 505fb2541678944ae90e110088811eebba883efd [02/18] dt-bindings: phy: qcom,qmp-pcie: describe SM8150 PCIe PHYs commit: 377107bcc64a446e017939cf6b59bb97873cf967 [03/18] phy: qcom-qmp-pcie: drop ln_shrd from v5_20 config commit: cfe0d203813420e643db08264679982a31fea95c [04/18] phy: qcom-qmp-pcie: keep offset tables sorted commit: 86f703762a9b6c1a8e3ce9fd62fd5353379be3a0 [05/18] phy: qcom-qmp-pcie: simplify clock handling commit: 067832dc0387f12d264f449f9eba63cb587c21c6 [06/18] phy: qcom-qmp-pcie: populate offsets configuration commit: bf46fa1dafacebedb9de56626fdfa71e6198cfd7 [07/18] phy: qcom-qmp-pcie: support SM8150 PCIe QMP PHYs commit: 4807ff70e228b5e9c6ea6c7c5651a3fd74a5cfda Best regards,
Reviewing several patchsets for newer platforms made it clear that having two styles of QMP PHY bindings causes confusion. Despite binding documents having notes telling that old bindings should be used for older platforms, it is too easy to attempt adding new platform with older QMP PHY binding. Thus let's have just a single documented style of bindings. Proposed merge strategy: immutable branch with binding and PHY patches, which can also be merged into Bjorn's dts-for-6.7 Changes since v2: - Split away patches for sm8150 PHYs. Add missing driver bits to enable PCIe PHY support on sm8150 (were submitted by Bhupesh in May 2022, only DT bits were merged) - Fixed v5.20 offsets merged earlier. Fixed merge conflict due to their addition - Fixed clocks / clock-names alignment in ipq8074.dtsi / sc7280.dtsi (Konrad) - Fixed PHY DT names and resource address for sc8180x (Konrad) Changes since v1: - Split large patchset into smaller parts - Rebased on phy/next Dmitry Baryshkov (18): dt-bindings: phy: migrate QMP PCIe PHY bindings to qcom,sc8280xp-qmp-pcie-phy.yaml dt-bindings: phy: qcom,qmp-pcie: describe SM8150 PCIe PHYs phy: qcom-qmp-pcie: drop ln_shrd from v5_20 config phy: qcom-qmp-pcie: keep offset tables sorted phy: qcom-qmp-pcie: simplify clock handling phy: qcom-qmp-pcie: populate offsets configuration phy: qcom-qmp-pcie: support SM8150 PCIe QMP PHYs arm64: dts: qcom: ipq6018: switch PCIe QMP PHY to new style of bindings arm64: dts: qcom: ipq8074: switch PCIe QMP PHY to new style of bindings arm64: dts: qcom: msm8998: switch PCIe QMP PHY to new style of bindings arm64: dts: qcom: sc7280: switch PCIe QMP PHY to new style of bindings arm64: dts: qcom: sc8180x: switch PCIe QMP PHY to new style of bindings arm64: dts: qcom: sdm845: switch PCIe QMP PHY to new style of bindings arm64: dts: qcom: sm8150: add ref clock to PCIe PHYs arm64: dts: qcom: sm8150: switch PCIe QMP PHY to new style of bindings arm64: dts: qcom: sm8250: switch PCIe QMP PHY to new style of bindings arm64: dts: qcom: sm8450: switch PCIe QMP PHY to new style of bindings ARM: dts: qcom-sdx55: switch PCIe QMP PHY to new style of bindings .../phy/qcom,ipq8074-qmp-pcie-phy.yaml | 278 +++--------------- .../phy/qcom,msm8998-qmp-pcie-phy.yaml | 97 ++++++ .../phy/qcom,sc8280xp-qmp-pcie-phy.yaml | 36 ++- arch/arm/boot/dts/qcom/qcom-sdx55.dtsi | 31 +- arch/arm64/boot/dts/qcom/ipq6018.dtsi | 32 +- arch/arm64/boot/dts/qcom/ipq8074.dtsi | 67 ++--- arch/arm64/boot/dts/qcom/msm8998.dtsi | 30 +- arch/arm64/boot/dts/qcom/sc7280.dtsi | 40 +-- arch/arm64/boot/dts/qcom/sc8180x.dtsi | 148 ++++------ arch/arm64/boot/dts/qcom/sdm845.dtsi | 71 ++--- arch/arm64/boot/dts/qcom/sm8150.dtsi | 70 ++--- arch/arm64/boot/dts/qcom/sm8250.dtsi | 112 +++---- arch/arm64/boot/dts/qcom/sm8450.dtsi | 82 +++--- drivers/phy/qualcomm/phy-qcom-qmp-pcie.c | 177 ++++++----- 14 files changed, 537 insertions(+), 734 deletions(-) create mode 100644 Documentation/devicetree/bindings/phy/qcom,msm8998-qmp-pcie-phy.yaml