[V1,0/2] Add Phy Configuration support for SC7280

This patch adds Phy configuration support for Qualcomm SC7280 SOC.

Nitin Rawat (2):
  dt-bindings: phy: Add QMP UFS PHY comptible for SC7280
  phy: qcom-qmp-ufs: Add Phy Configuration support for SC7280

 .../phy/qcom,sc8280xp-qmp-ufs-phy.yaml        |   2 +
 drivers/phy/qualcomm/phy-qcom-qmp-ufs.c       | 142 ++++++++++++++++++
 2 files changed, 144 insertions(+)

--
2.17.1

On Wed, 16 Aug 2023 at 18:50, Nitin Rawat <quic_nitirawa@quicinc.com> wrote:
>
> Document the QMP UFS PHY compatible for SC7280.
>
> Signed-off-by: Nitin Rawat <quic_nitirawa@quicinc.com>
> ---
>  .../devicetree/bindings/phy/qcom,sc8280xp-qmp-ufs-phy.yaml      | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-ufs-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-ufs-phy.yaml
> index d981d77e82e4..ad78da9c2c1a 100644
> --- a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-ufs-phy.yaml
> +++ b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-ufs-phy.yaml
> @@ -31,6 +31,7 @@ properties:
>        - qcom,sm8350-qmp-ufs-phy
>        - qcom,sm8450-qmp-ufs-phy
>        - qcom,sm8550-qmp-ufs-phy
> +      - qcom,sc7280-qmp-ufs-phy
>
>    reg:
>      maxItems: 1
> @@ -110,6 +111,7 @@ allOf:
>                - qcom,sm8250-qmp-ufs-phy
>                - qcom,sm8350-qmp-ufs-phy
>                - qcom,sm8550-qmp-ufs-phy
> +              - qcom,sc7280-qmp-ufs-phy

Please keep both lists sorted.

>      then:
>        properties:
>          clocks:
> --
> 2.17.1
>

On 16-08-23, 23:31, Dmitry Baryshkov wrote:
> On Wed, 16 Aug 2023 at 18:50, Nitin Rawat <quic_nitirawa@quicinc.com> wrote:
> >
> > Document the QMP UFS PHY compatible for SC7280.
> >
> > Signed-off-by: Nitin Rawat <quic_nitirawa@quicinc.com>
> > ---
> >  .../devicetree/bindings/phy/qcom,sc8280xp-qmp-ufs-phy.yaml      | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-ufs-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-ufs-phy.yaml
> > index d981d77e82e4..ad78da9c2c1a 100644
> > --- a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-ufs-phy.yaml
> > +++ b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-ufs-phy.yaml
> > @@ -31,6 +31,7 @@ properties:
> >        - qcom,sm8350-qmp-ufs-phy
> >        - qcom,sm8450-qmp-ufs-phy
> >        - qcom,sm8550-qmp-ufs-phy
> > +      - qcom,sc7280-qmp-ufs-phy
> >
> >    reg:
> >      maxItems: 1
> > @@ -110,6 +111,7 @@ allOf:
> >                - qcom,sm8250-qmp-ufs-phy
> >                - qcom,sm8350-qmp-ufs-phy
> >                - qcom,sm8550-qmp-ufs-phy
> > +              - qcom,sc7280-qmp-ufs-phy
> 
> Please keep both lists sorted.

Yes please

On 16/08/2023 17:48, Nitin Rawat wrote:
> Document the QMP UFS PHY compatible for SC7280.
> 
> Signed-off-by: Nitin Rawat <quic_nitirawa@quicinc.com>
> ---

Please use scripts/get_maintainers.pl to get a list of necessary people
and lists to CC. It might happen, that command when run on an older
kernel, gives you outdated entries. Therefore please be sure you base
your patches on recent Linux kernel.

You missed at least DT list (maybe more), so this won't be tested by
automated tooling. Performing review on untested code might be a waste
of time, thus I will skip this patch entirely till you follow the
process allowing the patch to be tested.

Please kindly resend and include all necessary To/Cc entries.

Best regards,
Krzysztof

Hi Krzysztof,

Sorry for the inconvenience . I have addressed other reviewers comments 
and have resent the latest patchset to all the intended To/Cc entries.


Thanks,
Nitin


On 8/18/2023 4:04 PM, Krzysztof Kozlowski wrote:
> On 16/08/2023 17:48, Nitin Rawat wrote:
>> Document the QMP UFS PHY compatible for SC7280.
>>
>> Signed-off-by: Nitin Rawat <quic_nitirawa@quicinc.com>
>> ---
> 
> Please use scripts/get_maintainers.pl to get a list of necessary people
> and lists to CC. It might happen, that command when run on an older
> kernel, gives you outdated entries. Therefore please be sure you base
> your patches on recent Linux kernel.
> 
> You missed at least DT list (maybe more), so this won't be tested by
> automated tooling. Performing review on untested code might be a waste
> of time, thus I will skip this patch entirely till you follow the
> process allowing the patch to be tested.
> 
> Please kindly resend and include all necessary To/Cc entries.
> 
> Best regards,
> Krzysztof
>

Hi Dmitry and Vinod,

Thanks for the review. I taken care of all the comments in latest 
patchset I posted.

Regards,
Nitin


On 8/17/2023 12:19 PM, Vinod Koul wrote:
> On 16-08-23, 23:31, Dmitry Baryshkov wrote:
>> On Wed, 16 Aug 2023 at 18:50, Nitin Rawat <quic_nitirawa@quicinc.com> wrote:
>>>
>>> Document the QMP UFS PHY compatible for SC7280.
>>>
>>> Signed-off-by: Nitin Rawat <quic_nitirawa@quicinc.com>
>>> ---
>>>   .../devicetree/bindings/phy/qcom,sc8280xp-qmp-ufs-phy.yaml      | 2 ++
>>>   1 file changed, 2 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-ufs-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-ufs-phy.yaml
>>> index d981d77e82e4..ad78da9c2c1a 100644
>>> --- a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-ufs-phy.yaml
>>> +++ b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-ufs-phy.yaml
>>> @@ -31,6 +31,7 @@ properties:
>>>         - qcom,sm8350-qmp-ufs-phy
>>>         - qcom,sm8450-qmp-ufs-phy
>>>         - qcom,sm8550-qmp-ufs-phy
>>> +      - qcom,sc7280-qmp-ufs-phy
>>>
>>>     reg:
>>>       maxItems: 1
>>> @@ -110,6 +111,7 @@ allOf:
>>>                 - qcom,sm8250-qmp-ufs-phy
>>>                 - qcom,sm8350-qmp-ufs-phy
>>>                 - qcom,sm8550-qmp-ufs-phy
>>> +              - qcom,sc7280-qmp-ufs-phy
>>
>> Please keep both lists sorted.
> 
> Yes please
>