| Message ID | 20230731061325.26431-1-quic_tengfan@quicinc.com |
|---|---|
| Headers | show |
| Series | soc: qcom: Add support for SM4450 | expand |
On 31/07/2023 08:13, Tengfei Fan wrote: > Adjust the position of QCOM_ID_QDU1010, so that there is a coherent > sequence of numbers. > > Change-Id: Id083e1ecc92c063c1a07a81c66dcb034020964b0 Please run scripts/checkpatch.pl and fix reported warnings. Some warnings can be ignored, but the code here looks like it needs a fix. Feel free to get in touch if the warning is not clear. > --- > include/dt-bindings/arm/qcom,ids.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/dt-bindings/arm/qcom,ids.h b/include/dt-bindings/arm/qcom,ids.h > index bcbe9ee2cdaf..977c235ed0d9 100644 > --- a/include/dt-bindings/arm/qcom,ids.h > +++ b/include/dt-bindings/arm/qcom,ids.h > @@ -249,8 +249,8 @@ > #define QCOM_ID_SA8775P 534 > #define QCOM_ID_QRU1000 539 > #define QCOM_ID_QDU1000 545 > -#define QCOM_ID_QDU1010 587 > #define QCOM_ID_IPQ5019 569 I don't think this change is needed. Isn't IPQ5019 going away? Best regards, Krzysztof
在 7/31/2023 3:00 PM, Krzysztof Kozlowski 写道: > On 31/07/2023 08:13, Tengfei Fan wrote: >> Adjust the position of QCOM_ID_QDU1010, so that there is a coherent >> sequence of numbers. >> >> Change-Id: Id083e1ecc92c063c1a07a81c66dcb034020964b0 > > Please run scripts/checkpatch.pl and fix reported warnings. Some > warnings can be ignored, but the code here looks like it needs a fix. > Feel free to get in touch if the warning is not clear. > sure, will do this check if this patch still need. >> --- >> include/dt-bindings/arm/qcom,ids.h | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/include/dt-bindings/arm/qcom,ids.h b/include/dt-bindings/arm/qcom,ids.h >> index bcbe9ee2cdaf..977c235ed0d9 100644 >> --- a/include/dt-bindings/arm/qcom,ids.h >> +++ b/include/dt-bindings/arm/qcom,ids.h >> @@ -249,8 +249,8 @@ >> #define QCOM_ID_SA8775P 534 >> #define QCOM_ID_QRU1000 539 >> #define QCOM_ID_QDU1000 545 >> -#define QCOM_ID_QDU1010 587 >> #define QCOM_ID_IPQ5019 569 > > I don't think this change is needed. Isn't IPQ5019 going away? Will remove this patch, another is handling this: https://lore.kernel.org/lkml/20230724083745.1015321-1-quic_kathirav@quicinc.com/T/ > > > Best regards, > Krzysztof >
This series adds CPU, SoC and board compatible support for SM4450. Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com> --- v2 -> v3: - remove some bootargs arguments from sm4450-qrd.dtsi - adjust IPQ5019 related sequence in bindings and socinfo file v1 -> v2: - use hypens replace of underscores in node name - add empty lines before child nodes - drop SCM node - document qcom,sm4450-pdc compatible - drop clock-frequecny - align vertically - add reg after conmpatible, then ranges follow - update core compatible to standard ARM core name - add dcc related parameters in bootargs node - keep patch code have reasonable sort - drop unnecessary copyright - separate bindings to a single patch previous discussion here: [1] v2: https://lore.kernel.org/linux-arm-msm/20230727023508.18002-1-quic_tengfan@quicinc.com/ [2] v1: https://lore.kernel.org/linux-arm-msm/20230719100135.21325-1-quic_tengfan@quicinc.com/ Tengfei Fan (8): dt-bindings: qcom,pdc: add qcom,sm4450-pdc compatible dt-bindings: arm: qcom: Document SM4450 SoC and boards arm64: dts: qcom: Adds base SM4450 DTSI arm64: dts: qcom: Add base SM4450 QRD DTS dt-bindings: arm: qcom,ids: Adjust the position of QCOM_ID_QDU1010 soc: qcom: socinfo: adjust the position of QDU1010 dt-bindings: arm: qcom,ids: add SoC ID for SM4450 soc: qcom: socinfo: add SM4450 ID .../devicetree/bindings/arm/qcom.yaml | 6 + .../interrupt-controller/qcom,pdc.yaml | 1 + arch/arm64/boot/dts/qcom/Makefile | 1 + arch/arm64/boot/dts/qcom/sm4450-qrd.dts | 18 + arch/arm64/boot/dts/qcom/sm4450.dtsi | 431 ++++++++++++++++++ drivers/soc/qcom/socinfo.c | 3 +- include/dt-bindings/arm/qcom,ids.h | 3 +- 7 files changed, 461 insertions(+), 2 deletions(-) create mode 100644 arch/arm64/boot/dts/qcom/sm4450-qrd.dts create mode 100644 arch/arm64/boot/dts/qcom/sm4450.dtsi base-commit: d7b3af5a77e8d8da28f435f313e069aea5bcf172