From patchwork Wed May 24 15:59:30 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rob Clark X-Patchwork-Id: 686046 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52F5AC77B7A for ; Wed, 24 May 2023 16:01:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238094AbjEXQBN (ORCPT ); Wed, 24 May 2023 12:01:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54388 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238110AbjEXQAv (ORCPT ); Wed, 24 May 2023 12:00:51 -0400 Received: from mail-pg1-x531.google.com (mail-pg1-x531.google.com [IPv6:2607:f8b0:4864:20::531]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 21EF410C6; Wed, 24 May 2023 09:00:10 -0700 (PDT) Received: by mail-pg1-x531.google.com with SMTP id 41be03b00d2f7-528dd896165so368654a12.2; Wed, 24 May 2023 09:00:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1684944009; x=1687536009; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=B9cfnkHSvu3f3znujma+mgkhmHw3+ATd1xiyn5rWq0o=; b=I5y87xsIqIVtUw8NgQ8OzPnVVGKTBzR2XyPln4kjDcANDchFlG1CpGRW66ZRtFPNud gzeNokAw24CRm2J0jQ6I8jlG2FaYli9xZVT3Q3GzbnSvGVuPIf/NvQvBrFrbMDQEUAKg GV7UpSEiGg7fODuQMj7B6LXb0+SAmBCTsNMeXZGEBZu6up//eHEaHRZMFhbPt0psAweQ Vk4M0fggq5SAxZ3k3KIHlUQOYYXrEB5fJweYPEJwyDwn6PvEjH89Aucqbe4ZLBKovTKh sosgavmsbc82w+Y9U3Mw/jVLqiyeUqeMZ7DtP7atQx3IY1WYwmdN7cH7AS+3gV8WMkG0 H15Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684944009; x=1687536009; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=B9cfnkHSvu3f3znujma+mgkhmHw3+ATd1xiyn5rWq0o=; b=FCVtQSkSwfhgHZgEm702aSV2aDcvdYfLA3FH3OoltxK411My7RoPZySpTk+v64iqiz gsESMTrQFWFecgW0KyDT/W8NbSCUfVQwLgnbcXzgNOXpWTfQ6CNXFj70wVTtyUm9L0tR BGSY2HcDVnXYDROw6c27E2nwcnGLdSYWQVL8y9XrVsZx6D698psfsuBRrm+6lmKU/g3N dbw6O3s2tMXdLUirH5P3H4V1l/7g8m1slwVR0UbED3TF/tY/ELzYlklNMH47cwE+Ry9s ZJpu4BIyNqDm5u0XRLQI2EatQMpCj3S9fXlFU/JTIDcsERV88AYOmFT7oxm2cjMstlAQ ZNaw== X-Gm-Message-State: AC+VfDwyImYXf0rABmULF76fa6jmwZQVMyEUNM278YZobTMqwKrM+fQb 7aVKeeVUZfqtuJLtwe//uDA= X-Google-Smtp-Source: ACHHUZ4yDiUIV+Y7x/9WTGapmKYECnfSMNNF8AnZWdTT01U+ku9Z92d6dTBweuROpFldZkLALHJ09Q== X-Received: by 2002:a17:903:244a:b0:1ac:63b6:f1ca with SMTP id l10-20020a170903244a00b001ac63b6f1camr23696631pls.0.1684944009268; Wed, 24 May 2023 09:00:09 -0700 (PDT) Received: from localhost ([2a00:79e1:abd:4a00:61b:48ed:72ab:435b]) by smtp.gmail.com with ESMTPSA id g23-20020a170902869700b001a98f844e60sm8930176plo.263.2023.05.24.09.00.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 May 2023 09:00:08 -0700 (PDT) From: Rob Clark To: dri-devel@lists.freedesktop.org Cc: freedreno@lists.freedesktop.org, Daniel Vetter , Tvrtko Ursulin , Boris Brezillon , Christopher Healy , Emil Velikov , =?utf-8?q?Christian_K=C3=B6nig?= , Rob Clark , Alex Deucher , amd-gfx@lists.freedesktop.org (open list:RADEON and AMDGPU DRM DRIVERS), Arunpravin Paneer Selvam , Dave Airlie , Guchun Chen , Jim Cromie , Lijo Lazar , linux-arm-msm@vger.kernel.org (open list:DRM DRIVER FOR MSM ADRENO GPU), linux-doc@vger.kernel.org (open list:DOCUMENTATION), linux-kernel@vger.kernel.org (open list), =?utf-8?b?TWFyZWsgT2zFocOhaw==?= , Mario Limonciello , =?utf-8?q?Michel_D=C3=A4nzer?= , Sean Paul , Shashank Sharma , Srinivasan Shanmugam , YiPeng Chai Subject: [PATCH v5 0/7] drm: fdinfo memory stats Date: Wed, 24 May 2023 08:59:30 -0700 Message-Id: <20230524155956.382440-1-robdclark@gmail.com> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org From: Rob Clark Similar motivation to other similar recent attempt[1]. But with an attempt to have some shared code for this. As well as documentation. It is probably a bit UMA-centric, I guess devices with VRAM might want some placement stats as well. But this seems like a reasonable start. Basic gputop support: https://patchwork.freedesktop.org/series/116236/ And already nvtop support: https://github.com/Syllo/nvtop/pull/204 I've combined the separate series to add comm/cmdline override onto the end of this, simply out of convenience (they would otherwise conflict in a bunch of places). v2: Extend things to allow for multiple regions other than just system "memory", make drm_show_memory_stats() a helper so that, drivers can use it or not based on their needs (but in either case, re- use drm_print_memory_stats() v3: Docs fixes v4: use u64 for drm_memory_stats, small docs update and collected Tvrtko's a-b v5: Rebase on drm-misc-next, drop comm/cmdline override patches [1] https://patchwork.freedesktop.org/series/112397/ Rob Clark (7): drm/docs: Fix usage stats typos drm: Add common fdinfo helper drm/msm: Switch to fdinfo helper drm/amdgpu: Switch to fdinfo helper drm: Add fdinfo memory stats drm/msm: Add memory stats to fdinfo drm/doc: Relax fdinfo string constraints Documentation/gpu/drm-usage-stats.rst | 91 ++++++++++---- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 3 +- drivers/gpu/drm/amd/amdgpu/amdgpu_fdinfo.c | 32 +++-- drivers/gpu/drm/amd/amdgpu/amdgpu_fdinfo.h | 2 +- drivers/gpu/drm/drm_file.c | 132 +++++++++++++++++++++ drivers/gpu/drm/msm/msm_drv.c | 13 +- drivers/gpu/drm/msm/msm_gem.c | 15 +++ drivers/gpu/drm/msm/msm_gpu.c | 2 - include/drm/drm_drv.h | 7 ++ include/drm/drm_file.h | 32 +++++ include/drm/drm_gem.h | 32 +++++ 11 files changed, 308 insertions(+), 53 deletions(-)